Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5620629imu; Wed, 30 Jan 2019 00:18:40 -0800 (PST) X-Google-Smtp-Source: ALg8bN7DaEh3bePJE7GVpuNSXsO3CziU6/vy8ZQ0TxhbXDPNuhD4kFNTSTyTP4BhoruM8q0bbanu X-Received: by 2002:a63:9256:: with SMTP id s22mr25953185pgn.224.1548836320710; Wed, 30 Jan 2019 00:18:40 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548836320; cv=none; d=google.com; s=arc-20160816; b=esXgUk/yIgvF7O2Us+Y9QvU3oNQ+H3rsnYFlwLmmqzP7r6ubKnTaORzpk0BCV8c0ZE xIb10yaD6mBhJFh21ZRQsvHqLNPifp3wvNSiKjG+WnyYa9rpn7D4K1Ady3Ai81EmEVc1 Q/gF7l+2Iyqxk7d2h0gH0dtTtY97K5M0DpjlzqeoLmvkFcC54PTW2IycjleTKR8bINz2 jsIY+RTzaxty2ycetG5vztiHBi2aCc8N2aEx34QqsdJPLPE7sCJUQoFgS+xuiOpJgtWg euIjlthckVgYC6z0XcuWeyJ7+bLE3WnLliZacW5XJlAFwR7P9umxp6ZNMicIQDCzAkOR hviA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=c07v3eFRCVOXyTYENQwlxmL4v60pJZfN9DAmaLr1bJE=; b=sH4UAXNilNq6NSZ6K7hTXttdZLQECnSOEnlMae/gB3XazTVs1GL9oHLnRrMzhGHlUh lRd5uexuA1a47BO8ynVHOUXHjBLuAHh11tsBItp7IdQXBh7eeSF6wCz5hnai/vYBX6gP 247q9VhYmNL+F+/qJAIUXhdOwpoweTUIMOCgQwJw9joJ9qou2KC+qVBBFk2IQ+r4nGoY gXRqNeAeZ7S6o1T4+MC1cmonAF099+eYIpdYvtb903F8rf1h+EFWYAxLkNfUkou2QmZK wn81q0BACP9Hsm73vyCMbgiZL7ZNFLvCMP5rVEVPTBNzSk/YUy1PSsQV+29TYUHzCfOV 9DTQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PBem4RYZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w11si850342plz.327.2019.01.30.00.18.25; Wed, 30 Jan 2019 00:18:40 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=PBem4RYZ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730226AbfA3IQk (ORCPT + 99 others); Wed, 30 Jan 2019 03:16:40 -0500 Received: from mail-ua1-f68.google.com ([209.85.222.68]:42513 "EHLO mail-ua1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728371AbfA3IQk (ORCPT ); Wed, 30 Jan 2019 03:16:40 -0500 Received: by mail-ua1-f68.google.com with SMTP id d21so7784907uap.9 for ; Wed, 30 Jan 2019 00:16:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=c07v3eFRCVOXyTYENQwlxmL4v60pJZfN9DAmaLr1bJE=; b=PBem4RYZpO/OvXfNPQJVGAJ/r8msY2M3zLJ54Vd5yVxOtfRJUhsXmUnGnlrePTRcat ZtY8hMNCFUMX05g//ZW0tpy7RsLMzmzJE1UkHJDZf4GC8A0OVWic84gH2b/zjcYYI+0S h8YqzvjHYVUtHgH8FTzlh6fPHBQJN8XDGWruw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=c07v3eFRCVOXyTYENQwlxmL4v60pJZfN9DAmaLr1bJE=; b=L4eUpHdIBaOQiGyIWa3RqNzA0gTxhpwLzca8lccRMXWjIykoVtQbACItG+89OhzuEl MD8LQhG5u67MTmky3pMOTDPNQnTRTT2AJRMuL7N27kOWkv9MnhmnKRUgfWuimfEH5pMt hhssLxRBhvS6VC68oSbJtWtQC89Ba/tBqAA6OrbolTsBG4QPFH6xUnjXuBFXUxtrdRsh 8CwofWzCQepoVP1QWOE2mBPxBGGyg03LJXFbxdi98iwWMpf6TqyJvA5CtKtAYx9m78// 2IN1Dlm4P4D/sFgOvC4LZTyiXj+wC1X/MTLZ5LOoBIrxKwJNLM8msEa+SfpEvfGEWWEX PrIQ== X-Gm-Message-State: AJcUukcaYRwinKQh4rRcH/DrpmUISSmOxy9R+1IJg+jp1Lkh1Hu0eTcT 1C7re01X+9Ke9TEkdPD7sSYpa3ImQm7ld0rvGwm6IQ== X-Received: by 2002:a9f:2244:: with SMTP id 62mr11741335uad.119.1548836198904; Wed, 30 Jan 2019 00:16:38 -0800 (PST) MIME-Version: 1.0 References: <20190114095804.27978-1-hch@lst.de> <20190114095804.27978-6-hch@lst.de> <20190130080423.GA29937@lst.de> In-Reply-To: <20190130080423.GA29937@lst.de> From: Ulf Hansson Date: Wed, 30 Jan 2019 09:16:03 +0100 Message-ID: Subject: Re: [PATCH 05/11] mmc: s3cmci: handle highmem pages To: Christoph Hellwig Cc: Russell King , Nicolas Pitre , Aaro Koskinen , Ben Dooks , "linux-mmc@vger.kernel.org" , Linux ARM , linux-omap , "list@263.net:IOMMU DRIVERS , Joerg Roedel ," , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Jan 2019 at 09:04, Christoph Hellwig wrote: > > On Wed, Jan 30, 2019 at 08:57:47AM +0100, Ulf Hansson wrote: > > On Mon, 14 Jan 2019 at 10:58, Christoph Hellwig wrote: > > > > > > Instead of setting up a kernel pointer to track the current PIO address, > > > track the offset in the current page, and do an atomic kmap for the page > > > while doing the actual PIO operations. > > > > > > Signed-off-by: Christoph Hellwig > > > > Nitpick: This one have some trailing whitespace errors, which git > > complains about when I apply it. > > > > No need to re-spin due to this, I can fix it up. > > I'll need to respin to limit the segment size to a page anyway, so I > will take this into account as well for v2. Okay! FYI, I have no further comment on the series, it looks okay to me! Kind regards Uffe