Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190130090722.24134-1-axel.lin@ingics.com> <20190130090722.24134-2-axel.lin@ingics.com>
 <CAMpxmJX9pSJ1L9NoyKY7wMGm2FCuC5KWxCZcfnTF_dGwdD9+AQ@mail.gmail.com>
In-Reply-To: <CAMpxmJX9pSJ1L9NoyKY7wMGm2FCuC5KWxCZcfnTF_dGwdD9+AQ@mail.gmail.com>
From:   Axel Lin <axel.lin@ingics.com>
Date:   Wed, 30 Jan 2019 17:14:04 +0800
Message-ID: <CAFRkauCsJdK43YttVNexcVRozKGxJ-4YLjwTWjxxkA=C5f_SAA@mail.gmail.com>
Subject: Re: [PATCH 2/2] regulator: max77650: Convert to use regulator_enable/disable/is_enabled_regmap
To:     Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc:     Mark Brown <broonie@kernel.org>,
        Liam Girdwood <lgirdwood@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Bartosz Golaszewski <bgolaszewski@baylibre.com> =E6=96=BC 2019=E5=B9=B41=E6=
=9C=8830=E6=97=A5 =E9=80=B1=E4=B8=89 =E4=B8=8B=E5=8D=885:12=E5=AF=AB=E9=81=
=93=EF=BC=9A
>
> =C5=9Br., 30 sty 2019 o 10:07 Axel Lin <axel.lin@ingics.com> napisa=C5=82=
(a):
> >
> > By setting enable_reg, enable_mask, enable_val and disable_val, we can
> > use the regulator_enable/disable/is_enabled_regmap helpers. With this
> > change, then regB field can be removed from struct max77650_regulator_d=
esc.
> >
> > Signed-off-by: Axel Lin <axel.lin@ingics.com>
> > ---
> > Hi Bartosz,
> > I don't have this h/w, please help to review and test it.
> >
> > I think the only difference is the is_enabled checking:
> > Before the patch, it returns en !=3D MAX77650_REGULATOR_DISABLED;
> > After the patch, it returns en =3D=3D MAX77650_REGULATOR_ENABLED
> > I'm not sure if this difference does matter or not.
> >
>
> NACK. I intend to support the FPS feature of the regulator module in
> the future (see a similar thing in max77620) and I will need to extend
> these callbacks as there will be more possible values here. Regmap
> generics will not be enough.
Got it, thanks for the quick review.