Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 30 Jan 2019 19:18:14 +0900
From:   William Breathitt Gray <vilhelm.gray@gmail.com>
To:     Andrew Morton <akpm@linux-foundation.org>, linus.walleij@linaro.org
Cc:     linux-gpio@vger.kernel.org, linux-arch@vger.kernel.org,
        linux-kernel@vger.kernel.org, andriy.shevchenko@linux.intel.com,
        linux@rasmusvillemoes.dk
Subject: Re: [PATCH v8 0/8] Introduce the for_each_set_clump8 macro
Message-ID: <20190130101814.GA3668@icarus>
References: <cover.1547445576.git.vilhelm.gray@gmail.com>
 <20190129170734.688a6adf91267cc6f1b5fa08@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20190129170734.688a6adf91267cc6f1b5fa08@linux-foundation.org>
User-Agent: Mutt/1.11.2 (2019-01-07)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Jan 29, 2019 at 05:07:34PM -0800, Andrew Morton wrote:
> Do we have any expectation that these facilities will be used by
> anything other than GPIO?  If not then perhaps they should be sited
> within drivers/gpio (presumably as a standalone module) until such a
> need is found?

I can move it within drivers/gpio since my only use at moment is for
these gpio drivers I maintain. However, moving it to the gpio subsystem
does make it less likely to be seen by authors in other subsystems who
may have use for it -- so there is the chance that this becomes isolated
and untilized only amonst the gpio drivers. That may not be such a bad
thing in the end; I suspect it will be easy to spot if other subsystems
start implementing their own for_each_set_clump (if other subsystems
would even have such a need for it).

Linus, if I move the for_each_set_clump macro and related functions to
drivers/gpio, should I move the code into the gpiolib.h and gpiolib.c
files? Or would it be best to implement this as a separate standalone
module, and make a Kconfig dependency for those gpio drivers which
require it? A standalone module feels somewhat overkill for such little
code in my opinion.

William Breathitt Gray