Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5808247imu; Wed, 30 Jan 2019 04:02:58 -0800 (PST) X-Google-Smtp-Source: ALg8bN5XMMjhYh1MDWLkkUY0Ef3MJI0rB2ZqWCKbpS1MFUsIzxvI5dhojHto1kMAhxeLfh5hXgUB X-Received: by 2002:a17:902:2b8a:: with SMTP id l10mr28431968plb.70.1548849778366; Wed, 30 Jan 2019 04:02:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548849778; cv=none; d=google.com; s=arc-20160816; b=rL6Mp3WxZkoAAoqenWJ97J9jo2IW0YJKfxDXrQZznTonBcZ8VCIEpXGf/NYKle+/9Y bvrTqhRLjQKaQA+eLRRL8Zu59vdsHQa3LHScfBgqiOodn+wlcl9BzPAKimSk84kfGxhO 3gYUlqNZTgbRPy76PHhHrCTIWgIu/cUwugd/pO/FjhtJBBj01Dp/m/hFyBvFGCsHmjWq FOWkvduDE0EgcjP2PaK0IEunvvguqXhUvvg5Zt/NNN74sPDk3YT9GVpT/tQfJp/j870e 3KNW6ojWOyhc5MmdigbI8jVUtTNBGQX6X4mWQtSQGdgTnChu9lPl5av514KKlfnvuNck WlFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=jsZnxvoyh69+rD6qg+B/PTuSQp7NgTFT/Po5zAjzNSE=; b=nVfKjTi2Vqymguu9Z1aSg18E88NxJdB+FD6IA51RNCwEmLga2NFazGt0TfCiD+hHw6 xXgXrk5R87MpbxCi2Ssj7y2JALOO9+Ak5RZ2wEFZKEtl0sU54o4lizx5oXknooRZynz2 7Q9iszeCegwKI0zmyFq9QgLtqequ16HE5ij6Zftnp9XdNSiwoK5v49sGlNfskui4ApgZ QeFY0bav+c2r2s3jOGHd66NxgKmk5ZWLETSXHSSHeRHIp/XpMiwMzYkJTvxeH/J9IaC7 E9j3VUuonVpFlqVo7qoiHVdMtboyDtzcoESmLDPdkkvwXVRJXiG0tXUSVYfyXE60SkcZ hfEg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 14si1274688pgx.178.2019.01.30.04.02.42; Wed, 30 Jan 2019 04:02:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730083AbfA3MBW (ORCPT + 99 others); Wed, 30 Jan 2019 07:01:22 -0500 Received: from Galois.linutronix.de ([146.0.238.70]:46828 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726857AbfA3MBV (ORCPT ); Wed, 30 Jan 2019 07:01:21 -0500 Received: from [2a01:598:b890:92b7:fc90:b8ff:fed0:1fb6] (helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1gooYN-0006eP-8J; Wed, 30 Jan 2019 13:01:15 +0100 Date: Wed, 30 Jan 2019 13:01:02 +0100 (CET) From: Thomas Gleixner To: Peter Zijlstra cc: Heiko Carstens , Ingo Molnar , Martin Schwidefsky , LKML , linux-s390@vger.kernel.org, Stefan Liebler , Sebastian Sewior Subject: Re: [PATCH] futex: Handle early deadlock return correctly In-Reply-To: Message-ID: References: <20181127081115.GB3625@osiris> <20181129112321.GB3449@osiris> <20190128134410.GA28485@hirez.programming.kicks-ass.net> <20190128135804.GB28878@hirez.programming.kicks-ass.net> <20190129084904.GB28485@hirez.programming.kicks-ass.net> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 29 Jan 2019, Thomas Gleixner wrote: > int __rt_mutex_start_proxy_lock(struct rt_mutex *lock, > struct rt_mutex_waiter *waiter, > struct task_struct *task) > { > int ret; > > + lockdep_asssert_held(&lock->wait_lock); I'm a moron. I fixed that on the test box and wrote the changelog on the laptop. Syncing the two together was too much for my futex wreckaged brain ...