Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chris Mason <clm@fb.com>
To:     Dave Chinner <david@fromorbit.com>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
        Roman Gushchin <guro@fb.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "mhocko@kernel.org" <mhocko@kernel.org>,
        "vdavydov.dev@gmail.com" <vdavydov.dev@gmail.com>
Subject: Re: [PATCH 1/2] Revert "mm: don't reclaim inodes with many attached
 pages"
Thread-Topic: [PATCH 1/2] Revert "mm: don't reclaim inodes with many attached
 pages"
Thread-Index: AQHUuFK1zOCFq26G8UWPT6kjO3PxRaXHu+OA
Date:   Wed, 30 Jan 2019 12:21:07 +0000
Message-ID: <25EAF93D-BC63-4409-AF21-F45B2DDF5D66@fb.com>
References: <20190130041707.27750-1-david@fromorbit.com>
 <20190130041707.27750-2-david@fromorbit.com>
In-Reply-To: <20190130041707.27750-2-david@fromorbit.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [67.253.148.112]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;DM5SPR00MB335;20:Mx8BM8q4Vx1SSrQBx/fEAnQEplfrYSryiPi0ONzHsAE5VPGcTaDVNQkjLpK+sU01MT//izWKFZd+Bi4Yddb3CyB6KJH31o1oOm58H0zkNDGTD3rMAj6zBhv/pJ7HxdzfdgrHACCb3NVQ/7EyL+1JGMeaM+aEoACPc/gL7ECDfEA=
x-ms-office365-filtering-correlation-id: cde1cef4-04bb-43d5-9709-08d686ad68f9
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(2017052603328)(7153060)(7193020);SRVR:DM5SPR00MB335;
x-ms-traffictypediagnostic: DM5SPR00MB335:
x-microsoft-antispam-prvs: <DM5SPR00MB335CAEB1E407C91892C91ADD3900@DM5SPR00MB335.namprd15.prod.outlook.com>
x-forefront-prvs: 0933E9FD8D
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(396003)(136003)(39860400002)(366004)(376002)(346002)(189003)(199004)(99286004)(386003)(86362001)(6506007)(102836004)(53546011)(186003)(26005)(52116002)(76176011)(966005)(14454004)(2906002)(6116002)(3846002)(105586002)(106356001)(33656002)(316002)(54906003)(478600001)(6916009)(4326008)(82746002)(68736007)(66066001)(39060400002)(25786009)(53936002)(97736004)(305945005)(7736002)(81166006)(81156014)(8936002)(6246003)(50226002)(36756003)(229853002)(8676002)(6306002)(6486002)(6512007)(486006)(6436002)(446003)(71200400001)(256004)(4744005)(11346002)(2616005)(83716004)(71190400001)(476003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5SPR00MB335;H:DM5PR15MB1883.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: AF6+pNW7vwOG8SjERpElEJo4E9YouCqxaEOrq8p1UcTB2IENEn/CsrLqVLcbgZNVwXN6skitd0q0kqM7rcNsNky2kOR8OowcW1DwrcmdLOh5QHa6Ygw/7cErVHs3scVl7d6fZDz7DL4NUuK6l8Yxe4ytC58dViOpubdQd2bS5xLSxR6h0byWN41+espdidowXFuMBOVAdXCYyUcVn3O2EttPxFhlwrKNU38vX64RquOXauzA7ZwJfEVRb3Y2v09RGI38R6iHiOzQrdsLEDGn+w8tRx6J5xwC/eQ3nJ1BkXDwtJJPBJTSCT8Vymkn/J4uAEOjX+eEeiJteYIREDZUqaM2m0GuXOdziIS9UDRZ/kEzbi/zw+6/xCdP3lwnAMFymGV/YiJSGk100TO660N+kEmHz2xwGgmXq/Qj29v2S+0=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: cde1cef4-04bb-43d5-9709-08d686ad68f9
X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Jan 2019 12:21:05.9398
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5SPR00MB335
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-30_09:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 29 Jan 2019, at 23:17, Dave Chinner wrote:

> From: Dave Chinner <dchinner@redhat.com>
>
> This reverts commit a76cf1a474d7dbcd9336b5f5afb0162baa142cf0.
>
> This change causes serious changes to page cache and inode cache
> behaviour and balance, resulting in major performance regressions
> when combining worklaods such as large file copies and kernel
> compiles.
>
> https://bugzilla.kernel.org/show_bug.cgi?id=3D202441

I'm a little confused by the latest comment in the bz:

https://bugzilla.kernel.org/show_bug.cgi?id=3D202441#c24

Are these reverts sufficient?

Roman beat me to suggesting Rik's followup.  We hit a different problem=20
in prod with small slabs, and have a lot of instrumentation on Rik's=20
code helping.

-chris