Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5872915imu; Wed, 30 Jan 2019 05:09:21 -0800 (PST) X-Google-Smtp-Source: ALg8bN75d1tn4JQAmC2AMZFHmCS0YQWXEgcjy5Px2FkAOYMhZ+TzWjAi1144YUSblyWfKce1Pnli X-Received: by 2002:a62:7892:: with SMTP id t140mr30423135pfc.237.1548853761643; Wed, 30 Jan 2019 05:09:21 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548853761; cv=none; d=google.com; s=arc-20160816; b=wVOpxsZnWOYik2SLKOMHkdGhjJI0h0j97J2juI5gehqAv/ciUhTP5IspkibIfgTz74 EnM80UCgVflAw69i33hZGk+FUHTCLx1y8BGXVPapGlrJM+La85O7hnS2nyX1RgS5ygLr ButPDYvgTkgAe0bWhlNsUjfeFpbuH8gVbhr9Vy5DUTuku0yt89AfoUAB7Lq3YunT/BTB Gs5ng8Q1FyaPvxz8uuFNXtRlhlzua/kQ7K6qfOGqkmaRVVkZuWCVTm+8b1kiV6UUM+e2 GlvCe87IlAATjNrsT30uGBAflJ2/DEa74sAvS9O5x9eI6liQ+KPN/8CS9JgNKhWvWcA2 amog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=UeDNeUTSWkpbPeXhSl+suDO9SxNbnK7mIWzttylKNi0=; b=x8In7Jiwx/gY8ofmXrCJUmAc6ZuGtzUxwd4ZMZGwhpT/DlltIOOTCo5RFSfHVy5gw3 YdCXL7JdU6o4qsLWonHINW1ruYBvHtZpaMOnULrj8NX8jCrUsYlL/0J9POMWP5RXv5k0 ZFW1HJmD2ZRre8bW3etr14n7E2iqwIKLCdw4FAlgblF5oT7pwSQSUAVKOTcAmeqAkGzd 2Z39bWdwkRxWDSc5EF27jl3sLmFr+WYQxVBVfGkK52lFdVYYYtE0sb3QtOUVlz4jrvis VILhC10LAlRLvvL1n4CxCM4yYfA/4aYVzxYyGZ8Il4G4g/AMjJQvN5oE27phULMyu8yH fwCA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SNLk7eZj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s24si1511847plq.41.2019.01.30.05.09.05; Wed, 30 Jan 2019 05:09:21 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=SNLk7eZj; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730787AbfA3NHm (ORCPT + 99 others); Wed, 30 Jan 2019 08:07:42 -0500 Received: from mail-wr1-f66.google.com ([209.85.221.66]:37193 "EHLO mail-wr1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725768AbfA3NHm (ORCPT ); Wed, 30 Jan 2019 08:07:42 -0500 Received: by mail-wr1-f66.google.com with SMTP id s12so25970123wrt.4 for ; Wed, 30 Jan 2019 05:07:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=UeDNeUTSWkpbPeXhSl+suDO9SxNbnK7mIWzttylKNi0=; b=SNLk7eZjaaszko0mKEiGMiXA1Jn+xNzdDmjDVftHAMXnEtyT5t5R2oeCQEUAIFipZ4 HTN66hvkYEZBykIdKj1IiJS+i1sWceG+NxYnS4oWg9QsMQ0vSFDn2wGWJ4Z4BRVVnjSu 9sMveh/F3sj0DfKDS6bNQKvI0DRu4U8tjStaE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=UeDNeUTSWkpbPeXhSl+suDO9SxNbnK7mIWzttylKNi0=; b=rRv4p+avc1ivYCdF1GnbiKLweVlCdU2ZPTkN+vwAld83nN9fHuAMYyEPDZ7FlVLcPl 5Dvuk9jn0HPM5M26dXvaQWwYlSt9CC43QgKMloCrrph1TnfHv2Z8H1ko5eFdhWtWRC8/ qDWFg8T2KT4GSkVl7U+AIn54PUT2dvPe2BEWGHVFP/JgV2qt7ckUThdHa82oA7XsLGBS bqbsYWjVHVyt/Q8JdYCkqNWjgLYR7gP/l4H9m9/gBR14BnHdkPzYGmdo5bP2vM7wpaaW PW/SPq7PinXjBnl51peGqAoQGKrGlXyLqoIl6JitAFoVkCXO1yMbMf8+ksI4XLWNmPlf 0u2g== X-Gm-Message-State: AJcUuke6GCTwN3ejxA0ZBxRbSdGjhpNqVVrI7ABI7DNMJ3bEy3ErXL5a cSjSwMVjfdVIEyoOdMLczFf8Xg== X-Received: by 2002:a5d:6850:: with SMTP id o16mr30821645wrw.123.1548853660315; Wed, 30 Jan 2019 05:07:40 -0800 (PST) Received: from dell ([2.27.35.198]) by smtp.gmail.com with ESMTPSA id h10sm2037050wmf.44.2019.01.30.05.07.39 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 05:07:39 -0800 (PST) Date: Wed, 30 Jan 2019 13:07:38 +0000 From: Lee Jones To: Pi-Hsun Shih Cc: Nicolas Boichat , Enric Balletbo Serra , Guenter Roeck , Benson Leung , Enric Balletbo i Serra , open list Subject: Re: [RFC v3 5/5] cros_ec: differentiate SCP from EC by feature bit. Message-ID: <20190130130738.GC4701@dell> References: <20190121071833.43443-1-pihsun@chromium.org> <20190121071833.43443-6-pihsun@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190121071833.43443-6-pihsun@chromium.org> User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 21 Jan 2019, Pi-Hsun Shih wrote: > Since a SCP and EC would both exist on a system, and use the cros_ec_dev > driver, we need to differentiate between them for the userspace, or they > would both be registered at /dev/cros_ec, causing a conflict. > > Cc: Enric Balletbo Serra > Cc: Guenter Roeck > Signed-off-by: Pi-Hsun Shih > --- > Changes from v2: > - No change. > > Changes from v1: > - New patch extracted from Patch 5. > --- > drivers/mfd/cros_ec_dev.c | 9 +++++++++ > include/linux/mfd/cros_ec.h | 1 + > include/linux/mfd/cros_ec_commands.h | 2 ++ > 3 files changed, 12 insertions(+) Just to clarify to the new Cc'ed list, I'm waiting on one of the Chromium guys to review before I put my mucky paws over it. -- Lee Jones [李琼斯] Linaro Services Technical Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog