Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 30 Jan 2019 08:09:29 -0600
From:   Bjorn Helgaas <helgaas@kernel.org>
To:     Aleksey Makarov <aleksey.makarov@cavium.com>
Cc:     netdev@vger.kernel.org, Robert Richter <rric@kernel.org>,
        "Goutham, Sunil" <Sunil.Goutham@cavium.com>,
        Richard Cochran <richardcochran@gmail.com>,
        Radoslaw Biernacki <rad@semihalf.com>,
        linux-kernel@vger.kernel.org,
        David Daney <ddaney@caviumnetworks.com>,
        Philippe Ombredanne <pombredanne@nexb.com>,
        Joe Perches <joe@perches.com>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH net-next v6 1/2] net: add support for Cavium PTP
 coprocessor
Message-ID: <20190130140929.GA227269@google.com>
References: <20180115124500.14872-1-aleksey.makarov@cavium.com>
 <20180115124500.14872-2-aleksey.makarov@cavium.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20180115124500.14872-2-aleksey.makarov@cavium.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jan 15, 2018 at 06:44:56PM +0600, Aleksey Makarov wrote:
> From: Radoslaw Biernacki <rad@semihalf.com>
> 
> This patch adds support for the Precision Time Protocol
> Clocks and Timestamping hardware found on Cavium ThunderX
> processors.
> 
> Signed-off-by: Radoslaw Biernacki <rad@semihalf.com>
> Signed-off-by: Aleksey Makarov <aleksey.makarov@cavium.com>
> Acked-by: Philippe Ombredanne <pombredanne@nexb.com>
> ---
>  drivers/net/ethernet/cavium/Kconfig             |  12 +
>  drivers/net/ethernet/cavium/Makefile            |   1 +
>  drivers/net/ethernet/cavium/common/Makefile     |   1 +
>  drivers/net/ethernet/cavium/common/cavium_ptp.c | 353 ++++++++++++++++++++++++
>  drivers/net/ethernet/cavium/common/cavium_ptp.h |  70 +++++
>  5 files changed, 437 insertions(+)
>  create mode 100644 drivers/net/ethernet/cavium/common/Makefile
>  create mode 100644 drivers/net/ethernet/cavium/common/cavium_ptp.c
>  create mode 100644 drivers/net/ethernet/cavium/common/cavium_ptp.h
> 
> diff --git a/drivers/net/ethernet/cavium/Kconfig b/drivers/net/ethernet/cavium/Kconfig
> index 63be75eb34d2..96586c0b4490 100644
> --- a/drivers/net/ethernet/cavium/Kconfig
> +++ b/drivers/net/ethernet/cavium/Kconfig
> @@ -50,6 +50,18 @@ config	THUNDER_NIC_RGX
>  	  This driver supports configuring XCV block of RGX interface
>  	  present on CN81XX chip.
>  
> +config CAVIUM_PTP
> +	tristate "Cavium PTP coprocessor as PTP clock"
> +	depends on 64BIT
> +	imply PTP_1588_CLOCK
> +	default y

Why is this "default y"?

It looks like this is a PCI driver and probably should be loaded only
when the PCI device is present.

> +	---help---
> +	  This driver adds support for the Precision Time Protocol Clocks and
> +	  Timestamping coprocessor (PTP) found on Cavium processors.
> +	  PTP provides timestamping mechanism that is suitable for use in IEEE 1588
> +	  Precision Time Protocol or other purposes.  Timestamps can be used in
> +	  BGX, TNS, GTI, and NIC blocks.