Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181224143218.GA3170@hp-pavilion-15-notebook-pc-brajeswar> <1891132.39bZHgSTRL@avalon>
In-Reply-To: <1891132.39bZHgSTRL@avalon>
From:   Brajeswar Ghosh <brajeswar.linux@gmail.com>
Date:   Wed, 30 Jan 2019 20:07:12 +0530
Message-ID: <CAFqtX7kfsgc+VRuSB_TQhFk4DqCChaR6uBZEsnhuwLPCg_k2xw@mail.gmail.com>
Subject: Re: [PATCH] drm/bridge/panel: Remove duplicate header
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     Archit Taneja <architt@codeaurora.org>, a.hajda@samsung.com,
        airlied@linux.ie, Souptick Joarder <jrdr.linux@gmail.com>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
        Sabyasachi Gupta <sabyasachi.linux@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Dec 26, 2018 at 3:09 PM Laurent Pinchart
<laurent.pinchart@ideasonboard.com> wrote:
>
> Hi Brajeswar,
>
> Thank you for the patch.
>
> On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote:
> > Remove drm/drm_panel.h which is included more than once
> >
> > Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
> > ---
> >  drivers/gpu/drm/bridge/panel.c | 1 -
> >  1 file changed, 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> > index 7cbaba213ef6..402b318eeeb2 100644
> > --- a/drivers/gpu/drm/bridge/panel.c
> > +++ b/drivers/gpu/drm/bridge/panel.c
> > @@ -15,7 +15,6 @@
> >  #include <drm/drm_crtc_helper.h>
> >  #include <drm/drm_encoder.h>
> >  #include <drm/drm_modeset_helper_vtables.h>
> > -#include <drm/drm_panel.h>
>
> While at it, how about sorting headers alphabetically to make sure this won't
> happen again ?
>
> With that change,
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

If no further comment, can we get this patch in queue for 5.1 ?

>
> >  struct panel_bridge {
> >       struct drm_bridge bridge;
>
> --
> Regards,
>
> Laurent Pinchart
>
>
>