Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 30 Jan 2019 06:48:51 -0800
From:   Luis Chamberlain <mcgrof@kernel.org>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     Vincent Whitchurch <vincent.whitchurch@axis.com>,
        keescook@chromium.org, linux-kernel@vger.kernel.org,
        Vincent Whitchurch <rabinv@axis.com>
Subject: Re: [PATCH v2] sysctl: Add panic-fatal-signals
Message-ID: <20190130144851.GK11489@garbanzo.do-not-panic.com>
References: <20190128084959.13060-1-vincent.whitchurch@axis.com>
 <20190128100545.b62193aa8f49e1de8d6ea8b7@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190128100545.b62193aa8f49e1de8d6ea8b7@linux-foundation.org>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Jan 28, 2019 at 10:05:45AM -0800, Andrew Morton wrote:
> On Mon, 28 Jan 2019 09:49:59 +0100 Vincent Whitchurch <vincent.whitchurch@axis.com> wrote:
> > --- a/init/Kconfig
> > +++ b/init/Kconfig
> > @@ -1242,6 +1242,20 @@ config SYSCTL_SYSCALL
> >  
> >  	  If unsure say N here.
> >  
> > +config SYSCTL_PANIC_FATAL_SIGNALS
> > +	bool "panic-fatal-signals sysctl" if EXPERT
> > +	depends on PROC_SYSCTL
> > +	help
> > +	  If you say Y here, a kernel.panic-fatal-signals sysctl will be
> > +	  offered.  If this sysctl is turned on, the kernel will panic if any
> > +	  userspace process receives a fatal signal which would trigger a core
> > +	  dump.
> > +
> > +	  When used together with kernel core dumps, this can be useful for
> > +	  debugging some system-wide problems, primarily on embedded systems.
> > +
> > +	  If unsure, say N.
> 
> I suggest that the Kconfig help and the forthcoming documentation
> should clearly explain the dangers of enabling this!

And so, should default to n.

  Luis