Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6035078imu;
        Wed, 30 Jan 2019 07:43:20 -0800 (PST)
X-Google-Smtp-Source: ALg8bN4TLanLeZHv9zS4hRI5REV53o8JLJl37WynQhXJt++Vh7cS2K/fv8sO5Enb121Cyk+TTm+x
X-Received: by 2002:a65:43c5:: with SMTP id n5mr28723853pgp.250.1548863000424;
        Wed, 30 Jan 2019 07:43:20 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1548863000; cv=none;
        d=google.com; s=arc-20160816;
        b=h8+RIfkY4Ctp9y/Jcy+Aqv5HHWcnK09JJHy/0SoL3X+/uDuNL+OyWXlaGw7HEelwRz
         pY9rLj7WuqJ3ABqFlLxeCd/CSAz3qjdVRJ2RBSKSiK2OIc55DaF/SIk7hpAvqy5V1VI2
         Z8g1LFmhnm8tFbbdRSy/mgqiu7NE1iCuXd+OSHBy85pI+ikZwBNQuVerjrlYIZs2TNEU
         2GhaM6FMGXzT+3N3lXhBVHBCldg39YhdMWjWMAJkSVbguK96WHuNyJHsjKKTCeqQLg/D
         3czMMTSPYO2wzLyZB2zzO/m0iTor2aPtp400GnEjQu4qvZQ0YsRBIvL8IWqzs5gok0tV
         ja2w==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=srnlMIxokBTxYZXiBHy05Yu9e00S5ckC1uwb3tFkb9o=;
        b=BEg8jVnkB2JZGboK072Jzpib4kIcQdJdp3ZWQ/5Qm+aQWTWhVolZ05IrYLcnP2wEyX
         RxyqqO2EyHUFrPziMCOd2tPTggO/3GGvpPlBMGioVFtJk3QgBqJtIXknUHv1buErxWMJ
         YSWn46CxkhpR9BPWNgeFB4EyelATo519wx7EmKCV04nd8ManVlls4t2xU2m5QKLWZFqz
         6bTDeUk8DRkYD8wVN9MeUtYGyRHe+d7rxuC/zF8wUtJOQnFlRej+lxi4HaXYT/Iytcoc
         5ML/+mo/s+nus2F60gF2MeJ54hf/mZZmrVHO31mLr35bJuHtymWuc8f56LotZkOQyQdh
         PaSg==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id a24si1644015pgd.248.2019.01.30.07.43.03;
        Wed, 30 Jan 2019 07:43:20 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1731272AbfA3Pmr (ORCPT <rfc822;yxhlfx@gmail.com> + 99 others);
        Wed, 30 Jan 2019 10:42:47 -0500
Received: from zeniv.linux.org.uk ([195.92.253.2]:48172 "EHLO
        ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1729884AbfA3Pmr (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 30 Jan 2019 10:42:47 -0500
Received: from viro by ZenIV.linux.org.uk with local (Exim 4.91 #2 (Red Hat Linux))
        id 1gos0j-00046N-Sn; Wed, 30 Jan 2019 15:42:45 +0000
Date:   Wed, 30 Jan 2019 15:42:45 +0000
From:   Al Viro <viro@zeniv.linux.org.uk>
To:     Cyrill Gorcunov <gorcunov@gmail.com>
Cc:     LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH next] fs/splice: iter_to_pipe -- Use PIPE_DEF_BUFFERS
 instead of hardcoded number
Message-ID: <20190130154245.GK2217@ZenIV.linux.org.uk>
References: <20190130153911.GJ2332@uranus.lan>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190130153911.GJ2332@uranus.lan>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 30, 2019 at 06:39:11PM +0300, Cyrill Gorcunov wrote:
> And use ARRAY_SIZE for easier code modification if we ever need in future.

Umm...  Why PIPE_DEF_BUFFERS, though?  Because it's a constant from more or
less the same area that happens to be equal to the value we use here?