Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6072733imu; Wed, 30 Jan 2019 08:20:13 -0800 (PST) X-Google-Smtp-Source: ALg8bN7N5Xj+6yROfM8RdBqb2bu/knzdtUBIhkuhz+poAmdzihlySDl5K+A9b6mghFF/RR3pPJkH X-Received: by 2002:a63:83c1:: with SMTP id h184mr27966940pge.437.1548865213332; Wed, 30 Jan 2019 08:20:13 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548865213; cv=none; d=google.com; s=arc-20160816; b=NrKkOC6gUsmyDxwQv1n/wL+Tud4X1rP5z+3hfrY0BzYJ3H1yMF/CVl2HHgwTA5zml5 xVam/NxMwstgBh+mMy3MdiXohUY1UBt2Ucq5LaVCuxP3/h5quZzYMXUaWmV/0uVC+h+u nL0xRRhGe1LTo5ROtCVOweS0LelHCpXVxfWAMz1hpOlNwL8dtrggZQQRlhpMNeKyXsmC j7ih3QUjmJdAlOOnrStK7FilIu9Oe/C+hqRbSYdY46LeRFCUtwXZZKVk1KnQfPOGVea1 jhZsF17wzPXV7szERS1bq8j37uGrmywALY2i3b5BftTEbLFJYUQVFyZEpjY7Mf0oXgff agUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=RnNH3KefH9BKp5fCeCTBb5Miw1UaixFZo+DJArm4Kjo=; b=t1hc4PuHlMdlScbkMUYJ2CEe3Z2/Wi5TiCdKsJHJyZvWxb/qFed7/28eOSOPTkjbmm XD5g9IwS+/Hxc8sOR4LYw38FN1mNV3Gr5Zy9aL+0m9g4Rt0TEDB5DHhF+mpbavg0XCJj ZmyLMVJi3EB/gQerBGHNS0IvxFTo2fNtUJRdhKOVKnklieikw+AU1nGQ+FQzGrh1Oipu 7VMippVgLKy8zDWici8XS9Bu7QbEevPEg2KPm1NmCuBlPl1HYcGN7aegJ7n3xAwOFbAU wgjtQSVSUFiL8yFjKDg4nwDXw7mqEDD4tbX31iARDSiafejvWoVp2w7RHVlebc5Ab494 p0bw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q140si2118234pfc.20.2019.01.30.08.19.56; Wed, 30 Jan 2019 08:20:13 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731836AbfA3QRR (ORCPT + 99 others); Wed, 30 Jan 2019 11:17:17 -0500 Received: from mail-ot1-f65.google.com ([209.85.210.65]:40219 "EHLO mail-ot1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727546AbfA3QRR (ORCPT ); Wed, 30 Jan 2019 11:17:17 -0500 Received: by mail-ot1-f65.google.com with SMTP id s5so66166oth.7; Wed, 30 Jan 2019 08:17:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RnNH3KefH9BKp5fCeCTBb5Miw1UaixFZo+DJArm4Kjo=; b=pqTM4n5dLjlDTMYh98GpXaQbJME6c94VjkksO4hq2kCoM5UF/zWt83723hx5o0nGMu Seh9mYnvS1lPTGf+sI1EhTrEt3k5nZem6P9C3jkyIbumxVCYaP/9m+wHresMK3al+vGO Q/Tm2naFHrEbK0ArtQ8K4bexJo296nwLHx164xYdjPdkj0ajjShGQldGABwBd4LwH0E8 sJMQV3nn0gYMN2onFJ+CzC/0dSlb6Fy7AQGZW6NeO58cp6+0iJWM9GzuVdWEO00hpCbX 62ahn527h2lVwUBM56l1Glttl4CBeU9gIgMisoJfoQ0fgaIBxefHdNiocZofWHyvMNKR lniw== X-Gm-Message-State: AJcUukeRnZwCykoLeG3+qURHE7U3G4sCUM+2ZV3UfLGHTJI9boZ8mG54 Ur1738XInKGRKlgzjrktpA== X-Received: by 2002:a9d:3464:: with SMTP id v91mr24557950otb.102.1548865035425; Wed, 30 Jan 2019 08:17:15 -0800 (PST) Received: from localhost (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id u136sm804401oie.38.2019.01.30.08.17.14 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 08:17:14 -0800 (PST) Date: Wed, 30 Jan 2019 10:17:14 -0600 From: Rob Herring To: Erin Lo Cc: Matthias Brugger , Mark Rutland , Thomas Gleixner , Jason Cooper , Marc Zyngier , Greg Kroah-Hartman , Stephen Boyd , devicetree@vger.kernel.org, srv_heupstream , linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, yingjoe.chen@mediatek.com, mars.cheng@mediatek.com, eddie.huang@mediatek.com, linux-clk@vger.kernel.org, Zhiyong Tao Subject: Re: [PATCH v6 5/6] dt-bindings: pinctrl: mt8183: add binding document Message-ID: <20190130161714.GA24352@bogus> References: <1548317240-44682-1-git-send-email-erin.lo@mediatek.com> <1548317240-44682-6-git-send-email-erin.lo@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1548317240-44682-6-git-send-email-erin.lo@mediatek.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 24, 2019 at 04:07:19PM +0800, Erin Lo wrote: > From: Zhiyong Tao > > The commit adds mt8183 compatible node in binding document. > > Signed-off-by: Zhiyong Tao > Signed-off-by: Erin Lo > --- > .../devicetree/bindings/pinctrl/pinctrl-mt8183.txt | 115 +++++++++++++++++++++ > 1 file changed, 115 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pinctrl/pinctrl-mt8183.txt > > diff --git a/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8183.txt b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8183.txt > new file mode 100644 > index 0000000..364e673 > --- /dev/null > +++ b/Documentation/devicetree/bindings/pinctrl/pinctrl-mt8183.txt > @@ -0,0 +1,115 @@ > +* Mediatek MT8183 Pin Controller > + > +The Mediatek's Pin controller is used to control SoC pins. > + > +Required properties: > +- compatible: value should be one of the following. > + "mediatek,mt8183-pinctrl", compatible with mt8183 pinctrl. > +- gpio-controller : Marks the device node as a gpio controller. > +- #gpio-cells: number of cells in GPIO specifier. Since the generic GPIO > + binding is used, the amount of cells must be specified as 2. See the below > + mentioned gpio binding representation for description of particular cells. > +- gpio-ranges : gpio valid number range. > +- reg: physicall address base for gpio base registers. There are nine > + physicall address base in mt8183. They are 0x10005000, 0x11F20000, Still have a typo in 'physicall' > + 0x11E80000, 0x11E70000, 0x11E90000, 0x11D30000, 0x11D20000, 0x11C50000, > + 0x11F30000. You don't need to list the address values. Only how many and what each one is. > + > + Eg: <&pio 6 0> > + <[phandle of the gpio controller node] > + [line number within the gpio controller] > + [flags]> > + > + Values for gpio specifier: > + - Line number: is a value between 0 to 202. > + - Flags: bit field of flags, as defined in . > + Only the following flags are supported: > + 0 - GPIO_ACTIVE_HIGH > + 1 - GPIO_ACTIVE_LOW > + > +Optional properties: > +- reg-names: gpio base register names. There are nine gpio base register > + names in mt8183. They are "iocfg0", "iocfg1", "iocfg2", "iocfg3", "iocfg4", > + "iocfg5", "iocfg6", "iocfg7", "iocfg8". As I said before, these names aren't useful. There's already inheritently an index with 'reg'. Unless some are optional and can be sparsely populated. > +- interrupt-controller: Marks the device node as an interrupt controller > +- #interrupt-cells: Should be two. > +- interrupts : The interrupt outputs from the controller. > + > +Please refer to pinctrl-bindings.txt in this directory for details of the > +common pinctrl bindings used by client devices. > + > +Subnode format > +A pinctrl node should contain at least one subnodes representing the > +pinctrl groups available on the machine. Each subnode will list the > +pins it needs, and how they should be configured, with regard to muxer > +configuration, pullups, drive strength, input enable/disable and input schmitt. > + > + node { > + pinmux = ; > + GENERIC_PINCONFIG; > + }; > + > +Required properties: > +- pinmux: integer array, represents gpio pin number and mux setting. > + Supported pin number and mux varies for different SoCs, and are defined > + as macros in boot/dts/-pinfunc.h directly. > + > +Optional properties: > +- GENERIC_PINCONFIG: is the generic pinconfig options to use, bias-disable, > + bias-pull-down, bias-pull-up, input-enable, input-disable, output-low, output-high, > + input-schmitt-enable, input-schmitt-disable and drive-strength are valid. > + > + Some special pins have extra pull up strength, there are R0 and R1 pull-up > + resistors available, but for user, it's only need to set R1R0 as 00, 01, 10 or 11. > + So when config mediatek,pull-up-adv or mediatek,pull-down-adv, > + it support arguments for those special pins. > + > + When config drive-strength, it can support some arguments, such as > + MTK_DRIVE_4mA, MTK_DRIVE_6mA, etc. See dt-bindings/pinctrl/mt65xx.h. > + > +Examples: > + > +#include "mt8183-pinfunc.h" > + > +... > +{ > + pio: pinctrl@10005000 { > + compatible = "mediatek,mt8183-pinctrl"; > + reg = <0 0x10005000 0 0x1000>, > + <0 0x11F20000 0 0x1000>, > + <0 0x11E80000 0 0x1000>, > + <0 0x11E70000 0 0x1000>, > + <0 0x11E90000 0 0x1000>, > + <0 0x11D30000 0 0x1000>, > + <0 0x11D20000 0 0x1000>, > + <0 0x11C50000 0 0x1000>, > + <0 0x11F30000 0 0x1000>; Use lowercase hex. > + reg-names = "iocfg0", "iocfg1", "iocfg2", > + "iocfg3", "iocfg4", "iocfg5", > + "iocfg6", "iocfg7", "iocfg8"; > + gpio-controller; > + #gpio-cells = <2>; > + gpio-ranges = <&pio 0 0 192>; > + interrupt-controller; > + interrupts = ; > + interrupt-parent = <&gic>; > + #interrupt-cells = <2>; > + > + i2c0_pins_a: i2c0 { > + pins1 { > + pinmux = , > + ; > + mediatek,pull-up-adv = <11>; > + }; > + }; > + > + i2c1_pins_a: i2c1 { > + pins { > + pinmux = , > + ; > + mediatek,pull-down-adv = <10>; > + }; > + }; > + ... > + }; > +}; > -- > 1.9.1 >