Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6081141imu; Wed, 30 Jan 2019 08:29:23 -0800 (PST) X-Google-Smtp-Source: ALg8bN7lL4JvyOZ7cdnrGXA+JGob0y1uQ/e4jsvmq9dq9/YIVtHIWvf9KUJrcQhWw5q/rVpkkOt9 X-Received: by 2002:a63:a112:: with SMTP id b18mr28310981pgf.440.1548865763020; Wed, 30 Jan 2019 08:29:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548865762; cv=none; d=google.com; s=arc-20160816; b=Z/eHvulcaJJGyZUr7FbEEMxuaPigSsLlLY4Kay4eADpdJtBNUtbZL8NKFkwg5ajXAR 5WRCLWNw6G1ZwVXS5D/+FZZhlBawtp/P9kDFZ26i97aY/KR2e9GGlB9kwXzxW39L4oY3 fLP3EFxm4IHDAgOQ5gTRQdidB4DvnSTIO/ygd12a8bY4YVhLgmw4NXfwHq4PRu9dMAey OLOl2FbYuRLt21+KnX7fmgac00O5WWLIKadv+r6F9M17KkiUOnRGH8gkGbJvnGPtXEnY zl0LB+Rl36DzoLQAKDZah2lZJHkWB65GpnUnClNqU065D04E6mL+T+IxEkS1gbnyuino c4bA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=9gue3402KzIgxCo5q+49si+/eb/5mQL/ul01IgVehn4=; b=q/yHqOA6LXhh6Iuf3j2rtbsZ4c4iHl8QSas/sKNgVPNHKVqvd3kxj+t4TQgoPuAznu +zSMjwldMYeC21OlZHHflt+OKG+xu1tOmKfKqPItTGbrx7TuaT6RZqVefsbTwnBUvTmj EWgawRL9Sa3tkpzFA/KGWI6JeAkk0AA3q2i5wdLzbnnWUKDmHzYpdg0oTDDGsnX+kW58 MDtXTonlztd3Fq60H1WqgBWaO6aWcv596jlabcvmWlS/3G1zMdcbk9yzI/6Tkukk3ts4 DZeDd1H/VYZkLRuS58feMW3l1VSSKdl9es9PFG8OB+5SpBtJsFFb/Z93CzWeWoFq5pIA usUg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c7si1814603plz.118.2019.01.30.08.29.07; Wed, 30 Jan 2019 08:29:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=8bytes.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731742AbfA3Q04 (ORCPT + 99 others); Wed, 30 Jan 2019 11:26:56 -0500 Received: from 8bytes.org ([81.169.241.247]:35968 "EHLO theia.8bytes.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727371AbfA3Q04 (ORCPT ); Wed, 30 Jan 2019 11:26:56 -0500 Received: by theia.8bytes.org (Postfix, from userid 1000) id 10C0C5B8; Wed, 30 Jan 2019 17:26:54 +0100 (CET) Date: Wed, 30 Jan 2019 17:26:53 +0100 From: Joerg Roedel To: Jerry Snitselaar Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iommu/amd: print reason for iommu_map_page failure in map_sg Message-ID: <20190130162653.ji6megm3al3uf6zt@8bytes.org> References: <20190129005937.32487-1-jsnitsel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190129005937.32487-1-jsnitsel@redhat.com> User-Agent: NeoMutt/20170421 (1.8.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 28, 2019 at 05:59:37PM -0700, Jerry Snitselaar wrote: > Since there are multiple possible failures in iommu_map_page > it would be useful to know which case is being hit when the > error message is printed in map_sg. While here, fix up checkpatch > complaint about using function name in a string instead of > __func__. > > Cc: Joerg Roedel > Signed-off-by: Jerry Snitselaar Applied, thanks.