Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
IronPort-PHdr: =?us-ascii?q?9a23=3AomGvURNMXO+xM7bTI6Yl6mtUPXoX/o7sNwtQ0KIM?=
 =?us-ascii?q?zox0LfT5rarrMEGX3/hxlliBBdydt6oUzbKO+4nbGkU4qa6bt34DdJEeHzQksu?=
 =?us-ascii?q?4x2zIaPcieFEfgJ+TrZSFpVO5LVVti4m3peRMNQJW2aFLduGC94iAPERvjKwV1?=
 =?us-ascii?q?Ov71GonPhMiryuy+4ZLebxlLiTanfb9+MAi9oBnMuMURnYZsMLs6xAHTontPde?=
 =?us-ascii?q?RWxGdoKkyWkh3h+Mq+/4Nt/jpJtf45+MFOTav1f6IjTbxFFzsmKHw65NfqtRbY?=
 =?us-ascii?q?UwSC4GYXX3gMnRpJBwjF6wz6Xov0vyDnuOdxxDWWMMvrRr0vRz+s87lkRwPpiC?=
 =?us-ascii?q?cfNj427mfXitBrjKlGpB6tvgFzz5LIbI2QMvd+e6LdfcgBRWpAWMZRWDFKDJ2l?=
 =?us-ascii?q?YYASAeoBPPhXr43gqFATqRezCxWgCObpxzRVhHH5wLc63vwhHw/YwQIuEdEAvn?=
 =?us-ascii?q?PPodnpKKsfS/y5wbPUwTnfaf5dxDfz6JLPchAkufyDX7NwcMvRyUkyEAPOk1Kd?=
 =?us-ascii?q?qIzkPjOVzOsNsnSX4/ZuWO+0lm4otxtxriKxycgxl4nEn4QYwU3H+yVh2Is5O8?=
 =?us-ascii?q?G0RUphbdOnEJZcrT+WO5Z2T884XW1kpDo2xqUbtZO6eCUG0ooryhDfZvCdbYSF?=
 =?us-ascii?q?4wjvWeSeLDp+mXlrYqiwhwyo/kil0uD8U86030tUoSddidnMs2wN1wTU6siaVv?=
 =?us-ascii?q?tx5keh1iiL1wDU8uxEJFo7lavfK5I42r4wmYcfvV3NHiPohEn6kLWadkoj+uiv?=
 =?us-ascii?q?5OTnZqvpqoWAOI9zjwHyKqUumsqhDuQkKgUCQXSX9OCm2LDg/UD1WqtGguA2n6?=
 =?us-ascii?q?XDrpzWOdgXqra8AwBP04Yj7xi/Dy2h0NQdhXQGLFNEeBKdgIjoJ13CPP71AOyi?=
 =?us-ascii?q?g1uwijdn3e7JMaD8ApnVNHjMjK/hfaph605b0AczydFf55RJCrAOOf7zWVH+tM?=
 =?us-ascii?q?beDhAnNwy52PjnCNpj2YMEQ26PAbGWMLnUsVCW4uIjOe6MZJUauGW1BeIi4qvf?=
 =?us-ascii?q?jG05hFhVKbi73ZIWMCjjNultOQOUbWe60YRJKnsDogdrFL+is1aFSzMGIinqUg?=
 =?us-ascii?q?=3D=3D?=
From:   Yizhuo <yzhai003@ucr.edu>
Cc:     csong@cs.ucr.edu, zhiyunq@cs.ucr.edu, Yizhuo <yzhai003@ucr.edu>,
        Mauro Carvalho Chehab <mchehab@kernel.org>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] [media] ts2020: Variable "utmp" in function ts2020_set_tuner_rf() could be uninitialized
Date:   Wed, 30 Jan 2019 09:33:30 -0800
Message-Id: <20190130173331.4672-1-yzhai003@ucr.edu>
To:     unlisted-recipients:; (no To-header on input)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

In function ts2020_set_tuner_rf(), local variable "utmp" could
be uninitialized if function regmap_read() returns -EINVAL.
However, this value is used in if statement and written to
the register, which is potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 drivers/media/dvb-frontends/ts2020.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/drivers/media/dvb-frontends/ts2020.c b/drivers/media/dvb-frontends/ts2020.c
index 931e5c98da8a..e351039f2eae 100644
--- a/drivers/media/dvb-frontends/ts2020.c
+++ b/drivers/media/dvb-frontends/ts2020.c
@@ -177,9 +177,12 @@ static int ts2020_set_tuner_rf(struct dvb_frontend *fe)
 {
 	struct ts2020_priv *dev = fe->tuner_priv;
 	int ret;
-	unsigned int utmp;
+	unsigned int utmp = 0;
 
 	ret = regmap_read(dev->regmap, 0x3d, &utmp);
+	if (ret)
+		return ret;
+
 	utmp &= 0x7f;
 	if (utmp < 0x16)
 		utmp = 0xa1;
-- 
2.17.1