Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6157360imu; Wed, 30 Jan 2019 09:44:05 -0800 (PST) X-Google-Smtp-Source: ALg8bN6yeviA11IRo0OQ1X0D70zh9pDNpXANgDIFstCwDXzqoqOKAylrUVdN8QxKshJMjQRfsjzj X-Received: by 2002:a63:2263:: with SMTP id t35mr28373691pgm.69.1548870245508; Wed, 30 Jan 2019 09:44:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548870245; cv=none; d=google.com; s=arc-20160816; b=XD0AVL0XNuIxe0nnjsfSjGlozjVS6zzl4/mJpObvqgor48CsS/VK1PZWDHl36is+LV MoKZa7HhbgJynB3BH+D/IaC+a2eAXS2ktO6vteAwo8icz/Zi3Sl3SmQXbq7N0SdjamMs hE/hkqSmQRk6DsYMqVPYFiDzTnGpMITPwRPoIqIz0mv/PLVopk7SN21+CQTWfp6SetGC BKW3rYds87BRvn6z3zbluAWKdK8iRupDiScCpRdJAws11DRcbZH0LfQsTp6sTDRqV+Z5 UB4KpVJcgym3+MOgybXI4GTGUaZw2Sd0o90B0ggVGlB+4Twg1HH/3m+0hQWInHMVMy/n vhUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=NYz4ShpcR46mr1LkihLq5JNzRQ9aq3fNKSAZGEzhCmg=; b=WP8c1EIGVyUCt4m7NoJaIUY9XTsdeYL5oA39qVft9Vnuh5rzdo45hExgR0H9vo3A3h +/qQhZMzO5rqNHKmbKnwDpdMY1qZJhmg6yeLSvuwHO4089ofAqEPUYx1UCp0Pr2bfZM4 ZI43LaOSlQBffAINgxzyiASdbhFgw+9us6TXyO9NCTxg5NywuVYNJxHxVAJ8EFe1pEQa CoQh7+gisO+eChiX/IZ92eDz+oFBhUOI53mR8XgWvGNQk0dT/J0fgWwV0XBvMr59bNoc ZWwDIk8WH6BLx99upaQJ8yB9sdnjMPguCUn9dU+/HD9Fivpg2opt7/cik/M7XQcLaNsk G8Yw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o184si1832992pgo.591.2019.01.30.09.43.49; Wed, 30 Jan 2019 09:44:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732592AbfA3RlX (ORCPT + 99 others); Wed, 30 Jan 2019 12:41:23 -0500 Received: from mx2.suse.de ([195.135.220.15]:44328 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727765AbfA3RlW (ORCPT ); Wed, 30 Jan 2019 12:41:22 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 9BBD1AF51; Wed, 30 Jan 2019 17:41:21 +0000 (UTC) Date: Wed, 30 Jan 2019 18:41:17 +0100 From: Michal Hocko To: Tejun Heo Cc: Johannes Weiner , Chris Down , Andrew Morton , Roman Gushchin , Dennis Zhou , linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, linux-mm@kvack.org, kernel-team@fb.com Subject: Re: [PATCH 2/2] mm: Consider subtrees in memory.events Message-ID: <20190130174117.GC18811@dhcp22.suse.cz> References: <20190128145210.GM18811@dhcp22.suse.cz> <20190128145407.GP50184@devbig004.ftw2.facebook.com> <20190128151859.GO18811@dhcp22.suse.cz> <20190128154150.GQ50184@devbig004.ftw2.facebook.com> <20190128170526.GQ18811@dhcp22.suse.cz> <20190128174905.GU50184@devbig004.ftw2.facebook.com> <20190129144306.GO18811@dhcp22.suse.cz> <20190129145240.GX50184@devbig004.ftw2.facebook.com> <20190130165058.GA18811@dhcp22.suse.cz> <20190130170658.GY50184@devbig004.ftw2.facebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190130170658.GY50184@devbig004.ftw2.facebook.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 30-01-19 09:06:58, Tejun Heo wrote: > Hello, Michal. > > On Wed, Jan 30, 2019 at 05:50:58PM +0100, Michal Hocko wrote: > > > Yeah, cgroup.events and .stat files as some of the local stats would > > > be useful too, so if we don't flip memory.events we'll end up with sth > > > like cgroup.events.local, memory.events.tree and memory.stats.local, > > > which is gonna be hilarious. > > > > Why cannot we simply have memory.events_tree and be done with it? Sure > > the file names are not goin to be consistent which is a minus but that > > ship has already sailed some time ago. > > Because the overall cost of shitty interface will be way higher in the > longer term. But we are discussing the file name effectively. I do not see a long term maintenance burden. Confusing? Probably yes but that is were the documentation would be helpful. -- Michal Hocko SUSE Labs