Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6263096imu; Wed, 30 Jan 2019 11:34:59 -0800 (PST) X-Google-Smtp-Source: ALg8bN6leWX/hjujuUxyjT2XgyVNl+ClmN1cjHDJSBQYyV6agARWS82QKytcXLO9zV3v9OlWqRof X-Received: by 2002:a63:1258:: with SMTP id 24mr28365657pgs.114.1548876899706; Wed, 30 Jan 2019 11:34:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548876899; cv=none; d=google.com; s=arc-20160816; b=JSwTPbbkBG6sa5PW2M9lNb02mh81XyKhhOJKrD3SvNFrBfBu8SlbJKjN4eIIyYXix0 n3Y3lYXkMMfDivVIJer0cS4neCoBouqirl8Wvw4eR4/MxKO2dpVKJTyikPcNb1X0z6/i /e2okkU9og0+68S2wOOCV3+maq+dmYdSnV+jwUypOt2zcfFqHDuHeAls7QlwYzxZFneg +vya5526GeOdHU4isDhXqlWFBrciCB3IZTYWRRhONmvsHAECC032OuXPjjY/PXqCUt7d fsvQZzfZTIv904BZyA3nsrVIzeTN6zd5PpXmSL1q5NrUsJMsV47CVHfgTarVlqrTTuTo VKEQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=Y1iPHLyy/nRFJnrWPitOwa+ted+enLjx0w132PANvQ4=; b=u6OKLhzt1NKPq339P2PT83QNYj8CUTG1KgOObf78rs4Zi39snxma/pACdjYi1qToJB OuCbEXAD4GZOtfgDWlkNnXH01xMAAeNbZihyfWplMax6RP2BlZ/HXj9Uq8fhxjzQWXiw 1TDAT3t19TGXVCFdN7PZS2GD7y2+oDStEhe1GaQCvnVfe8agZrzxASQYY42KEea3JTFV jW56ywLIHtCG7/kz5c0GdyMcOyiMrA7KjwzMNZQ6mh5IgMf86knH+HPyQEjGve/7YVjJ lHr3RqlbGHiUOU6VMl1TIJU7WW6HaX9xtwfzyx89X/YCMYrc53GqlEgiMvUfpLVXo3f+ Jj/w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cz1sufCO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r14si2091130pgk.75.2019.01.30.11.34.43; Wed, 30 Jan 2019 11:34:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cz1sufCO; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387653AbfA3Tdw (ORCPT + 99 others); Wed, 30 Jan 2019 14:33:52 -0500 Received: from mail.kernel.org ([198.145.29.99]:52488 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727114AbfA3Tdv (ORCPT ); Wed, 30 Jan 2019 14:33:51 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D6E69218A4; Wed, 30 Jan 2019 19:33:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1548876831; bh=BPlEQH+U/bnY6PnlU3AcTWtT2I3p4HH7404MougbRnw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cz1sufCOo0cnVukVf7WWGKhlH3dH+4drmdLKXF/bBrh59twqGNpwVmAZEGf4UNcnG x69OuPi708GaUqq/40s5MneEtmPeok2Ta2UBmVxx2ITQDqIY5EVU7zxFcIMfTUXfKJ yAoIY0sI6RgbHkEY2kCQNyokz9iNaGE+gX7qEc50= Date: Wed, 30 Jan 2019 20:33:48 +0100 From: Greg Kroah-Hartman To: Will Deacon Cc: Catalin Marinas , Kevin Hilman , Russell King , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Marc Zyngier , Peng Donglin Subject: Re: [PATCH 1/4] arm64: dump: no need to check return value of debugfs_create functions Message-ID: <20190130193348.GC20667@kroah.com> References: <20190122144114.9816-1-gregkh@linuxfoundation.org> <20190122144114.9816-2-gregkh@linuxfoundation.org> <20190130182102.GK18558@fuggles.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190130182102.GK18558@fuggles.cambridge.arm.com> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 30, 2019 at 06:21:02PM +0000, Will Deacon wrote: > Hi Greg, > > On Tue, Jan 22, 2019 at 03:41:11PM +0100, Greg Kroah-Hartman wrote: > > When calling debugfs functions, there is no need to ever check the > > return value. The function can work or not, but the code logic should > > never do something different based on this. > > > > Cc: Catalin Marinas > > Cc: Will Deacon > > Cc: Marc Zyngier > > Cc: Peng Donglin > > Cc: > > Signed-off-by: Greg Kroah-Hartman > > --- > > arch/arm64/include/asm/ptdump.h | 9 +++------ > > arch/arm64/mm/dump.c | 4 ++-- > > arch/arm64/mm/ptdump_debugfs.c | 7 ++----- > > 3 files changed, 7 insertions(+), 13 deletions(-) > > Are you taking this via your tree, or would you like us to queue it in > arm64? What ever is easiest for you is fine with me, I can handle it either way, just let me know. thanks, greg k-h