Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6441593imu; Wed, 30 Jan 2019 15:00:29 -0800 (PST) X-Google-Smtp-Source: ALg8bN4/fh3r83Mm3YVd+WxtFgJnr4kA+MQ+9ygcYB6JWI6WQY3XArXZAsg3Ny73jbUbP459CVUi X-Received: by 2002:a17:902:7588:: with SMTP id j8mr32752465pll.215.1548889229745; Wed, 30 Jan 2019 15:00:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548889229; cv=none; d=google.com; s=arc-20160816; b=EtchsBwPo5g9w6xH8pZUcQjRv5Bpgs9XMdT5aEvHTusYLNDfXFljnPHJy8gGyUfAOR Iy2iyMHTKIzabj4A/FadJLe6QtXtbkaPn5CXLsXJ7tGWPAYXKJJSjgUA/T0OFjyEuVXz QlkLcv7WswLgjHFC9VpAsDwKQOfSyxG6WKcC2t2IeO7Qtewh5e/72On0vA28nCMNcG4h vJKa25Q0mTnRtG0r5o2tgjkqb4RWbUSwuS4HpW1SJp0oy/MSyXeWDRejlu+2ZV0dxgNr O1wYyTyjWBrQHrarmFmQg1d79RDc/gWUeX/zI8uYx/Q+7HIkGUH7ti/pq28Snd1VqeWz e9UA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :organization:references:in-reply-to:message-id:subject:cc:to:from :date; bh=R3Zh4jI3Q1FCi4/4NtV+rtmEQNTmlPV/uio8D9gokf8=; b=qbMN7iwvBxDafU91hqfGSjgVw2+zpb65FF+rjlE/DXjDc60nGMFrgeDw6D125Zm/ZH TIZwGT23nm7gqT3e2QGkB7YZG/oH9wK8n6zz1tzBeXwGiP7hfPGCrD6xi27A+sEGur59 Atk3HcGk6nNsXn7VdYhOJuvawsmsJw59OoUfksYvtOXXSyGYcTv3/OcjiMba5DSXN8El IdUUcIMv29yZU4ySKaw99POKYq5eOVx6xw/QGXjfIjAGXDn6VRRT+RyZWjeciGDdL2qU EfnJ1KveaZ7Lu33nMLBjVLFlz+qbOHP6IxFrXZLS8nRO8xuqycCUN5AZD3irE/WFspDn po+g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v69si2385490pgd.284.2019.01.30.15.00.13; Wed, 30 Jan 2019 15:00:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732267AbfA3VGK (ORCPT + 99 others); Wed, 30 Jan 2019 16:06:10 -0500 Received: from www.llwyncelyn.cymru ([82.70.14.225]:45906 "EHLO fuzix.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727097AbfA3VGK (ORCPT ); Wed, 30 Jan 2019 16:06:10 -0500 Received: from alans-desktop (82-70-14-226.dsl.in-addr.zen.co.uk [82.70.14.226]) by fuzix.org (8.15.2/8.15.2) with ESMTP id x0UKjjEf003221; Wed, 30 Jan 2019 20:45:45 GMT Date: Wed, 30 Jan 2019 20:45:44 +0000 From: Alan Cox To: Rusty Russell Cc: Thomas Gleixner , LKML , Linus Torvalds , Greg KH , Jonathan Corbet , Jessica Yu , Alan Cox , Christoph Hellwig , Kate Stewart , Philippe Ombredanne Subject: Re: [PATCH][RFC] module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity Message-ID: <20190130204544.1b50027d@alans-desktop> In-Reply-To: <875zu620yn.fsf@rustcorp.com.au> References: <875zu620yn.fsf@rustcorp.com.au> Organization: is over-rated X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 30 Jan 2019 15:31:20 +1030 Rusty Russell wrote: > Thanks taking on such a thankless task Thomas, > > Might have been overzealous in assuming a verionless GPL string meant > "or later" (I'm happy for that for my own code, FWIW). My memory is > fuzzy, but I don't think anyone cared at the time. Versionless always meant 'or later' outside of the tags. It's the default version of the licence. (Whether v2 only has any meaning beyond intent is another debate that I guess some year a lawyer will have to figure out). I think the description change makes sense given the ambiguity and the fact we now have SPDX headers. (IANAL etc) > > 2) The dual licensed strings became ill defined as well because following > > the "GPL" vs. "GPL v2" distinction all dual licensed (or additional The dual ones were IMHO a mistake. They should just have used GPL and additional rights. Either you have GPL rights (and it's ok to use in the kernel) or you don't (and it's proprietary and the rest is down to derivative works). We don't actually care whether its dual licensed BSD, or whether it merely grants you an additional right to cheap pizza. > > As of 5.0-rc2 2873 out of 9200 instances of MODULE_LICENSE() strings are > > conflicting with the actual license in the source code (either SPDX or > > license boilerplate/reference). A comparison between the scan of the The SPDX tag isn't correctly capable of expressing the licence anyway. If you have functions in a file and two of them are GPL v2+ and someone added a GPLv2 only one and updated the header there isn't a valid SPDX tag for it because I can still use the GPLv2+ bits with GPLv3. This is nothing new - the headers on the files provided no more data on that and took up lots more space 8) We've simply never tracked licence data by line. Alan