Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6442357imu; Wed, 30 Jan 2019 15:01:09 -0800 (PST) X-Google-Smtp-Source: ALg8bN54Q/5r5RHTFbu8FdYSmErUwrdRDC2OT+QUlmA4cmefIF0rHEAarwB5mN6R0NVdWCeHP6/H X-Received: by 2002:a65:4381:: with SMTP id m1mr28773390pgp.358.1548889269344; Wed, 30 Jan 2019 15:01:09 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548889269; cv=none; d=google.com; s=arc-20160816; b=k1FTSXtIaZB6eSKhjjiW5E18AlBlErKts2XUAL/HUDIYCJxjM8VN8H4ieLbJirD10K aQWUmWD0CHJJriLVbIp0O3AsNtDhg/qQ7DgEXtH/yKfVeaxmVmdlFmRIAvDkjUEphK5q DBM/5I47EVTzFUMajmbESr+5fd2WyfuwWOTTOO8IINFFYg2g9iUnVK9iu1aieA68Th3y 9i2OJ/dr3mpuIode4jFJaWydtw/ubKEFKMAQNisWsz0PPEtqgLA3596onuKP607VZYwm KIsM+6Qk1SoCr2PcQcQKrJc5KngckhEiMLf9jRs0+1bXUqdJkl7tQRIwpMIlwWI+Gcpb FZ6Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=fxVQawqVScb2mFbuhHUtYl1KnJo9LxZ/UfUHb5zEqvU=; b=A6h6v42HosuROlB3/6rsObS1qBqDAUNiNZ7zSDYJZP8M5sbnFZOCB+k1q4QmJU3Mtl 724UxNKdYznVwJoUDIXP/ZvuuWvuQMF+aBOvSbvsxmWhhxCYmxVx6bIxIMGqVVByp7xM I/a9rLBRUk/+3IKFgCUnhQh1711jeBBKCwtekgzVCinlPSF3o9vEAOcD+iBkh80SNEae E2GYJKTxrNX0fRaTCiSoavABV2H+ojFcS3VlryMHmz35UQFigEzwGZITxZwRj3dhJPNV 2DAfmirTpxQlqb8Pu5Wzgx0QeBFPjxxsyGiRaB/+8zY3PWA6nAtBhngWiZiLqERtWO/y SUkw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q70si2405435pgq.526.2019.01.30.15.00.53; Wed, 30 Jan 2019 15:01:09 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387747AbfA3VWX (ORCPT + 99 others); Wed, 30 Jan 2019 16:22:23 -0500 Received: from mga11.intel.com ([192.55.52.93]:62410 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727528AbfA3VWW (ORCPT ); Wed, 30 Jan 2019 16:22:22 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jan 2019 13:22:15 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,542,1539673200"; d="scan'208";a="314986641" Received: from unknown (HELO localhost) ([10.249.254.216]) by fmsmga006.fm.intel.com with ESMTP; 30 Jan 2019 13:22:12 -0800 Date: Wed, 30 Jan 2019 23:22:10 +0200 From: Jarkko Sakkinen To: Jerry Snitselaar Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Peter Huewe , Jason Gunthorpe Subject: Re: [PATCH] tpm: don't print error message in tpm_transmit_cmd when tpm still testing Message-ID: <20190130212210.GA17308@linux.intel.com> References: <20190129185911.13559-1-jsnitsel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190129185911.13559-1-jsnitsel@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 29, 2019 at 11:59:11AM -0700, Jerry Snitselaar wrote: > Currently tpm_transmit_cmd will print an error message if the tpm > returns something other than TPM2_RC_SUCCESS. This means that if the > tpm returns that it is testing an error message will be printed, and > this can cause confusion for the end user. So avoid printing the error > message if TPM2_RC_TESTING is the return code. > > Cc: Peter Huewe > Cc: Jarkko Sakkinen > Cc: Jason Gunthorpe > Signed-off-by: Jerry Snitselaar Reviewed-by: Jarkko Sakkinen And applied. Thanks. /Jarkko