Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] selftests: net: fix "from" match test in
 fib_rule_tests.sh
To:     Marcelo Henrique Cerri <marcelo.cerri@canonical.com>,
        "David S. Miller" <davem@davemloft.net>,
        Shuah Khan <shuah@kernel.org>, netdev@vger.kernel.org,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20190130181903.16465-1-marcelo.cerri@canonical.com>
From:   David Ahern <dsahern@gmail.com>
Message-ID: <07230159-a2e3-31a9-6ada-d9bd24313d13@gmail.com>
Date:   Wed, 30 Jan 2019 16:19:36 -0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190130181903.16465-1-marcelo.cerri@canonical.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 1/30/19 11:19 AM, Marcelo Henrique Cerri wrote:
> Fix the IPv4 address of the dummy0 interface and ensure that ip_forward
> is enabled in the network space to get a valid response when checking
> for routes between the gateway and other hosts.

you need a Fixes tag and to cc the author of said commit.

> 
> Signed-off-by: Marcelo Henrique Cerri <marcelo.cerri@canonical.com>
> ---
>  tools/testing/selftests/net/fib_rule_tests.sh | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh
> index d4cfb6a7a086..552a9784e759 100755
> --- a/tools/testing/selftests/net/fib_rule_tests.sh
> +++ b/tools/testing/selftests/net/fib_rule_tests.sh
> @@ -54,9 +54,11 @@ setup()
>  
>  	$IP link add dummy0 type dummy
>  	$IP link set dev dummy0 up
> -	$IP address add 198.51.100.1/24 dev dummy0
> +	$IP address add 192.51.100.1/24 dev dummy0
>  	$IP -6 address add 2001:db8:1::1/64 dev dummy0
>  
> +	ip netns exec testns sysctl -w net.ipv4.ip_forward=1

ip_forward is not relevant for this test. It just adds routes and rules
and uses ip route get to verify; no traffic is actually genrated.