Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6603493imu; Wed, 30 Jan 2019 18:41:23 -0800 (PST) X-Google-Smtp-Source: ALg8bN4LhZJKT2ZbTLTUnA5nRuX//8Pi43sCEJ1ylSm0GV9asl2NKFRapEVaoKNiaaw7JzFmCgpx X-Received: by 2002:a65:55ca:: with SMTP id k10mr29526433pgs.448.1548902483813; Wed, 30 Jan 2019 18:41:23 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548902483; cv=none; d=google.com; s=arc-20160816; b=sneyJ2aPcXi0H0fJOSh9GcIk7mKpjejNQ6jOKxjVCqAC09urF/huy8b3jFIFABJy/g lIMTzalYdmrZTNW+OVXNs8J5KI/wQvsSb6NT3oojR+XmGLN7NL8Mf0xtP8rGoOYVF53B tjRKfbaLt6419hSImYfloJjTFOSoNriz3TRvikNSzuNq2FNPSRWU35K6CFcVKjoj5iHI c6dZY44X6lNa0Uu+o7u5kamg+r9cxDjv1r6XVcEK0+nWeC1B5poz/W7eovsHWdEIyph3 UEx+37d2Ga02TkoCvOYF5S29vZ6t/cehcuErGjGpczltiKXOVe/7It3sgTcVsWQhpXW4 Tm1w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:subject:cc:to :from:date:dkim-signature; bh=fLRHrHt3WUj3ATzI4mHAJG0a6a0p6rUQ79AullcSD8E=; b=wA6m8oUalrNimHN4FvrX1qxlUF+CdiUONfTErL9EIE3nHC7FXgjCARxvH+m516hqmP xIt77dCGIAAxhspdohqv+3l1VOHg80vgCkS2vfnpcwP8FgB3rN97OEMk1TxyzHOI0q1r dqhAOi1BaYVkgIbmCtsfxM1ssOeP93Uc7zqt7D+tH9o+4DnQeAH+RSqa8eArlUf3mImu QpbpsJrIZZ7TfP0BndqqJ7NZU2RaRPUjV7i16pNpNCm4ScbuIWKnuOsV2yNdMHr5Wcqq Yu/sSlvPBThGibT0tTDHxM+ZOtwyfL5NlF8v5D0XyKdozMlCtZyPkbLOiKrEOK3e8QoF mxQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=ubuKcplW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y7si3053967pgc.236.2019.01.30.18.41.06; Wed, 30 Jan 2019 18:41:23 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@canb.auug.org.au header.s=201702 header.b=ubuKcplW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729084AbfAaCkh (ORCPT + 99 others); Wed, 30 Jan 2019 21:40:37 -0500 Received: from ozlabs.org ([203.11.71.1]:44441 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725535AbfAaCkh (ORCPT ); Wed, 30 Jan 2019 21:40:37 -0500 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPSA id 43qkxG0ywZz9s4s; Thu, 31 Jan 2019 13:40:34 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=canb.auug.org.au; s=201702; t=1548902434; bh=aDtlllvo8hXnwE0n5VUk+ub3tnkcZywc5F4fD7PIbz0=; h=Date:From:To:Cc:Subject:From; b=ubuKcplWcLveFPWUO/Av5G8vUsqaHng26FPUUSUF6pZsiP2uou1KeY0vQwS8GRpXe C072AqZDMwpvwMla1qAL2nj9x0YUEzAW2m0QYbB9ftVh8OnJBPXaVqZGbV64PMKPlV ipzavTXcQurflFblJAwxwxAUQajg0NIj2w8PD34ds1N9SuDDVXQuzEwo9J/+5uagNE Ots7mchln99qQAKFmHDTb9zmPmS9Xf2zF4DwiykZgkE0Jt5oqKBjPoBEo3ndLQ6Zbc bkXAqIq2S3ObTTFswfZ0VR0MPxoNY63zpLgsPlFeT06X4hss34ajznfgKuraal6uUb vwssF50k9qE9w== Date: Thu, 31 Jan 2019 13:40:33 +1100 From: Stephen Rothwell To: "Michael S. Tsirkin" , Bjorn Helgaas Cc: Linux Next Mailing List , Linux Kernel Mailing List Subject: linux-next: manual merge of the vhost tree with the pci tree Message-ID: <20190131134033.1ed0021d@canb.auug.org.au> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; boundary="Sig_/hPh8DgZ=ib+x5tNHOt/Hbr3"; protocol="application/pgp-signature" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --Sig_/hPh8DgZ=ib+x5tNHOt/Hbr3 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi all, Today's linux-next merge of the vhost tree got a conflict in: drivers/pci/setup-bus.c between commit: 51c48b310183 ("PCI: Probe bridge window attributes once at enumeration-ti= me") from the pci tree and commit: 955156f34e7d ("PCI: avoid bridge feature re-probing on hotplug") from the vhost tree. I fixed it up (hopefully - see below) and can carry the fix as necessary. This is now fixed as far as linux-next is concerned, but any non trivial conflicts should be mentioned to your upstream maintainer when your tree is submitted for merging. You may also want to consider cooperating with the maintainer of the conflicting tree to minimise any particularly complex conflicts. --=20 Cheers, Stephen Rothwell diff --cc drivers/pci/setup-bus.c index 1941bb0a6c13,d5c25d465d97..000000000000 --- a/drivers/pci/setup-bus.c +++ b/drivers/pci/setup-bus.c @@@ -735,17 -735,50 +735,26 @@@ int pci_claim_bridge_resource(struct pc base/limit registers must be read-only and read as 0. */ static void pci_bridge_check_ranges(struct pci_bus *bus) { - u16 io; - u32 pmem; struct pci_dev *bridge =3D bus->self; - struct resource *b_res; - - b_res =3D &bridge->resource[PCI_BRIDGE_RESOURCES]; + struct resource *b_res =3D &bridge->resource[PCI_BRIDGE_RESOURCES]; =20 + /* + * Don't re-check after this was called once already: + * important since bridge might be in use. + * Note: this is only reliable because as per spec all PCI to PCI + * bridges support memory unconditionally so IORESOURCE_MEM is set. + */ + if (b_res[1].flags & IORESOURCE_MEM) + return; +=20 b_res[1].flags |=3D IORESOURCE_MEM; =20 - pci_read_config_word(bridge, PCI_IO_BASE, &io); - if (!io) { - pci_write_config_word(bridge, PCI_IO_BASE, 0xe0f0); - pci_read_config_word(bridge, PCI_IO_BASE, &io); - pci_write_config_word(bridge, PCI_IO_BASE, 0x0); - } - if (io) + if (bridge->io_window) b_res[0].flags |=3D IORESOURCE_IO; =20 - /* DECchip 21050 pass 2 errata: the bridge may miss an address - disconnect boundary by one PCI data phase. - Workaround: do not use prefetching on this device. */ - if (bridge->vendor =3D=3D PCI_VENDOR_ID_DEC && bridge->device =3D=3D 0x0= 001) - return; - - pci_read_config_dword(bridge, PCI_PREF_MEMORY_BASE, &pmem); - if (!pmem) { - pci_write_config_dword(bridge, PCI_PREF_MEMORY_BASE, - 0xffe0fff0); - pci_read_config_dword(bridge, PCI_PREF_MEMORY_BASE, &pmem); - pci_write_config_dword(bridge, PCI_PREF_MEMORY_BASE, 0x0); - } - if (pmem) { + if (bridge->pref_window) { b_res[2].flags |=3D IORESOURCE_MEM | IORESOURCE_PREFETCH; - if ((pmem & PCI_PREF_RANGE_TYPE_MASK) =3D=3D - PCI_PREF_RANGE_TYPE_64) { + if (bridge->pref_64_window) { b_res[2].flags |=3D IORESOURCE_MEM_64; b_res[2].flags |=3D PCI_PREF_RANGE_TYPE_64; } --Sig_/hPh8DgZ=ib+x5tNHOt/Hbr3 Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAlxSYCEACgkQAVBC80lX 0Gxfqgf+I4oKR99AHQbwwfWlsMekEB9AT2rUtkCXzTwQRqQLwPsyCQl9CsdZ69Tw +hIt8/qR6i35noLRv+sKUDi2Zaw5ybntXmqDwDiz29xtVfHvCOPeRGHLjy7ad/2X bpvGD9KSCidEth3fELtGZMTtSwW5xVwPPCTGFnMrYpkFzjDa6ApJreb9ZVKPKJik 5FRT1iHPN5uC45X0UJEDuYVoDjLOEUxvSHqwemUAl85odYwf5bymoLIRyhOlG8sZ BBEEWJEO/mUxH53AL9PCLPx6Lk+M3XynVBjQX44pheoT+rLtiM2GWqCXz7UUSK1Z 0AZdiLV8aAoDaa9x8W6VwuLDipd0vg== =Bqf0 -----END PGP SIGNATURE----- --Sig_/hPh8DgZ=ib+x5tNHOt/Hbr3--