Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190109021112.5836-1-rkir@google.com> <20190109021112.5836-2-rkir@google.com>
 <20190122110712.GA1004@kroah.com> <CAOGAQeo1Kv55EUn2sYPOt9EgBMfN=+o_A4KOPVgqbJHo+HN-Sw@mail.gmail.com>
 <20190130144414.GA8357@kroah.com>
In-Reply-To: <20190130144414.GA8357@kroah.com>
From:   Roman Kiryanov <rkir@google.com>
Date:   Wed, 30 Jan 2019 19:56:14 -0800
Message-ID: <CAOGAQeo6zr=FYFPHt3NUajdStWyQe3oPZYNEn+o2GxXwXWd14g@mail.gmail.com>
Subject: Re: [PATCH v3 2/3] drivers: platform: goldfish: goldfish_address_space:
 add a driver
To:     Greg KH <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, Lingfeng Yang <lfy@google.com>,
        Alistair Strachan <astrachan@google.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> Also, why does the other Android "emulator", cuttlefish, not need
> special drivers like this and the other goldfish drivers?  Shouldn't you
> be using the same interfaces that they use that are already merged
> upstream?
> Actually, now that cuttlefish works on a mainline kernel, can't we just
> delete the existing goldfish code?

cuttlefish is a separate emulator with different assumptions which do
not work for us.

Our emulator runs on Linux, Mac and Windows, it uses host's GPU
directly for rendering.

I am not sure how cuttlefish accesses host's GPU memory (it might not
support this),
but we need it to support coherent memory access for Vulcan. We also
might use it to access
host's camera pixels to avoid copying them.

Please keep goldfish drivers.