Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Aisheng Dong <aisheng.dong@nxp.com>
To:     Daniel Baluta <daniel.baluta@nxp.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>
CC:     "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        dl-linux-imx <linux-imx@nxp.com>,
        "daniel.baluta@gmail.com" <daniel.baluta@gmail.com>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "S.j. Wang" <shengjiu.wang@nxp.com>
Subject: RE: [PATCH v3] firmware: imx: Add support to start/stop a CPU
Thread-Topic: [PATCH v3] firmware: imx: Add support to start/stop a CPU
Thread-Index: AQHUuJ/zljwGGsgqVEqW1pCa+zHOeKXJCQ5g
Date:   Thu, 31 Jan 2019 08:16:53 +0000
Message-ID: <AM0PR04MB4211CBB9D46FC6EDB9DA9F1680910@AM0PR04MB4211.eurprd04.prod.outlook.com>
References: <20190130133005.5732-1-daniel.baluta@nxp.com>
In-Reply-To: <20190130133005.5732-1-daniel.baluta@nxp.com>
Accept-Language: zh-CN, en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 61595ce5-f9ee-4132-571b-08d68754759d
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2019 08:16:53.8421
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR04MB4436
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Daniel Baluta
> Sent: Wednesday, January 30, 2019 9:30 PM
> To: shawnguo@kernel.org
> Cc: s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com;
> dl-linux-imx <linux-imx@nxp.com>; daniel.baluta@gmail.com; Aisheng Dong
> <aisheng.dong@nxp.com>; linux-arm-kernel@lists.infradead.org;
> linux-kernel@vger.kernel.org; S.j. Wang <shengjiu.wang@nxp.com>; Daniel
> Baluta <daniel.baluta@nxp.com>
> Subject: [PATCH v3] firmware: imx: Add support to start/stop a CPU
>=20
> This is done via RPC call to SCU.
>=20
> Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>

Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>

Regards
Dong Aisheng

> ---
> Changes since v2: (as per Aisheng's review)
> 	- rename address with phys_address
> 	- remove unnecessary uint8_t cast
> 	- use 'true' as last parameter of imx_scu_call_rpc to actually
> 	wait for a response from SCU.
>=20
>  drivers/firmware/imx/misc.c           | 38
> +++++++++++++++++++++++++++
>  include/linux/firmware/imx/svc/misc.h |  3 +++
>  2 files changed, 41 insertions(+)
>=20
> diff --git a/drivers/firmware/imx/misc.c b/drivers/firmware/imx/misc.c in=
dex
> 97f5424dbac9..4b56a587dacd 100644
> --- a/drivers/firmware/imx/misc.c
> +++ b/drivers/firmware/imx/misc.c
> @@ -18,6 +18,14 @@ struct imx_sc_msg_req_misc_set_ctrl {
>  	u16 resource;
>  } __packed;
>=20
> +struct imx_sc_msg_req_cpu_start {
> +	struct imx_sc_rpc_msg hdr;
> +	u32 address_hi;
> +	u32 address_lo;
> +	u16 resource;
> +	u8 enable;
> +} __packed;
> +
>  struct imx_sc_msg_req_misc_get_ctrl {
>  	struct imx_sc_rpc_msg hdr;
>  	u32 ctrl;
> @@ -97,3 +105,33 @@ int imx_sc_misc_get_control(struct imx_sc_ipc *ipc,
> u32 resource,
>  	return 0;
>  }
>  EXPORT_SYMBOL(imx_sc_misc_get_control);
> +
> +/*
> + * This function starts/stops a CPU identified by @resource
> + *
> + * @param[in]     ipc         IPC handle
> + * @param[in]     resource    resource the control is associated with
> + * @param[in]     enable      true for start, false for stop
> + * @param[in]     phys_addr   initial instruction address to be executed
> + *
> + * @return Returns 0 for success and < 0 for errors.
> + */
> +int imx_sc_pm_cpu_start(struct imx_sc_ipc *ipc, u32 resource,
> +			bool enable, u64 phys_addr)
> +{
> +	struct imx_sc_msg_req_cpu_start msg;
> +	struct imx_sc_rpc_msg *hdr =3D &msg.hdr;
> +
> +	hdr->ver =3D IMX_SC_RPC_VERSION;
> +	hdr->svc =3D IMX_SC_RPC_SVC_PM;
> +	hdr->func =3D IMX_SC_PM_FUNC_CPU_START;
> +	hdr->size =3D 4;
> +
> +	msg.address_hi =3D phys_addr >> 32;
> +	msg.address_lo =3D phys_addr;
> +	msg.resource =3D resource;
> +	msg.enable =3D enable;
> +
> +	return imx_scu_call_rpc(ipc, &msg, true); }
> +EXPORT_SYMBOL(imx_sc_pm_cpu_start);
> diff --git a/include/linux/firmware/imx/svc/misc.h
> b/include/linux/firmware/imx/svc/misc.h
> index e21c49aba92f..031dd4d3c766 100644
> --- a/include/linux/firmware/imx/svc/misc.h
> +++ b/include/linux/firmware/imx/svc/misc.h
> @@ -52,4 +52,7 @@ int imx_sc_misc_set_control(struct imx_sc_ipc *ipc, u32
> resource,  int imx_sc_misc_get_control(struct imx_sc_ipc *ipc, u32 resour=
ce,
>  			    u8 ctrl, u32 *val);
>=20
> +int imx_sc_pm_cpu_start(struct imx_sc_ipc *ipc, u32 resource,
> +			bool enable, u64 phys_addr);
> +
>  #endif /* _SC_MISC_API_H */
> --
> 2.17.1