Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6876962imu; Thu, 31 Jan 2019 00:54:55 -0800 (PST) X-Google-Smtp-Source: ALg8bN4R4OEWTuE2kX7nTGK/qB3vSyWyT6NpYJctyaJ1aDZ5AWKEcq+8JQR9pIDLA2C06KTGWapJ X-Received: by 2002:a17:902:7e44:: with SMTP id a4mr33979537pln.338.1548924895794; Thu, 31 Jan 2019 00:54:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548924895; cv=none; d=google.com; s=arc-20160816; b=AUQQFYcf8bQ0mR8wzcalqPgZsY39avULQbPXnIi5CXcz8fvsFGPN1uoCgU/pMKyjq6 Ij9z/U0FW6V96tsfGz7cbxrj+dNWNC+jFR8KwjcUI4IO+9ZC8rEl5KU/Rn1w3PCrLiEF wIk8PilaWwetMxCRo+M3NX3up14iKozUIjTOOspKeeGeF16nExyxW6DXeqz7vW3zvIua Oi/BTA+b6kXnUhzTi+AYIAUL05K4Pvqz5mtLjtmHQhQH65pzYdxTdGYoxLEcOiNw5+NM BxvZ1MYK1e6UwFMXFfLRUubCiGEu9dpQp0vGTtdvjwfwn90L3m3s9F91+6OiaSYB86R0 Wf1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:references:in-reply-to:date :subject:cc:to:from; bh=CgOuOKuvdZXE+niFSzD3lkHbV7OuoUyVv+OlDL3rmW0=; b=rzHiWl68fi7Wbw5wFFpH93eR+lCGlvPVz9agxZ1OPxXUi+ep9CQVYQCt5QwIi2WnNr TWT2Afwjr6xp4cIp6VY2gqrkKwNCVjCsowDqbUYN0xRDRoa5LgiXqCx0c8hCc+o/wsVM 2wnVXRnAWWo94v0t5wDZ/8t9gBd2m+ttnrPUJurR3Rv6S3MZO42fPCo1fZomIKq6MC9/ tTBgdyjGC2SV+Ss1812jUTiRmbfn+PsEd+jV0Fe6jQDN1DqaL5VEldamPzjJ//A9Arbj efCgadykQQ6IRzwTmkjv2dkgrN0+YNwa+shM1vc3g5T/+afTXXkFsjUmgcojdikFi3wv +U2Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3si3962274plo.102.2019.01.31.00.54.40; Thu, 31 Jan 2019 00:54:55 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730821AbfAaIx0 (ORCPT + 99 others); Thu, 31 Jan 2019 03:53:26 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:42536 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730274AbfAaIxY (ORCPT ); Thu, 31 Jan 2019 03:53:24 -0500 Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x0V8hq1v122962 for ; Thu, 31 Jan 2019 03:53:23 -0500 Received: from e06smtp05.uk.ibm.com (e06smtp05.uk.ibm.com [195.75.94.101]) by mx0a-001b2d01.pphosted.com with ESMTP id 2qbwr50cgy-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Thu, 31 Jan 2019 03:53:22 -0500 Received: from localhost by e06smtp05.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Thu, 31 Jan 2019 08:53:20 -0000 Received: from b06cxnps4074.portsmouth.uk.ibm.com (9.149.109.196) by e06smtp05.uk.ibm.com (192.168.101.135) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Thu, 31 Jan 2019 08:53:18 -0000 Received: from d06av24.portsmouth.uk.ibm.com (d06av24.portsmouth.uk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x0V8rGGn57737444 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 31 Jan 2019 08:53:16 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3613142042; Thu, 31 Jan 2019 08:53:16 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C725B42041; Thu, 31 Jan 2019 08:53:15 +0000 (GMT) Received: from s38lp84.lnxne.boe (unknown [9.152.108.100]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTP; Thu, 31 Jan 2019 08:53:15 +0000 (GMT) From: Michael Mueller To: KVM Mailing List Cc: Linux-S390 Mailing List , linux-kernel@vger.kernel.org, Martin Schwidefsky , Heiko Carstens , Christian Borntraeger , Janosch Frank , David Hildenbrand , Cornelia Huck , Halil Pasic , Pierre Morel , Michael Mueller Subject: [PATCH v7 04/15] KVM: s390: coding style kvm_s390_gisa_init/clear() Date: Thu, 31 Jan 2019 09:52:35 +0100 X-Mailer: git-send-email 2.13.4 In-Reply-To: <20190131085247.13826-1-mimu@linux.ibm.com> References: <20190131085247.13826-1-mimu@linux.ibm.com> X-TM-AS-GCONF: 00 x-cbid: 19013108-0020-0000-0000-0000030F360C X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19013108-0021-0000-0000-0000216037F3 Message-Id: <20190131085247.13826-5-mimu@linux.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-31_04:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=903 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1901310070 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The change helps to reduce line length and increases code readability. Signed-off-by: Michael Mueller Reviewed-by: Cornelia Huck Reviewed-by: Pierre Morel Reviewed-by: Halil Pasic --- arch/s390/kvm/interrupt.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/arch/s390/kvm/interrupt.c b/arch/s390/kvm/interrupt.c index 2a3eb9f076c3..005dbe7252e7 100644 --- a/arch/s390/kvm/interrupt.c +++ b/arch/s390/kvm/interrupt.c @@ -2885,20 +2885,20 @@ int kvm_s390_get_irq_state(struct kvm_vcpu *vcpu, __u8 __user *buf, int len) void kvm_s390_gisa_clear(struct kvm *kvm) { - if (kvm->arch.gisa) { - memset(kvm->arch.gisa, 0, sizeof(struct kvm_s390_gisa)); - kvm->arch.gisa->next_alert = (u32)(u64)kvm->arch.gisa; - VM_EVENT(kvm, 3, "gisa 0x%pK cleared", kvm->arch.gisa); - } + if (!kvm->arch.gisa) + return; + memset(kvm->arch.gisa, 0, sizeof(struct kvm_s390_gisa)); + kvm->arch.gisa->next_alert = (u32)(u64)kvm->arch.gisa; + VM_EVENT(kvm, 3, "gisa 0x%pK cleared", kvm->arch.gisa); } void kvm_s390_gisa_init(struct kvm *kvm) { - if (css_general_characteristics.aiv) { - kvm->arch.gisa = &kvm->arch.sie_page2->gisa; - VM_EVENT(kvm, 3, "gisa 0x%pK initialized", kvm->arch.gisa); - kvm_s390_gisa_clear(kvm); - } + if (!css_general_characteristics.aiv) + return; + kvm->arch.gisa = &kvm->arch.sie_page2->gisa; + kvm_s390_gisa_clear(kvm); + VM_EVENT(kvm, 3, "gisa 0x%pK initialized", kvm->arch.gisa); } void kvm_s390_gisa_destroy(struct kvm *kvm) -- 2.13.4