Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6883340imu;
        Thu, 31 Jan 2019 01:02:43 -0800 (PST)
X-Google-Smtp-Source: ALg8bN5y2VsAToaUPAbLep67aMj6DzrDZlItJclBV6zJIhbU0awLblnAA5WMdabjMxOG30ZdsFKR
X-Received: by 2002:a63:94:: with SMTP id 142mr30033094pga.74.1548925363622;
        Thu, 31 Jan 2019 01:02:43 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1548925363; cv=none;
        d=google.com; s=arc-20160816;
        b=GSzSMxVl5EguBL42Y98yEFZ+wgMSfxmGT9i58LMYcepoZ/rmbiGJzhwCl3qLeJXgnS
         uqkbxkdzJ3k4H3tUT3dKGU/7yccCRKh3uBFd/gP7N4+zhMPYEM3VhQKpkU0si/d5+PnQ
         nBnzOpMRsqYmzb2sDKmbLWN+MuiLFzN9JTUpdPaVy7cwrmHFxYKFgnw9Dsyg2q174hjS
         lF8JaVtd33zEvoMCJkHB9nJCVjjeLN0AG/RiU4g+kivFPFQzg9Ntk2ASBbm8Qs+UaHN1
         aBOTC5JQH6CqUQ/KVczikwpuqg/0LJ+lAKM3lunOmFjQctRaGKFg46ihxhaWdVqDDGx0
         1WqQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date;
        bh=HtN3DGYlflCHFOl7WE+ocafJmSJEbCEg17DDUDX5mfk=;
        b=YivR/8HZLtp0+8AvBxN49PchJa+ZybZZrLmtlAB0X2lq6JRKwK7gidWfWMLRZWtUaK
         eFCXVzvSGRqfyFCA8YhwfSVkX3TWiG9Id7uAOV3bVe/tWeJRIPdO3Wrlh3JTkdU+mmZd
         dSDk1VTEMpVX4h+oiOQ4KNt14K4YzdzmqHx12O1JsoZsiVnXYNi6XzOe5x+KpMF0iJxT
         h8DvMdJHWvWGkmA5vbeK3zNnKuIafl3uYd9cxGuA9g4DFiMQgGM1MbEaJN4vIU2ccjiz
         z/nUOf7NqtfNNCHSczsJ1tQqsr0jtS9hAy7UCUkldGDfN49AwZ1boXN6tXRAup9ILZvR
         QtWQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=Qg2fhbC+;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id 14si3823078pgg.425.2019.01.31.01.02.27;
        Thu, 31 Jan 2019 01:02:43 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=Qg2fhbC+;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728313AbfAaJBX (ORCPT <rfc822;0330sisy@gmail.com> + 99 others);
        Thu, 31 Jan 2019 04:01:23 -0500
Received: from hqemgate14.nvidia.com ([216.228.121.143]:3328 "EHLO
        hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1725787AbfAaJBW (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 31 Jan 2019 04:01:22 -0500
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5c52b95f0000>; Thu, 31 Jan 2019 01:01:19 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Thu, 31 Jan 2019 01:01:17 -0800
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Thu, 31 Jan 2019 01:01:17 -0800
Received: from tbergstrom-lnx.Nvidia.com (172.20.13.39) by
 HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id
 15.0.1395.4; Thu, 31 Jan 2019 09:01:16 +0000
Received: by tbergstrom-lnx.Nvidia.com (Postfix, from userid 1000)
        id 69C964197C; Thu, 31 Jan 2019 11:01:14 +0200 (EET)
Date:   Thu, 31 Jan 2019 11:01:14 +0200
From:   Peter De Schrijver <pdeschrijver@nvidia.com>
To:     Joseph Lo <josephl@nvidia.com>
CC:     Thierry Reding <thierry.reding@gmail.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        <linux-kernel@vger.kernel.org>,
        Jonathan Hunter <jonathanh@nvidia.com>,
        <linux-tegra@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH V2 2/6] clocksource: tegra: add Tegra210 timer driver
Message-ID: <20190131090114.GZ7714@pdeschrijver-desktop.Nvidia.com>
References: <20190128091815.7040-1-josephl@nvidia.com>
 <20190128091815.7040-3-josephl@nvidia.com>
 <20190128150908.GB31317@ulmo>
 <20190129084155.GX7714@pdeschrijver-desktop.Nvidia.com>
 <20190129102912.GC28850@ulmo>
 <8d5b6a61-8fb8-2f83-5378-9b1a1e5bd03d@nvidia.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <8d5b6a61-8fb8-2f83-5378-9b1a1e5bd03d@nvidia.com>
X-NVConfidentiality: public
User-Agent: Mutt/1.9.4 (2018-02-28)
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL106.nvidia.com (172.18.146.12) To
 HQMAIL101.nvidia.com (172.20.187.10)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1548925279; bh=HtN3DGYlflCHFOl7WE+ocafJmSJEbCEg17DDUDX5mfk=;
        h=X-PGP-Universal:Date:From:To:CC:Subject:Message-ID:References:
         MIME-Version:Content-Type:Content-Disposition:In-Reply-To:
         X-NVConfidentiality:User-Agent:X-Originating-IP:X-ClientProxiedBy;
        b=Qg2fhbC+Mxg+ehN8AJkZnN9hCefruXjO0WHnO0jviodQtdqPZKqFE1CLiH2thRhMs
         0EzsjhDsUk6HqO1yAqvZy5arNVBqrTzLw9xA7SwwCer/E6oOj2fWqZmTpQffTuZxHa
         LvDX4nQuqgZwb8AQPVJAuj44D32Fr6yHhYfOk2GQk5JdC5bUJSG//3BhA2qFnPgs6c
         jWKhDdI4C0uVkjGrcGAjbsGcyTdTfMxw5bQHHollfpbrIA/AHkB1ZAjhNdqxUoXqNZ
         n9ix2sJ0cx9tAPIXv2gWDXJL+j+Zk6rpiiV4kRKy6hEVz5dwM13c+lYKU7xUSo8qBQ
         tKnN9x0Ry9vWw==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Jan 30, 2019 at 10:40:06AM +0800, Joseph Lo wrote:
> On 1/29/19 6:29 PM, Thierry Reding wrote:
> > On Tue, Jan 29, 2019 at 10:41:55AM +0200, Peter De Schrijver wrote:
> > > On Mon, Jan 28, 2019 at 04:09:08PM +0100, Thierry Reding wrote:
> > > 
> > > ...
> > > 
> > > > 
> > > > Up to here this is a duplicate of timer-tegra20.c. And a lot of
> > > > tegra210_timer_init() is the same as tegra20_timer_init() as well. Can't
> > > > we unify the two drivers instead?
> > > > 
> > > > The power cycle restrictions of the architected timer, do they not apply
> > > > to chips earlier than Tegra210 either? So don't we need all of these
> > > > additional features on the timer-tegra20.c driver as well? If so that
> > > 
> > > No. Chips prior to Tegra114 do not have an arch timer and the arch timer
> > > does work correctly on Cortex-A15 so Tegra114 and Tegra124 can use it.
> > > It's broken on Cortex-A57 though, so we can't use it as a wakeup source
> > > on Tegra210.
> > 
> > If chips prior to Tegra114 don't have an architected timer, then we
> > can't remove the timer-tegra20 driver, because we still need it on
> > Tegra20 and Tegra30, right?
> > 
> 
> For Tegra20/30, it's Cortext-A9 with TWD timer. (arch/arm/kernel/smp_twd.c)
> 
> Originally, I thought the functionality of timer-tegra20 would be fully
> replaced by TWD timer driver. But from the log in the kernelci test
> farm[1][2], it looks to me the timer-tegra20 driver still works as
> clocksource driver for Tegra20/30. I cannot confirm if the clock event
> device has been replaced by TWD timer in the log. It could be replaced in
> the background. And by looking into the driver, it should be.

The TWD timer runs from the CPU clock so its frequency changes with
CPU DVFS. That makes it difficult to use.

Peter.