Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp6912187imu; Thu, 31 Jan 2019 01:37:25 -0800 (PST) X-Google-Smtp-Source: ALg8bN6aj1BjvED1AvZ9JrPznFn+NlJf1nlj524qcwtV6VJaiE4F8c3uwZ9bhkNcjcaLmHKl6eCq X-Received: by 2002:a63:f844:: with SMTP id v4mr30533965pgj.82.1548927445095; Thu, 31 Jan 2019 01:37:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548927445; cv=none; d=google.com; s=arc-20160816; b=X3AHLP44tg57Vu3cmL06pax0mvB3YjspRvcUcxOSrMty3ZreG/XrQkQw+8KDZ4Xt3l 3ldpYsvuYCh6+WMrEOfmUwb1Ef+kyQUxIsxPjwNhSCtvWhjiADVQFUVhtwchawT2uyT+ Cr05mJi9SXbF/+8rOKYZASR8FHxWW8MAAxKEopdw1l113uxFwM0ncmG5Caw/bjoaneA0 rSmgvY50pi+CWpkX7P4E88nQaTJtiwUgdCqIqyIIANJyzVrluLzQZ9UGlVjbFWyIltyd uAO9fCuOWs6rMz2rwPFuYClmuEkM1Hkifw9h4rtGTal+P99+CGSPVLbXgQlgr4a2QFWb 4mSQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:dkim-signature:content-language :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=t7hU4BWbYrxt3i82S5lPVdAwUdq6EHwYAWrFk+zk1Kw=; b=fuGOpUeqOjwD0b0HCLVcZZjSnFoRcSxzHsY2T88+iZnG3ux3352jibI6vkhTBeytBz oWYL96N3kB8RK+NCqRln1us6dHsCbcoflxUmzUsYW4dVK8g/WFU74MJrM7wG80bDaFqn yLgoLA53aAOnsFrkXdUFOiIe3bhVBhkZENzpGjOs0BoZWmvWtmMVJ9p/JTLUbXRJ5Srl PT59VrCO7l3QLYOATjjHbPADdd7G34YYWa5az2ZmVN12bwI/9SxBQjKAEqhoUNtVpbGy Ha2VA6JgLxNmlDDyXg/HAekSvYTDk/JDxsL6nIv8xdI7BmdXxs5eWVwb93XGgjGi6POR GAkA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=qwOOtGLF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l24si3468641pgj.171.2019.01.31.01.37.09; Thu, 31 Jan 2019 01:37:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=qwOOtGLF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730742AbfAaJgz (ORCPT + 99 others); Thu, 31 Jan 2019 04:36:55 -0500 Received: from hqemgate14.nvidia.com ([216.228.121.143]:5490 "EHLO hqemgate14.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727523AbfAaJgy (ORCPT ); Thu, 31 Jan 2019 04:36:54 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate14.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Thu, 31 Jan 2019 01:36:54 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Thu, 31 Jan 2019 01:36:52 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Thu, 31 Jan 2019 01:36:52 -0800 Received: from [10.24.44.212] (10.124.1.5) by HQMAIL101.nvidia.com (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 31 Jan 2019 09:36:48 +0000 Subject: Re: [PATCH v2] ALSA: hda/tegra: enable clock during probe To: Takashi Iwai , Jon Hunter CC: , , , , , , , , References: <1548414418-5785-1-git-send-email-spujar@nvidia.com>

From: Sameer Pujar Message-ID: <1a248adf-2239-b6bd-1f17-270e6e579b72@nvidia.com> Date: Thu, 31 Jan 2019 15:06:43 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL104.nvidia.com (172.18.146.11) To HQMAIL101.nvidia.com (172.20.187.10) Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1548927414; bh=t7hU4BWbYrxt3i82S5lPVdAwUdq6EHwYAWrFk+zk1Kw=; h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date: User-Agent:MIME-Version:In-Reply-To:X-Originating-IP: X-ClientProxiedBy:Content-Type:Content-Transfer-Encoding: Content-Language; b=qwOOtGLFGjIehM4Mowy0Otf3YwiEl3FwuXFONguulCEa6G1gDeOKhki0WKoQHyXZ6 Up0UYby/fDtBh6Jf9lsElikw23mnL3OZbSoAVGFZ33vVdQpCK9gZ/GFJcPfNuGk1mB b4oqiYLRQGx3oK6neM0u7NSBLjzuwTLdsM9RRfIW64cXH+opq0daJnCyCwaBYrV3ed oZ0cr80d1iDLqIooX+DDxpugz4y9YkfdN6XP6n320zn2WGmA5thVsWjclutfje9ewo jmOUJK0eFhcJO9uBeblma/tsZpo6PS3pFISJ0oHdjp64tCN2z6ShaRpHKpTKHD97Ep CF4B4aPICnRIw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/30/2019 10:10 PM, Takashi Iwai wrote: > On Wed, 30 Jan 2019 13:45:49 +0100, > Jon Hunter wrote: >> >> On 25/01/2019 11:06, Sameer Pujar wrote: >>> If CONFIG_PM is disabled or runtime PM calls are forbidden, the clocks >>> will not be ON. This could cause issue during probe, where hda init >>> setup is done. This patch enables clocks unconditionally during probe. >>> >>> Along with above, follwoing changes are done. >>> * enable runtime PM before exiting from probe work. This helps to avoid >>> usage of pm_runtime_get_sync/pm_runtime_put() in probe work. >>> * hda_tegra_disable_clocks() is moved out of CONFIG_PM_SLEEP check. >>> * runtime PM callbacks moved out of CONFIG_PM check >>> >>> Signed-off-by: Sameer Pujar >>> Reviewed-by: Ravindra Lokhande >>> Reviewed-by: Jon Hunter >>> --- >>> sound/pci/hda/hda_tegra.c | 26 +++++++++++++++++--------- >>> 1 file changed, 17 insertions(+), 9 deletions(-) >>> >>> diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c >>> index c8d18dc..ba6175f 100644 >>> --- a/sound/pci/hda/hda_tegra.c >>> +++ b/sound/pci/hda/hda_tegra.c >>> @@ -219,7 +219,6 @@ static int hda_tegra_enable_clocks(struct hda_tegra *data) >>> return rc; >>> } >>> >>> -#ifdef CONFIG_PM_SLEEP >>> static void hda_tegra_disable_clocks(struct hda_tegra *data) >>> { >>> clk_disable_unprepare(data->hda2hdmi_clk); >>> @@ -227,6 +226,7 @@ static void hda_tegra_disable_clocks(struct hda_tegra *data) >>> clk_disable_unprepare(data->hda_clk); >>> } >>> >>> +#ifdef CONFIG_PM_SLEEP >>> /* >>> * power management >>> */ >>> @@ -257,7 +257,6 @@ static int hda_tegra_resume(struct device *dev) >>> } >>> #endif /* CONFIG_PM_SLEEP */ >>> >>> -#ifdef CONFIG_PM >>> static int hda_tegra_runtime_suspend(struct device *dev) >>> { >>> struct snd_card *card = dev_get_drvdata(dev); >>> @@ -283,7 +282,7 @@ static int hda_tegra_runtime_resume(struct device *dev) >>> int rc; >>> >>> rc = hda_tegra_enable_clocks(hda); >>> - if (rc != 0) >>> + if (rc) >>> return rc; >>> if (chip && chip->running) { >>> hda_tegra_init(hda); >>> @@ -292,7 +291,6 @@ static int hda_tegra_runtime_resume(struct device *dev) >>> >>> return 0; >>> } >>> -#endif /* CONFIG_PM */ >>> >>> static const struct dev_pm_ops hda_tegra_pm = { >>> SET_SYSTEM_SLEEP_PM_OPS(hda_tegra_suspend, hda_tegra_resume) >>> @@ -551,9 +549,9 @@ static int hda_tegra_probe(struct platform_device *pdev) >>> >>> dev_set_drvdata(&pdev->dev, card); >>> >>> - pm_runtime_enable(hda->dev); >>> - if (!azx_has_pm_runtime(chip)) >>> - pm_runtime_forbid(hda->dev); >>> + err = hda_tegra_enable_clocks(hda); >>> + if (err) >>> + goto out_free; >> We also need to think about power-domains here. Enabling the clocks >> might not be enough as the appropriate power-domain needs to be enabled. >> For 64-bit Tegra runtime-pm will handle the power-domains (assuming they >> are populated in device-tree). So I still think it is better we call >> pm_runtime_get_sync() at some point rather than just replying on >> enabling the clocks. > If I understand correctly the code, the pm domain is already activated > at calling driver's probe callback. If there are no further concerns, can we consider this for approval? Thanks, Sameer. > > thanks, > > Takashi