Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 31 Jan 2019 15:35:37 +0200
From:   Heikki Krogerus <heikki.krogerus@linux.intel.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Chen Yu <chenyu56@huawei.com>, Jun Li <jun.li@nxp.com>,
        Hans de Goede <hdegoede@redhat.com>,
        USB <linux-usb@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 7/9] usb: typec: Find the ports by also matching
 against the device node
Message-ID: <20190131133537.GA13072@kuha.fi.intel.com>
References: <20190130160259.46919-1-heikki.krogerus@linux.intel.com>
 <20190130160259.46919-8-heikki.krogerus@linux.intel.com>
 <CAHp75Vdq+T4vKsihhUJjV85-mkWfY2G=npJLPaGiGjbzD_m32w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75Vdq+T4vKsihhUJjV85-mkWfY2G=npJLPaGiGjbzD_m32w@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 30, 2019 at 06:51:56PM +0200, Andy Shevchenko wrote:
> On Wed, Jan 30, 2019 at 6:03 PM Heikki Krogerus
> <heikki.krogerus@linux.intel.com> wrote:
> >
> > When the connections are defined in firmware, struct
> > device_connection will have the fwnode member pointing to
> > the device node (struct fwnode_handle) of the requested
> > device, and the endpoint will not be used at all in that
> > case.
> 
> > +       /*
> > +        * FIXME: Check does the fwnode supports the requested SVID. If it does
> > +        * we need to return ERR_PTR(-PROBE_DEFER) when there is no device.
> > +        */
> > +       if (con->fwnode)
> > +               return class_find_device(typec_class, NULL, con->fwnode,
> > +                                        typec_port_fwnode_match);
> > +
> > +       dev = class_find_device(typec_class, NULL, con->endpoint[ep],
> > +                               typec_port_name_match);
> > +
> > +       return dev ? dev : ERR_PTR(-EPROBE_DEFER);
> 
> Just  to be clear, this one takes a reference on dev. Is it taken into account?

Yes. That is what we want it to do.

thanks,

-- 
heikki