Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Chris Mason <clm@fb.com>
To:     Dave Chinner <david@fromorbit.com>
CC:     "linux-mm@kvack.org" <linux-mm@kvack.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
        "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
        Roman Gushchin <guro@fb.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "mhocko@kernel.org" <mhocko@kernel.org>,
        "vdavydov.dev@gmail.com" <vdavydov.dev@gmail.com>
Subject: Re: [PATCH 1/2] Revert "mm: don't reclaim inodes with many attached
 pages"
Thread-Topic: [PATCH 1/2] Revert "mm: don't reclaim inodes with many attached
 pages"
Thread-Index: AQHUuFK1zOCFq26G8UWPT6kjO3PxRaXHu+OAgADdj4CAAO6hAA==
Date:   Thu, 31 Jan 2019 15:48:11 +0000
Message-ID: <E8895615-9DDA-4FC5-A3AB-1BE593138A89@fb.com>
References: <20190130041707.27750-1-david@fromorbit.com>
 <20190130041707.27750-2-david@fromorbit.com>
 <25EAF93D-BC63-4409-AF21-F45B2DDF5D66@fb.com> <20190131013403.GI4205@dastard>
In-Reply-To: <20190131013403.GI4205@dastard>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-originating-ip: [2620:10d:c091:180::1:9acc]
x-ms-publictraffictype: Email
x-microsoft-exchange-diagnostics: 1;DM5PR15MB1209;20:+FzV+hhrDmQEdxoitFZHMT1PWZE7vg7QVpjtg3fRRI++YbjJrFPkeiv1km3ZE8ZjHz4/t9we3eW7BEFd9clrMLWIlisFjIRaFAmscQ+UxPcOymw+6oFx7LLtoWXKkCRC+Zz8xqjTb4/kjZFVHc7Fnii2sSOhLT45BtwvJ31mR2Y=
x-ms-office365-filtering-correlation-id: 7bc2a95f-4cab-4b25-b16f-08d687938109
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600110)(711020)(4605077)(2017052603328)(7153060)(7193020);SRVR:DM5PR15MB1209;
x-ms-traffictypediagnostic: DM5PR15MB1209:
x-microsoft-antispam-prvs: <DM5PR15MB12094FA8A2731E99F8DE2E90D3910@DM5PR15MB1209.namprd15.prod.outlook.com>
x-forefront-prvs: 09347618C4
x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(376002)(396003)(346002)(136003)(366004)(39860400002)(199004)(51444003)(189003)(478600001)(76176011)(82746002)(6486002)(7736002)(386003)(6506007)(53546011)(6116002)(52116002)(102836004)(6306002)(53936002)(186003)(305945005)(33656002)(316002)(14454004)(6512007)(6436002)(966005)(50226002)(93886005)(99286004)(54906003)(106356001)(11346002)(71190400001)(83716004)(71200400001)(2616005)(97736004)(105586002)(476003)(486006)(4326008)(81166006)(446003)(8676002)(39060400002)(68736007)(6916009)(2906002)(36756003)(86362001)(25786009)(256004)(6246003)(8936002)(229853002)(81156014)(46003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM5PR15MB1209;H:DM5PR15MB1883.namprd15.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: fb.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: 9SmKB3ybe3AJs41yp/NbPRUtthMoM3CtIIzj9St+4hN+bwL610v10VwXgcAc7T+kAaVWM8shjbUPh7pOLd1llEIsulbs7WP0DNDUHCPu/O4TlV2kevsmPpaNQbzg818zsJ/O8ck6HQ82LuP6mT4ZeUllKug7+5IK9qN64hL8YcxhOIoxulMHaG7vN6CfHXM+QDOBhPMDpfZNsDbAFjB9ec6GwsJnduWU4hdzTI4p6WnhTE3whPdQs7H0Nil090YrsvYPfJcNH77I9qoq5Mk+gJ5xovj7VhOuyB2o82a3wcYR/cCl2Jny6i7HHg0WQsnOdu7DpiUi9tQC2NvkbQWhze25RKLklClcDNCS6BBV4NVsi57kpxjLL21zkirRJTh+84VAop8ug0nJehsegHwIv64Kwa0Csgx9n0BKRox0Sfc=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 7bc2a95f-4cab-4b25-b16f-08d687938109
X-MS-Exchange-CrossTenant-originalarrivaltime: 31 Jan 2019 15:48:10.3172
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 8ae927fe-1255-47a7-a2af-5f3a069daaa2
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1209
X-OriginatorOrg: fb.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-01-31_08:,,
 signatures=0
X-Proofpoint-Spam-Reason: safe
X-FB-Internal: Safe
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 30 Jan 2019, at 20:34, Dave Chinner wrote:

> On Wed, Jan 30, 2019 at 12:21:07PM +0000, Chris Mason wrote:
>>
>>
>> On 29 Jan 2019, at 23:17, Dave Chinner wrote:
>>
>>> From: Dave Chinner <dchinner@redhat.com>
>>>
>>> This reverts commit a76cf1a474d7dbcd9336b5f5afb0162baa142cf0.
>>>
>>> This change causes serious changes to page cache and inode cache
>>> behaviour and balance, resulting in major performance regressions
>>> when combining worklaods such as large file copies and kernel
>>> compiles.
>>>
>>> https://bugzilla.kernel.org/show_bug.cgi?id=3D202441
>>
>> I'm a little confused by the latest comment in the bz:
>>
>> https://bugzilla.kernel.org/show_bug.cgi?id=3D202441#c24
>
> Which says the first patch that changed the shrinker behaviour is
> the underlying cause of the regression.
>
>> Are these reverts sufficient?
>
> I think so.

Based on the latest comment:

"If I had been less strict in my testing I probably would have=20
discovered that the problem was present earlier than 4.19.3. Mr Gushins=20
commit made it more visible.
I'm going back to work after two days off, so I might not be able to=20
respond inside your working hours, but I'll keep checking in on this as=20
I get a chance."

I don't think the reverts are sufficient.

>
>> Roman beat me to suggesting Rik's followup.  We hit a different=20
>> problem
>> in prod with small slabs, and have a lot of instrumentation on Rik's
>> code helping.
>
> I think that's just another nasty, expedient hack that doesn't solve
> the underlying problem. Solving the underlying problem does not
> require changing core reclaim algorithms and upsetting a page
> reclaim/shrinker balance that has been stable and worked well for
> just about everyone for years.
>

Things are definitely breaking down in non-specialized workloads, and=20
have been for a long time.

-chris