Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7298211imu; Thu, 31 Jan 2019 08:07:41 -0800 (PST) X-Google-Smtp-Source: ALg8bN41XL35kHNkqRcqXCvRQnBy10raQ1ZMqw6zI6OIwCcjrEqRHxp9W+S8IMWyPFhMCOTnxs+A X-Received: by 2002:a62:3541:: with SMTP id c62mr35149544pfa.19.1548950861891; Thu, 31 Jan 2019 08:07:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548950861; cv=none; d=google.com; s=arc-20160816; b=URRcEa+Na6G36OtwFKH+loSVY3miipxOyKIeb2Xe70MBjtS6GI+7ndXH5//Cjh144c eFljh6vTmrhhVucZSqDPy0TFmPxeVFDrIU/fV5hdLrgLn5pk59VCmvJgLv5ivrFHo2jp PKFWnZ8TSXB10LrM6CtOJ3LHNE0LTelmTU3OzFJR4WlHA4bwxz5N1qbsDcCYL4DXcV3h p8kJE5FPd7JQDM+vm73sSN/61yUVoYGwr+W2oTP7SNDZuB7Q5M7PIX60p4ek9KQoktrn ie37vQKPMAhDPyphQBt/IIaqIqo2uZz1hlnu4KU6XBuzqmh10/oVpO60EJBvuL0qXwNs S5fw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=gooXaFqbP9erO54LfTWE8IYjZY0qh13qeeeIf3Xln3w=; b=L7+rsPnLd4OZANrErPmthMY65c2oOQjsMzKTqF+pwxfY4uKVZwxkdaHD4LPNIxSMBM VXB+LMG8XkQoyZdeUDjhLurXMPd4xtL6ABLCbVe/sLnOmn0iRfWNxwHa4JIqEbaXXNL8 Ni9KD4UaeZVIhuK7TJoC0NTvvhUkWYO9YWNl19y47qkPNZkzabTYJesrb2GgJhmmLUPa eEwdzws5JsBnUvUneFnih4ADQBIZt9/1KWINAxpeOzux3+eCQUefcgogbrdbk0OAmOZA OXaDwnFe2anoh4o9HeASlE8DQnNhd7oBNT8bR0AzZdtzLA+FAq1u7xUVXvCiu+TyK4Mp Cj2A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id e11si4772271pls.71.2019.01.31.08.07.18; Thu, 31 Jan 2019 08:07:41 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387961AbfAaQGu (ORCPT + 99 others); Thu, 31 Jan 2019 11:06:50 -0500 Received: from mga04.intel.com ([192.55.52.120]:32904 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733167AbfAaQGt (ORCPT ); Thu, 31 Jan 2019 11:06:49 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2019 08:06:49 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,545,1539673200"; d="scan'208";a="112663180" Received: from rkazants-mobl.ccr.corp.intel.com (HELO localhost) ([10.249.254.212]) by orsmga006.jf.intel.com with ESMTP; 31 Jan 2019 08:06:46 -0800 Date: Thu, 31 Jan 2019 18:06:45 +0200 From: Jarkko Sakkinen To: Jerry Snitselaar Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] tpm: don't return bool from update_timeouts Message-ID: <20190131160645.GC5629@linux.intel.com> References: <20190130220659.10102-1-jsnitsel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190130220659.10102-1-jsnitsel@redhat.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 30, 2019 at 03:06:58PM -0700, Jerry Snitselaar wrote: > Set tpm_chip->timeouts_adjusted directly in the update_timeouts > code instead of returning bool. In case of tpm read failing > print warning that the read failed and continue on. > > Reviewed-by: Jarkko Sakkinen > Signed-off-by: Jerry Snitselaar Your signed-off-by should be before my reviewed-by (no need to resend). /Jarkko