Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7301518imu; Thu, 31 Jan 2019 08:09:52 -0800 (PST) X-Google-Smtp-Source: ALg8bN66kNtoY+qGKZV05kqhAg6R8DT8gEqjKuAaRRXS8WZGOGBlnTnC+5q0fpNOb6wvwEKwherb X-Received: by 2002:a63:8043:: with SMTP id j64mr32546859pgd.405.1548950992096; Thu, 31 Jan 2019 08:09:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548950992; cv=none; d=google.com; s=arc-20160816; b=A6+BBOSqUJBic4Pjw6LYv/7DUdk2CRr3iaxJsrXDl+a/XmaROoKuE32wWgdTCc8fc+ pviTf7NIDsxXF4lC6Q04J9dDmnfxiZCg2PKnKBE7zKtSL4gpKf8s1Ac1vyB0mlfUUkRV aHKnagvlxR3NaZNccu759oUNLJd3/XUvrSDPi3NYSb4bgGYFecAhVfE6f5Tds9v90NQX YXectWGi8QafKr3TPmSYU15lUH5RVEcXHZjV4xM3OVcc3GuJLW6pdFqPgshX4ktnQEgB X//gos2uKiQFuR+ZKwd+1xi2meSLMm2BgRJdRAzO+D+K1KNin7VUbGLlvNUtJFXi9FUa YDsA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=jQ6hRrdE7wQlMcY/VYKCAztNQiE1SucYIlnmlRuMf04=; b=V9Mt+x7fGyZBK0Su61FuFgm9XXTlMpPBdNrAn+pMp1hL44nLoY0G6dpOUSZWzwaGyb hbuxrcra1d4W8nTBjGTD7nzAymZzVbhLjUddHH+Tb3icZVDnWdn1MYeWXAFFGLszfltZ Il+aYkR5pTN4+Emm8Q07S/8Enebuxoz6UszwcnvEV7GuzUuqVXm5oH7OAW9scW5YdvR9 DJliADXRzl3awoOaI6Rh6l0jsxHpz1UwDbmeYTJ8DLdogZaiTfaQFY3mUcucBBHuRXGK 6Iy6xHdQopZBvA0D6g8PP8FEmU8Vt38n7rH7jotMhlj/6kdBuGh9d9kUBDxEkXoiy9Fo 66WQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h16si4390267pgh.283.2019.01.31.08.09.35; Thu, 31 Jan 2019 08:09:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388082AbfAaQHT (ORCPT + 99 others); Thu, 31 Jan 2019 11:07:19 -0500 Received: from mga12.intel.com ([192.55.52.136]:62377 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1733167AbfAaQHS (ORCPT ); Thu, 31 Jan 2019 11:07:18 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2019 08:07:17 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,545,1539673200"; d="scan'208";a="112663281" Received: from rkazants-mobl.ccr.corp.intel.com (HELO localhost) ([10.249.254.212]) by orsmga006.jf.intel.com with ESMTP; 31 Jan 2019 08:07:15 -0800 Date: Thu, 31 Jan 2019 18:07:13 +0200 From: Jarkko Sakkinen To: Jerry Snitselaar Cc: linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] tpm: don't return bool from update_timeouts Message-ID: <20190131160713.GD5629@linux.intel.com> References: <20190130220659.10102-1-jsnitsel@redhat.com> <20190131160645.GC5629@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190131160645.GC5629@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 31, 2019 at 06:06:45PM +0200, Jarkko Sakkinen wrote: > On Wed, Jan 30, 2019 at 03:06:58PM -0700, Jerry Snitselaar wrote: > > Set tpm_chip->timeouts_adjusted directly in the update_timeouts > > code instead of returning bool. In case of tpm read failing > > print warning that the read failed and continue on. > > > > Reviewed-by: Jarkko Sakkinen > > Signed-off-by: Jerry Snitselaar > > Your signed-off-by should be before my reviewed-by (no need to > resend). ... and linux-security-module is missing (need to resend). /Jarkko