Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7504767imu; Thu, 31 Jan 2019 11:11:20 -0800 (PST) X-Google-Smtp-Source: ALg8bN7QFA5+dshY6uHh/Jy262dxi1GIHfSU/l3XiaHWnD6wD2iJBWSJEg+ZtTkX+8Mp6ozlHr8d X-Received: by 2002:a62:7c47:: with SMTP id x68mr36319831pfc.209.1548961880841; Thu, 31 Jan 2019 11:11:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548961880; cv=none; d=google.com; s=arc-20160816; b=yCvwBobUThybcTbDlgLTkdrJF9iwbSyga8USX7XgU1otvJ7c15mQarK9KiVaDJB0Uw mHo/SAsgDIdPUwRQiuM4mXcTX85JIiI0kWau4kf34h7FGkvxrPnehYycBffH0AWybzPX F4tK/4UvyH2xtp5CWjw7eQ5avYGrw3tyaEd+ht7kvrl6YvgJ8XGkzcp96RrKpfyzu2dI AAnktccY4lHlagtfO6ciiXb/gI5d1PtIMk+shalq6gdnDWq4TU+ZuN0Zt3HPaYIO24lA dUfQMlmHhxeOPquiB1BqKswDQa9G1cIvgI+kl3xQMeYw9ULHZUtJisw5Qc78YnC2ODGd BouA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=xscg+IDwK+piZ4gwM9pr76+iGnilAL9l9sUJBQ14ql4=; b=szngFzQxSRhl8nkf/qjUM5LuDCB0ISk+3MF+mf3vz7Iu8dn5bmm5DtsuRuLKZf4TVM sqyc37p3LmnEVoqap9hf1U6pll81Pkkn1dVjKy1NTidHEzktxJ9HbanJETFudSSB4wl0 8wk0ynzlXgomshvVpLEV3Cf5kse42405+rEhzKSRBHBRwgtm38e7g83WtIJJ4pjNaBhL 4oOhTHyIdU6eB7JEZxDFeSBJQXkX/dia30IXVPpaYusp07xsf3TXFBSYl+f07CtaVsym MjZgFfJZGNPwyaDjMps+qlfJWWh819CCL25C3XwCXKvYo9Ca5i/gldTrrqwoGpvlRFo7 z+3g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=WSdZg3Gg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z123si5301946pfc.97.2019.01.31.11.11.05; Thu, 31 Jan 2019 11:11:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@linux-foundation.org header.s=google header.b=WSdZg3Gg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728477AbfAaTKo (ORCPT + 99 others); Thu, 31 Jan 2019 14:10:44 -0500 Received: from mail-lj1-f193.google.com ([209.85.208.193]:33904 "EHLO mail-lj1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726278AbfAaTKn (ORCPT ); Thu, 31 Jan 2019 14:10:43 -0500 Received: by mail-lj1-f193.google.com with SMTP id u89-v6so3696544lje.1 for ; Thu, 31 Jan 2019 11:10:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xscg+IDwK+piZ4gwM9pr76+iGnilAL9l9sUJBQ14ql4=; b=WSdZg3GgdCf+Bfnb/A+u6kK/WpovsTeVodF2/V5GuUcUeDkcXBt+Io4wfbZtEB10pR uWykPgozcSi9R+lsNeRiDIVXAhIHyaJlu4Q34fAMU6DMQ98fuJ7fIiolhm9S2/Dez8oN do5hjWbqseBMjJJBGiVlLhgtJtFN6ap3qboak= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xscg+IDwK+piZ4gwM9pr76+iGnilAL9l9sUJBQ14ql4=; b=ZRVaFGTHG5aQc+4FJLSBLWY6DpiZnd8/TbdqzRtmX+LkuKDRZlMiTIRzjt+LRvslnQ v1OY61hAzYCt0iB1TOrQLfOvXaugwffTclYDetX22a/RnbBLEafNSgWJ0ZPeIReh+HD7 eHGpl6Plrhg73kiwoxpgcbQGFS4/I2u09ze1DQWc+WN5r2a10KLyuwFJhd5ANnwI9sPE u/eK4Bq/lMQd81NJ0qjyw22snmBP29KZbP2LKZTuLpdbbh+vp8Vy8/Eh8J8I6D+A3x7t 9tks56bx3XCgS6WJm2IdYkTO9gkuUSBMOeCyurAZYQeI6BR+zgcrUEfaHtnhs3s8vf/H M/9g== X-Gm-Message-State: AJcUukerzmeCwPzsKkSwnxCNaxcPOLjfdlWwZg1kilAtUvwnkp4PACzL XFuk2CUWiepQLihpJ/3BWqqWfvPSmCM= X-Received: by 2002:a2e:908b:: with SMTP id l11-v6mr28607254ljg.150.1548961840367; Thu, 31 Jan 2019 11:10:40 -0800 (PST) Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com. [209.85.208.181]) by smtp.gmail.com with ESMTPSA id s9-v6sm918591lja.12.2019.01.31.11.10.37 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 31 Jan 2019 11:10:37 -0800 (PST) Received: by mail-lj1-f181.google.com with SMTP id v15-v6so3602511ljh.13 for ; Thu, 31 Jan 2019 11:10:37 -0800 (PST) X-Received: by 2002:a2e:880a:: with SMTP id x10-v6mr30717208ljh.174.1548961837166; Thu, 31 Jan 2019 11:10:37 -0800 (PST) MIME-Version: 1.0 References: <20190122010218.GA26713@linux.intel.com> <20190122025836.GH25163@ziepe.ca> <20190122132910.GA2720@linux.intel.com> <20190123153638.GA8727@linux.intel.com> <20190129132016.GA1602@linux.intel.com> <20190131122606.GA12470@linux.intel.com> <20190131160437.GA5629@linux.intel.com> <20190131170603.GA18349@linux.intel.com> <20190131183530.GA27112@linux.intel.com> In-Reply-To: From: Linus Torvalds Date: Thu, 31 Jan 2019 11:10:20 -0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Getting weird TPM error after rebasing my tree to security/next-general To: Jarkko Sakkinen Cc: tomas.winkler@intel.com, Jason Gunthorpe , James Bottomley , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, Linux List Kernel Mailing Content-Type: multipart/mixed; boundary="000000000000136afa0580c5c8f2" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --000000000000136afa0580c5c8f2 Content-Type: text/plain; charset="UTF-8" On Thu, Jan 31, 2019 at 10:52 AM Linus Torvalds wrote: > > I think what I should do is to just make "memcpy_*io()" do the "align > naturally" thing. > > Let me cook up a patch for you to test. Does this work for you? I haven't tested it at all, but I verified that the generated code seems to make at least some amount of sense. Linus --000000000000136afa0580c5c8f2 Content-Type: text/x-patch; charset="US-ASCII"; name="patch.diff" Content-Disposition: attachment; filename="patch.diff" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_jrkzvf6d0 IGFyY2gveDg2L2xpYi9pb21lbS5jIHwgMjcgKysrKysrKysrKysrKysrKysrKysrKysrLS0tCiAx IGZpbGUgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwgMyBkZWxldGlvbnMoLSkKCmRpZmYgLS1n aXQgYS9hcmNoL3g4Ni9saWIvaW9tZW0uYyBiL2FyY2gveDg2L2xpYi9pb21lbS5jCmluZGV4IDY2 ODk0Njc1ZjNjOC4uN2I1YjA3ZjNkMzcwIDEwMDY0NAotLS0gYS9hcmNoL3g4Ni9saWIvaW9tZW0u YworKysgYi9hcmNoL3g4Ni9saWIvaW9tZW0uYwpAQCAtMyw3ICszLDcgQEAKICNpbmNsdWRlIDxs aW51eC9pby5oPgogCiAvKiBPcmlnaW5hbGx5IGZyb20gaTM4Ni9zdHJpbmcuaCAqLwotc3RhdGlj IF9fYWx3YXlzX2lubGluZSB2b2lkIF9faW9tZW1fbWVtY3B5KHZvaWQgKnRvLCBjb25zdCB2b2lk ICpmcm9tLCBzaXplX3QgbikKK3N0YXRpYyBfX2Fsd2F5c19pbmxpbmUgdm9pZCByZXBfbW92cyh2 b2lkICp0bywgY29uc3Qgdm9pZCAqZnJvbSwgc2l6ZV90IG4pCiB7CiAJdW5zaWduZWQgbG9uZyBk MCwgZDEsIGQyOwogCWFzbSB2b2xhdGlsZSgicmVwIDsgbW92c2xcblx0IgpAQCAtMTksMTUgKzE5 LDM2IEBAIHN0YXRpYyBfX2Fsd2F5c19pbmxpbmUgdm9pZCBfX2lvbWVtX21lbWNweSh2b2lkICp0 bywgY29uc3Qgdm9pZCAqZnJvbSwgc2l6ZV90IG4pCiAJCSAgICAgOiAibWVtb3J5Iik7CiB9CiAK KyNkZWZpbmUgbW92cyh0eXBlLHRvLGZyb20pIFwKKwlhc20gdm9sYXRpbGUoIm1vdnMiIHR5cGU6 Ij0mRCIgKHRvKSwgIj0mUyIgKGZyb20pOiIwIiAodG8pLCAiMSIgKGZyb20pOiJtZW1vcnkiKQor CiB2b2lkIG1lbWNweV9mcm9taW8odm9pZCAqdG8sIGNvbnN0IHZvbGF0aWxlIHZvaWQgX19pb21l bSAqZnJvbSwgc2l6ZV90IG4pCiB7Ci0JX19pb21lbV9tZW1jcHkodG8sIChjb25zdCB2b2lkICop ZnJvbSwgbik7CisJLyogVW5hbGlnbmVkIElPPyAqLworCWlmIChuICYmIHVubGlrZWx5KDEgJiAo dW5zaWduZWQgbG9uZylmcm9tKSkgeworCQltb3ZzKCJiIiwgdG8sIGZyb20pOworCQluLS07CisJ fQorCWlmIChuID4gMSAmJiB1bmxpa2VseSgyICYgKHVuc2lnbmVkIGxvbmcpZnJvbSkpIHsKKwkJ bW92cygidyIsIHRvLCBmcm9tKTsKKwkJbi09MjsKKwl9CisJcmVwX21vdnModG8sIChjb25zdCB2 b2lkICopZnJvbSwgbik7CiB9CiBFWFBPUlRfU1lNQk9MKG1lbWNweV9mcm9taW8pOwogCiB2b2lk IG1lbWNweV90b2lvKHZvbGF0aWxlIHZvaWQgX19pb21lbSAqdG8sIGNvbnN0IHZvaWQgKmZyb20s IHNpemVfdCBuKQogewotCV9faW9tZW1fbWVtY3B5KCh2b2lkICopdG8sIChjb25zdCB2b2lkICop IGZyb20sIG4pOworCS8qIFVuYWxpZ25lZCBJTz8gKi8KKwlpZiAobiAmJiB1bmxpa2VseSgxICYg KHVuc2lnbmVkIGxvbmcpdG8pKSB7CisJCW1vdnMoImIiLCB0bywgZnJvbSk7CisJCW4tLTsKKwl9 CisJaWYgKG4gPiAxICYmIHVubGlrZWx5KDIgJiAodW5zaWduZWQgbG9uZyl0bykpIHsKKwkJbW92 cygidyIsIHRvLCBmcm9tKTsKKwkJbi09MjsKKwl9CisJcmVwX21vdnMoKHZvaWQgKil0bywgKGNv bnN0IHZvaWQgKikgZnJvbSwgbik7CiB9CiBFWFBPUlRfU1lNQk9MKG1lbWNweV90b2lvKTsKIAo= --000000000000136afa0580c5c8f2--