Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp25285ima; Thu, 31 Jan 2019 11:47:48 -0800 (PST) X-Google-Smtp-Source: ALg8bN43axYfDgNeutvUre55Zy7k+LHVOVmUAr6FoGnfTmZzSphNHxZQlLfohnKGaUwbil5eQtlZ X-Received: by 2002:a17:902:a03:: with SMTP id 3mr36467246plo.112.1548964068804; Thu, 31 Jan 2019 11:47:48 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1548964068; cv=none; d=google.com; s=arc-20160816; b=oVtaxwCx6Z0bQbJ+0fOB/JScqTqh4aAdxBBudRR7RcqF8vLd4f3URSy7+EXMz5YiUf Us45V7Mo3NYwLaVLnfnV6UIQUlELrT3A14+mUARe2MjBfe2mQZj0Fk22cZHtKbFnBip6 ZMZbXFsEs7ZnFgNVB7i/+Fhr+qC3Fxzs6tSwX530AOVye8N+wfMGWD+7SS/GMI3mPiT6 WoIu1ax8DUXqJ5YjK5N5dr5H8rcg5jyWJPCMikwQC5UIxqPXryR8X4RRCNeSMBu/kLLb YVTRXIoR8gsJi8DymK2SSCfZqjP6dO/Lj/qact6DfZ8J9AN4mVKhWJlpAxyJGA0n0oE6 89kg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=7SEkeZ6HJeyBH0TKS5Z7kKOPnZIXVD3l2NjYMrLGXP0=; b=ChyRPloBIfi8cZ4R6PXG3TsidkAsazmrG7KJhazW+Xk6Mnqd246Vf8Z+jrCIwlcPst uF+XrkmmQm7jhrzeerFB20BHFty7QDOVL9cb7Gl1N+7DANC6TlqwfEnSE0MPECTsDZ/M h+CHN/V3X4PVNeYxfKm28fYFZ09WhZYcT1DJnBrmeCawJPgid7lvHXYjEHwZdWZmbPTB FwG/1cwt8zINafRWJGgP9E+i83CpHT1xNxV2PDqfXfPbbntYfTEp8pkahNYBnjlnL3wt wXjDMGepTp7h8X81rOxYU3GbfgYO4car0bbwvzSMXmDfWj0LoraHKxTZE73lTRVOKgFd sSSw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 11si4869228pgs.126.2019.01.31.11.47.34; Thu, 31 Jan 2019 11:47:48 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727976AbfAaTdp (ORCPT + 99 others); Thu, 31 Jan 2019 14:33:45 -0500 Received: from asavdk3.altibox.net ([109.247.116.14]:39491 "EHLO asavdk3.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726060AbfAaTdp (ORCPT ); Thu, 31 Jan 2019 14:33:45 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk3.altibox.net (Postfix) with ESMTPS id 930F520031; Thu, 31 Jan 2019 20:33:42 +0100 (CET) Date: Thu, 31 Jan 2019 20:33:40 +0100 From: Sam Ravnborg To: Thierry Reding , dri-devel@lists.freedesktop.org Cc: David Airlie , linux-kernel@vger.kernel.org, Stefan Mavrodiev Subject: Re: [PATCH v1 0/19] drm/panel: drmP.h removal and DRM_DEV* Message-ID: <20190131193340.GA2929@ravnborg.org> References: <20190131192619.9763-1-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190131192619.9763-1-sam@ravnborg.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=dqr19Wo4 c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=6RmNp6sAYilJb8JbLVgA:9 a=q7FuESofmqym2wpK:21 a=EXmA4UXLiXgPqqSR:21 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi all. On Thu, Jan 31, 2019 at 08:26:00PM +0100, Sam Ravnborg wrote: > Hi Thierry et al. > > While reviewing a number of new panel drivers there was a > certain pattern in the feedback: > - the now deprecated drmP.h file was used > - dev_err() and friends was used > > This patch-set address the above items in the panel > drivers in drm/panel/ > The hope is that new panel drivers will no longer inherit bad > patterns from the existing drivers. > > The use of DRM_DEV* is not accepted by everyone, so this conversion > was split up in smaller bits. > If some drivers do not want to use DRM_DEV* then just drop the relevant patch. > > All patches are build tested on x86/arm. > > The DRM_DEV* patches depends on the drmP.h removal. > > One extra patch sneaked in "panel-innolux: drop unused variable" > This is a fix for an unused variable and was added to flush my panel patches. > > Note: Waiting for key storage (for gpg key) before I start the process getting > commit rights, so I rely on someone else (Thierry?) to commit this. > > Patches are made on top of drm-misc-next as of a few days ago. Just for the record, all patches are checkpatched - OK. A lot of the DRM_DEV_ERROR() etc lines had to be linewrapped to avoid the maximum linelength. The conversion was done manually, no fancy coincielle script behind. That's something to look into for future changes. Sam