Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 1 Feb 2019 13:31:46 +0800
From:   Herbert Xu <herbert@gondor.apana.org.au>
To:     Eric Biggers <ebiggers@kernel.org>
Cc:     linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org,
        "Jason A . Donenfeld" <Jason@zx2c4.com>
Subject: Re: [RFC/RFT PATCH 09/15] crypto: testmgr - introduce
 CONFIG_CRYPTO_MANAGER_EXTRA_TESTS
Message-ID: <20190201053146.mgswr6w7zktl7cet@gondor.apana.org.au>
References: <20190123224926.250525-1-ebiggers@kernel.org>
 <20190123224926.250525-10-ebiggers@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190123224926.250525-10-ebiggers@kernel.org>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed, Jan 23, 2019 at 02:49:20PM -0800, Eric Biggers wrote:
> 
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index 86960aa53e0f..cbeba16fd8c1 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -168,6 +168,16 @@ config CRYPTO_MANAGER_DISABLE_TESTS
>  	  Disable run-time self tests that normally take place at
>  	  algorithm registration.
>  
> +config CRYPTO_MANAGER_EXTRA_TESTS
> +	bool "Enable extra run-time crypto self tests"
> +	depends on !CRYPTO_MANAGER_DISABLE_TESTS

Perhaps add a dependency on DEBUG_KERNEL so we don't bother people
who don't care?

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt