Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp62350ima; Thu, 31 Jan 2019 23:02:07 -0800 (PST) X-Google-Smtp-Source: AHgI3IYOgHdqGNOYp2LRFL5kFDMOGDFxHBtgfW4zKmHhN9w7rTcs43mefr3BBVjQVmrCbLh8uCaK X-Received: by 2002:a63:e001:: with SMTP id e1mr1133900pgh.39.1549004527894; Thu, 31 Jan 2019 23:02:07 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549004527; cv=none; d=google.com; s=arc-20160816; b=nZ81VFIPRchc9tItBwm90CwUfR1mm9CMtQTgbjTLDFu//FUEelpYyyvuZFKB84G9et 0ys/0ba+o7WKWOdrrBmKTy8lDROBOmK36ZfxikHRHe0XwxgSqWxsWThKc/0hSjHJtN/o 29jmKHEd7v/715eTcSWlchNKhk+NbH+V7yqZNHIFLmkkKVRFlYD1FVqLpqKcWFW+gcty PXpCWJai3aEib5674abDqOvjxXA3s7S7aJ/MlRVF8yPq8mXjYuEdaienbRhk1fxUE4VD wwxClV1RuEIb01F3YLXWxP96yslXz9ZnEXpqxKKuggYbjsz1SuDARgEU7gkyX+2Ojv/U edww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=VCwHnxBmsWffxSTWMebLiPhlQqV7Yg6roGAxdKIDKuw=; b=PVpKF6w0XlJOLNzsEXekvPYBZo4AgZjiDoReEtxDU16X2vEKM2BTF34ryoghEHQL1p DxJbmIdcZpuktSzdbdiGaTH98MYAjZpI9J4yVCh+774uCaodfQeFvrZ8IdJ3nLU0qrMS VGiXzzl7P4tq11UumisWC/X9OjhdxlgtLkcVvRCA9gl8J7hUz16bkTmh1cHdfB+ej4yq DctpoR8t82NNwS5ht74v27Y4zBfO0/7on4x+Nrxj6RDZaZq7z96a9xYtdjwd45gZGTpO +D1UEuGNtANcGaI2KpuxaGRtQH/60YGNMsPMs1p68IGdGXhBGB5qmVivBUyEECg5pwnt lxsQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l13si6487576pgi.46.2019.01.31.23.01.50; Thu, 31 Jan 2019 23:02:07 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727918AbfBAGtB (ORCPT + 99 others); Fri, 1 Feb 2019 01:49:01 -0500 Received: from orcrist.hmeau.com ([104.223.48.154]:56930 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725763AbfBAGtB (ORCPT ); Fri, 1 Feb 2019 01:49:01 -0500 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1gpSdF-00006o-Fq; Fri, 01 Feb 2019 14:48:57 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1gpSdE-0005kw-Bu; Fri, 01 Feb 2019 14:48:56 +0800 Date: Fri, 1 Feb 2019 14:48:56 +0800 From: Herbert Xu To: Greg Kroah-Hartman Cc: David Miller , linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org Subject: Re: [PATCH 0/7] crypto: cleanup debugfs usage Message-ID: <20190201064856.vslf3o2pymqxue5n@gondor.apana.org.au> References: <20190122151422.14204-1-gregkh@linuxfoundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190122151422.14204-1-gregkh@linuxfoundation.org> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 22, 2019 at 04:14:15PM +0100, Greg Kroah-Hartman wrote: > When calling debugfs code, there is no need to ever check the return > value of the call, as no logic should ever change if a call works > properly or not. Fix up a bunch of crypto-specific code to not care > about the results of debugfs. > > Greg Kroah-Hartman (7): > crypto: qat: no need to check return value of debugfs_create functions > crypto: ccrree: no need to check return value of debugfs_create > functions > crypto: axis: no need to check return value of debugfs_create > functions > crypto: cavium: zip: no need to check return value of debugfs_create > functions > crypto: cavium: nitrox: no need to check return value of > debugfs_create functions > crypto: ccp: no need to check return value of debugfs_create functions > crypto: caam: no need to check return value of debugfs_create > functions > > drivers/crypto/axis/artpec6_crypto.c | 9 ---- > drivers/crypto/caam/ctrl.c | 21 +++----- > drivers/crypto/caam/intern.h | 1 - > drivers/crypto/cavium/nitrox/nitrox_debugfs.c | 27 ++-------- > drivers/crypto/cavium/nitrox/nitrox_debugfs.h | 5 +- > drivers/crypto/cavium/nitrox/nitrox_main.c | 4 +- > drivers/crypto/cavium/zip/zip_main.c | 52 ++++--------------- > drivers/crypto/ccp/ccp-debugfs.c | 36 +++---------- > drivers/crypto/ccree/cc_debugfs.c | 22 ++------ > drivers/crypto/ccree/cc_debugfs.h | 8 +-- > drivers/crypto/ccree/cc_driver.c | 7 +-- > drivers/crypto/qat/qat_c3xxx/adf_drv.c | 5 -- > drivers/crypto/qat/qat_c3xxxvf/adf_drv.c | 5 -- > drivers/crypto/qat/qat_c62x/adf_drv.c | 5 -- > drivers/crypto/qat/qat_c62xvf/adf_drv.c | 5 -- > drivers/crypto/qat/qat_common/adf_cfg.c | 7 --- > drivers/crypto/qat/qat_common/adf_transport.c | 6 --- > .../qat/qat_common/adf_transport_debug.c | 15 ------ > drivers/crypto/qat/qat_dh895xcc/adf_drv.c | 5 -- > drivers/crypto/qat/qat_dh895xccvf/adf_drv.c | 5 -- > 20 files changed, 38 insertions(+), 212 deletions(-) All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt