Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp89491ima; Thu, 31 Jan 2019 23:36:19 -0800 (PST) X-Google-Smtp-Source: ALg8bN6DZOIRwYPyjTfeLgeO4PeOHlrQFkmZ4NHSHdQgjXshawFdtjFmNKsYwo47UHR2ljOzg3oA X-Received: by 2002:a17:902:1105:: with SMTP id d5mr37037516pla.47.1549006579226; Thu, 31 Jan 2019 23:36:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549006579; cv=none; d=google.com; s=arc-20160816; b=UxcQmht6i3P+WbjGFGDOEjJU0ICClns2+9kQY6gYCt+lqFXCTMT+Z1TQUgMPq/p7Nh KC+kan6AjUXrxkoip7GR9OsMI/J8APnxA66qJ9GBDPSYhbaUU7DW8Om4UbMKLaqe7Jl4 LaGU52MdnMclza9Kfm90xG+VqHP2Mn8O+AG0qa2qCqc9kWLPGu4DzRgDYiVO5ER8qT4F QXrOCDV3gzBMz9kJGC1GDLXEIhYOkQ1BcvjG+J+isi/2vyL2s7L0r6q6DdBgvBuZWaL8 ugQ3muLIE5g+rAkRfedw8a3U/QKh0oHJoQC6yYmxQYRSGUXRI2UHNeE4yn+1sFQVTgW0 jCxw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=M3DWM4avy3ltU531Bf/mObyDbMTf8RDLrtQKHrhZoqQ=; b=DQwTos888x2GWrUIPkt42+qUhtSQ2VHd1+CagdYr4cLqtirBYto1DfrOjVBckbAZtX ktZ6u8XQyDQ/EsA3P/xbIqs1dt1HxYbHf5PfLPbOboonlAtBVthCP7CN3HQ6Q/GzDj4w 2oOIgEer7fCoGLyPqHxGggM5m7uN2J1NN35oiEubrwZGlzu7cKbBa2Pe3glAV4IjvoVo 3YAG0RETTYta57NS56v/mwQgH/sLF5rQ7zUJvodrYPbb4qJh1vJ6TMK3Qb/DcORUrirg AqIkDr/rpLM6J6jN7bQ8VuP0zS02wXoCaN4MYomVEejOwy5nrHVIC0PtjVh0JVNIzY8+ D0mQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d1si6691863pla.412.2019.01.31.23.36.04; Thu, 31 Jan 2019 23:36:19 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727829AbfBAHcn (ORCPT + 99 others); Fri, 1 Feb 2019 02:32:43 -0500 Received: from mga12.intel.com ([192.55.52.136]:57767 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727538AbfBAHcl (ORCPT ); Fri, 1 Feb 2019 02:32:41 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 31 Jan 2019 23:32:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,547,1539673200"; d="scan'208";a="114430715" Received: from rajneesh-desk.iind.intel.com ([10.223.86.34]) by orsmga008.jf.intel.com with ESMTP; 31 Jan 2019 23:32:38 -0800 From: Rajneesh Bhardwaj To: platform-driver-x86@vger.kernel.org Cc: dvhart@infradead.org, andy@infradead.org, linux-kernel@vger.kernel.org, Rajneesh Bhardwaj , "David E. Box" , Srinivas Pandruvada Subject: [PATCH 04/10] platform/x86: intel_pmc_core: Fix file permissions for ltr_show Date: Fri, 1 Feb 2019 13:02:28 +0530 Message-Id: <20190201073234.13280-5-rajneesh.bhardwaj@linux.intel.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190201073234.13280-1-rajneesh.bhardwaj@linux.intel.com> References: <20190201073234.13280-1-rajneesh.bhardwaj@linux.intel.com> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org File permissions for ltr_show attribute should be similar to other debugfs attributes created by this driver. '0644' should be used only when there is a write operation desired such as for ltr_ignore. Cc: "David E. Box" Cc: Srinivas Pandruvada Fixes: 63cde0c16c67 ("platform/x86: intel_pmc_core: Show Latency Tolerance info") Signed-off-by: Rajneesh Bhardwaj --- drivers/platform/x86/intel_pmc_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/intel_pmc_core.c b/drivers/platform/x86/intel_pmc_core.c index 80936e6bdc61..125461ca2927 100644 --- a/drivers/platform/x86/intel_pmc_core.c +++ b/drivers/platform/x86/intel_pmc_core.c @@ -702,7 +702,7 @@ static int pmc_core_dbgfs_register(struct pmc_dev *pmcdev) debugfs_create_file("ltr_ignore", 0644, dir, pmcdev, &pmc_core_ltr_ignore_ops); - debugfs_create_file("ltr_show", 0644, dir, pmcdev, &pmc_core_ltr_fops); + debugfs_create_file("ltr_show", 0444, dir, pmcdev, &pmc_core_ltr_fops); if (pmcdev->map->pll_sts) debugfs_create_file("pll_status", 0444, dir, pmcdev, -- 2.17.1