Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp126333ima; Fri, 1 Feb 2019 00:24:39 -0800 (PST) X-Google-Smtp-Source: AHgI3IYDcnNiUvETKV7uk4aGwkjRUEGncUVNrk391V2kI5wywOavnTEvydKiyAzse2/T1LiQHWmw X-Received: by 2002:a63:5320:: with SMTP id h32mr1324109pgb.414.1549009479655; Fri, 01 Feb 2019 00:24:39 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549009479; cv=none; d=google.com; s=arc-20160816; b=HAsB1xOTUXU3XakW9CoMiMBMF67ECl9tiNSEeNaL4stsSNbJJ8zGThn0+Z12eDUOWz alCefFF7NhG/uLDQgF9Pc9k5ItmSyEmjgZEI4IWMMUoPMMnGlsM3olljYPJe5LTUKH7k NY1Cxr7MjCm69suQis5NFXnfZZth7xaG+sTW7ogXZWjr8ovBo/NiqQ1rVe3uohrDgIhE mrm8GGGBa9G663a4QeqDAdwJouT5oHyvjfd5r2OaDiRd3bELya6B0ZOZSw/iXXcP3Lem 2kpz3OiK5wZ/6hsysHVf3BRL3mlL47kW/bW9XAZHOV1I5OzF9+T6JrF3AqZhyVaUpUJi QNHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=KC5N+2pImrNQlS+0m0SbZw6Nm43DzgfgSGgJcVVrl+I=; b=BgofRPtLPsBPFDZn+OGMBlF0yG6NNY+rL+9x3GSlv77okVIPlkXT6BVdOnfkk30bjk lJcvTTFlEnCopOIQyR49U0qqCyC31dGjSAbZQBPN5KEbzhb8OH5rP4O2uz45i9umf9gR NDfXa7c8wl9giik6A+cLm3YJx42JrBERV00rEofAzrmayXEtzf0zlUOQhNCnAmo7fuTA l8qo7Amnq1+M/vOmC+8+C9LLyJZtHO3C4R94eaMMMhmQZHHozV63dVFERFHUVPDczpfw 2M/RSM35wDH9x56m8E0N7dSyvjRTZ18yB4R2QRRX0kJkjiEMU+5ntJzS/DZxxywhLg1a GqVQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h7si6760753pls.326.2019.02.01.00.24.24; Fri, 01 Feb 2019 00:24:39 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728787AbfBAIYF (ORCPT + 99 others); Fri, 1 Feb 2019 03:24:05 -0500 Received: from mga18.intel.com ([134.134.136.126]:59664 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726110AbfBAIYF (ORCPT ); Fri, 1 Feb 2019 03:24:05 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2019 00:24:04 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,547,1539673200"; d="scan'208";a="143320217" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.56]) ([10.237.72.56]) by fmsmga001.fm.intel.com with ESMTP; 01 Feb 2019 00:23:57 -0800 Subject: Re: [PATCH v6 15/27] compiler: Option to default to hidden symbols To: Thomas Garnier , kernel-hardening@lists.openwall.com Cc: kristen@linux.intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , x86@kernel.org, Luis Chamberlain , Greg Kroah-Hartman , "Rafael J. Wysocki" , Arnd Bergmann , Luc Van Oostenryck , Steven Rostedt , Jason Baron , Thomas Garnier , Jordan Borgner , Masami Hiramatsu , Masahiro Yamada , "Peter Zijlstra (Intel)" , Andrew Morton , Kees Cook , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Andi Kleen , Jan Beulich , Song Liu , Alexander Shishkin , linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-sparse@vger.kernel.org References: <20190131192533.34130-1-thgarnie@chromium.org> <20190131192533.34130-16-thgarnie@chromium.org> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: <3a2bdc07-e8c4-c340-dde7-516ab0de66f2@intel.com> Date: Fri, 1 Feb 2019 10:22:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190131192533.34130-16-thgarnie@chromium.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/01/19 9:24 PM, Thomas Garnier wrote: > Provide an option to default visibility to hidden except for key > symbols. This option is disabled by default and will be used by x86_64 > PIE support to remove errors between compilation units. > > The default visibility is also enabled for external symbols that are > compared as they maybe equals (start/end of sections). In this case, > older versions of GCC will remove the comparison if the symbols are > hidden. This issue exists at least on gcc 4.9 and before. What does this mean, if anything, for what/how symbols appear in /proc/kallsyms?