Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] staging: android: ion: fix sys heap pool's gfp_flags
To:     Dan Carpenter <dan.carpenter@oracle.com>
CC:     <labbott@redhat.com>, <sumit.semwal@linaro.org>,
        <gregkh@linuxfoundation.org>, <arve@android.com>,
        <tkjos@android.com>, <maco@android.com>,
        <devel@driverdev.osuosl.org>, <puck.chen@hisilicon.com>,
        <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
        <kongfei@hisilicon.com>, <linaro-mm-sig@lists.linaro.org>,
        <daniel.liuyi@hisilicon.com>, <yudongbin@hisilicon.com>
References: <1549004386-38778-1-git-send-email-saberlily.xia@hisilicon.com>
 <20190201081530.GC14343@kadam>
From:   "Xiaqing (A)" <saberlily.xia@hisilicon.com>
Message-ID: <b39b4839-ee9a-802b-8d46-674a61adfa8c@hisilicon.com>
Date:   Fri, 1 Feb 2019 16:30:53 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <20190201081530.GC14343@kadam>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 2019/2/1 16:15, Dan Carpenter wrote:
> On Fri, Feb 01, 2019 at 02:59:46PM +0800, Qing Xia wrote:
>> In the first loop, gfp_flags will be modified to high_order_gfp_flags,
>> and there will be no chance to change back to low_order_gfp_flags.
>>
>> Fixes: e7f63771 ("ION: Sys_heap: Add cached pool to spead up cached buffer alloc")
> 
> Huh...  Presumably you found this bug just by reading the code.  I
> wonder how it affects runtime?
> 
The problem is that when I found that there was no page allocation failure warning
after the failure of the ion alloc in my test, and then I found the problem of gfp_flags.

regards,
Qing

> regards,
> dan carpenter
> 
> 
> .
>