Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp388947ima; Fri, 1 Feb 2019 05:02:44 -0800 (PST) X-Google-Smtp-Source: ALg8bN4Lcpg7tJGPWZN21tmnUqvX/8PvYkUJ6yIz2A8DDxf6J5txCfMlWUpu1tGkzncJXr5u31vV X-Received: by 2002:a17:902:1745:: with SMTP id i63mr38525927pli.145.1549026164193; Fri, 01 Feb 2019 05:02:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549026164; cv=none; d=google.com; s=arc-20160816; b=MZSU+HIp+5rf4mfZy31ySK0XeZnUaSNvQT0mO7VGNM62fF/FAzUQaXBSTietxPKkAC JkC/jIf6KnZCHZJXEaAOLRdf5Xokl2pudrGArqWnidu1ebZJOys55SY/IVfJk768HjDM +Lv3cfdBSRC7oqFBIa8pkLDzV5yc1tqXhNyruo4fufuOYl66DeK6Levkyn6wGh5iOXTX Q2xTYu5KsCddPfU/w5k7vuPMGKBXxw2DE/jM3r0IIT7A6k1Y1metpB69u1rYYxw8gYdK RwMkT+9DqHzU3QJG6F6M4pIwHI9hXIp81zQAjxwdAGQD7DjZKb+fSEKltKJmB/Vl58Ik nqhw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=3mWIRtWfNIb7QAz7Kz9+htT/0etT7fHK8fUtZrniLyw=; b=xUZ0Qnt8Tg+nNoRh46I9O1asbNDMSd4IOcsg0Y82jlekOwU8WeNCdTvysXH7fvjazk onMYjSdX9y4Vn4v0lvRWvIOsNVf3sARZujBM0AgPly//qDJcGLiP+DWAV3rbq1wSwzXX iaFyTuvi97WHG16mw+pEKIOLkUt/eTHYXznnrAaf7VcHHE0Px+typVTlRHA/D0A9t1tc 75wsx6i836WrzJmQIjqV8q67+10XmA4vVeKaCLhtjsPio3AsMizsKUdeLQbV2kaY2fui 3I4YEcPZlVx2aD6tKAWDkZXFCaXKBpdlihZcY7W9zzVM87bEz/2FB991IpsinnyRt3FK z5hQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="KNxsLR/W"; dkim=pass header.i=@codeaurora.org header.s=default header.b=EzPH19E7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q207si1532195pgq.294.2019.02.01.05.02.21; Fri, 01 Feb 2019 05:02:44 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b="KNxsLR/W"; dkim=pass header.i=@codeaurora.org header.s=default header.b=EzPH19E7; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729593AbfBAMdd (ORCPT + 99 others); Fri, 1 Feb 2019 07:33:33 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:48500 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727919AbfBAMdd (ORCPT ); Fri, 1 Feb 2019 07:33:33 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 747FC6085C; Fri, 1 Feb 2019 12:33:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549024412; bh=8byjkJQhvIdlxguakqp1YPZXZeC+DmJDSjeDeJt73bc=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=KNxsLR/WgYFTB2Bs6LBVWyys677DYaineGR3LXfz0Fprq7KzAuoPBrctWsghiWI2i mMudO8/ud0eXfb51B7Vons+pJq/MGru6s4WGG7Df5Jv5wOQKq/NWiANS3PGvgvas7M ODUXqybzZagwkKgHpCVJZvwS/8W5A+1zbUfO4qMw= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 4026B60886; Fri, 1 Feb 2019 12:33:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549024411; bh=8byjkJQhvIdlxguakqp1YPZXZeC+DmJDSjeDeJt73bc=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=EzPH19E7T2AKg1pNgBWKhZYWSqaWwJSHpAHVd8y8j4MHWov69cmX/LMj2bbKCK9Hj ZFJXl0MPRCs+TnNo7czvRb03OgE6sM/5YkPcDav+NoCJdb7Ir14V3Eu7dIywECn06Q 0RgAW7QKLJT8L5PPimZZMdQl1v7313xzPHDqFDGM= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 4026B60886 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] rtlwifi: no need to check return value of debugfs_create functions From: Kalle Valo In-Reply-To: <20190122152151.16139-34-gregkh@linuxfoundation.org> References: <20190122152151.16139-34-gregkh@linuxfoundation.org> To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Ping-Ke Shih , linux-wireless@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190201123332.747FC6085C@smtp.codeaurora.org> Date: Fri, 1 Feb 2019 12:33:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Ping-Ke Shih > Cc: Kalle Valo > Cc: linux-wireless@vger.kernel.org > Signed-off-by: Greg Kroah-Hartman > Acked-by: Larry Finger Patch applied to wireless-drivers-next.git, thanks. 3059785bb76e rtlwifi: no need to check return value of debugfs_create functions -- https://patchwork.kernel.org/patch/10775751/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches