Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp390927ima; Fri, 1 Feb 2019 05:04:18 -0800 (PST) X-Google-Smtp-Source: ALg8bN4ivnS7U57SWCpgpqe8GAUGsFjhihWGXLlwezQMy/0UX6TD5j62WGyK36jOm5G6kudcw9cU X-Received: by 2002:a17:902:8ec8:: with SMTP id x8mr39787203plo.210.1549026258194; Fri, 01 Feb 2019 05:04:18 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549026258; cv=none; d=google.com; s=arc-20160816; b=nd1dfpciyC88W8WB9ZHO66N+b50mEpr6kX8fk5nP1QRo5gOBONFHjmQtJaTOibqU2z jBjyovtgH0WHHb86sp8ZadROENYzIQQrci24cr7cqnKyu+JwqGw1iOmJ1Q4OLHEaAYkG uL6947ce6SJ8Q87FcqfBAm1I0H5+B1NA7i4DtAs5RYpftqMdXMzUIWGvjZYtCAUW1tR8 XOWDrNftpQi8uh0C+ALyUyiknDh9+V04X7RW1p4j1IhRqNITXL7yeekxf2CemQ2gf2+U VY1Ggsw+FkJoGj3LFRqB6CtmOys0KdWR4uF6gkf/qNKuGERrvi8DBDyyeuBKyLv2eDtw ptzg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:user-agent:cc:to :references:in-reply-to:from:subject:content-transfer-encoding :mime-version:dmarc-filter:dkim-signature:dkim-signature; bh=XiTyBAV8hoL+dynn9FJJDyHoKhwmiqEBo7NKjhjdpE0=; b=qf9cva6yWzdA6NuwzlzsJs8oSgNJLBHQ2UhmBqx1a8Atmhron0lWnjrMTX2pG50fdg jjYCBhN+yjLv1QCSykhXllGm4WrPwpmbsu/K7zq8d3xXWxC5JA8eZOIuaQIVKgMqWGsf OsbH6dHibKN0DQP4MeVrz2xmeXgnmyPIgTjgQMzTgmOoAr76vqueTIxT71fyEF1OTLaf SayKnAn9d7OJa9k/0MQmWAtKPKj+rnI/Umaxw/lGDFZ8X8Jc/s6R7bCCzabNclXHjV9I cTTkOKE2+40KdFqagHYjDWVkZqZD4/nb01ovEsdI3ZcT3jDDeeCFse+52ZiMZpnv51HO ixww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=aEjTB36s; dkim=pass header.i=@codeaurora.org header.s=default header.b=WYwyaAIF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x5si7179241pgq.535.2019.02.01.05.03.51; Fri, 01 Feb 2019 05:04:18 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@codeaurora.org header.s=default header.b=aEjTB36s; dkim=pass header.i=@codeaurora.org header.s=default header.b=WYwyaAIF; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728435AbfBAMgd (ORCPT + 99 others); Fri, 1 Feb 2019 07:36:33 -0500 Received: from smtp.codeaurora.org ([198.145.29.96]:51514 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726270AbfBAMgc (ORCPT ); Fri, 1 Feb 2019 07:36:32 -0500 Received: by smtp.codeaurora.org (Postfix, from userid 1000) id 44ABE60590; Fri, 1 Feb 2019 12:36:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549024592; bh=RnjILMZjSlGKh8Wenj1RaeGqjtyB9CfLxqdlS0vXm5A=; h=Subject:From:In-Reply-To:References:To:Cc:Date:From; b=aEjTB36sFPK8DxbNf+32zkYA8OuDdRn9OnTpxQLDO8O8rvRnjCObpJiPceEA5YTV1 reQrLUBtSO3b8onfy4G8SBIhl9mpf8HAigv3VsZyQFs6z81p98tFT0FCmrngwkv/wg l5Qu/wYusF8KtLKv2TSUwGZ/JK5laFKlPTa1LUSo= X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on pdx-caf-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.9 required=2.0 tests=ALL_TRUSTED,BAYES_00, DKIM_INVALID,DKIM_SIGNED,MISSING_DATE,MISSING_MID,URIBL_BLACK autolearn=no autolearn_force=no version=3.4.0 Received: from potku.adurom.net (88-114-240-156.elisa-laajakaista.fi [88.114.240.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: kvalo@smtp.codeaurora.org) by smtp.codeaurora.org (Postfix) with ESMTPSA id 8168B6043F; Fri, 1 Feb 2019 12:36:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=codeaurora.org; s=default; t=1549024591; bh=RnjILMZjSlGKh8Wenj1RaeGqjtyB9CfLxqdlS0vXm5A=; h=Subject:From:In-Reply-To:References:To:Cc:From; b=WYwyaAIFGjsYweIzTmzgk3DZpIAorV/lw880kLOvI7o3tJxSJ717Ccft0pzIMzSVM ZfmrytdeNcna+bfElFh50LZJPFBH+BspcwKwslrZYE5PP61fhITSnHhH7hCMacx+Fp KRyy61cf6zVjyryWqhx1aEio+ZCHdluFoT4FCvOY= DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8168B6043F Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [PATCH] b43legacy: no need to check return value of debugfs_create functions From: Kalle Valo In-Reply-To: <20190122152151.16139-31-gregkh@linuxfoundation.org> References: <20190122152151.16139-31-gregkh@linuxfoundation.org> To: Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Larry Finger , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20190201123632.44ABE60590@smtp.codeaurora.org> Date: Fri, 1 Feb 2019 12:36:32 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Greg Kroah-Hartman wrote: > When calling debugfs functions, there is no need to ever check the > return value. The function can work or not, but the code logic should > never do something different based on this. > > Cc: Larry Finger > Cc: Kalle Valo > Cc: linux-wireless@vger.kernel.org > Cc: b43-dev@lists.infradead.org > Signed-off-by: Greg Kroah-Hartman > Acked-by: Larry Finger Patch applied to wireless-drivers-next.git, thanks. 32b4ebfe7f12 b43legacy: no need to check return value of debugfs_create functions -- https://patchwork.kernel.org/patch/10775777/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches