Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp497105ima; Fri, 1 Feb 2019 06:34:08 -0800 (PST) X-Google-Smtp-Source: AHgI3IY/a/xJ9Dx89lOlPO5m9yvoRAuDz/BEu5qPVNCdNmrcD6DwJsjpKy2dzAb7R0xIVnG8KwVQ X-Received: by 2002:a63:ee0e:: with SMTP id e14mr2453479pgi.8.1549031648384; Fri, 01 Feb 2019 06:34:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549031648; cv=none; d=google.com; s=arc-20160816; b=J8Ap6x7DeRsTumnIMVkbLXvgcbpAfkin8utBG3xTrJS4CjtLpeDjIn/L8C5+7y6R+Q KGbItY//JHbkEruuFwX8EKhqs+P2+HDnmECa8dk+4W6dT0zeG0KCAPV6g3ljqVmY6qXN dXIDIwEDZZ+SYx21MZtVdVLE10yp9gYEMuy0Ryou+09gxMhKYOTSVKSnYT/q0NM8bLn4 p9GfOedA6hxr9CwA15Cz2rSXXfK2wb133ubdpUNb3++tLsZf4oZUEbcESweQfk6ppEeq vw+upstDujOthtID5R8wZCyrRNyLaSxPAuUub92ufuuQuNb3103a4PjS4iYjE61z5GZW Gk3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=m3Dka2DCMwvu403ZRmjmCU3PDrGEiEgcPYFhf5VHcr4=; b=BUmS3bbPT8qAmSuAxqWvN87GUuyeqtEPvdr4rsEbaXLeB686ih1rq9RxrDmQHxKEGf dXeGv404Rq1xd3nFbXVcKYjCWeTrVBGCX7avyPGvBJAAKiOTzAfD1YtwXkCgbzvr6JgJ mbpuK6poQnOPq3un+rsWcfgpWdEnvKo3yYspkmS7d3z9Dpmt/ev6lW3Sudu3IwswE/kq 2H2dXmRDZdw4LFnmICWpgvMHnzeRY85eHx6Es1Bqc6RvjhtHurzN5h/HxwcI4oXnbAL6 j4VaMyPX38tntbZZz2wmywgvAIhHlyrupB6WneZGKMQxQ0pbnjuIBJBMOZuuNN6ImJ4j 30Ug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pJNLSiOt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id h191si6972939pgc.302.2019.02.01.06.33.52; Fri, 01 Feb 2019 06:34:08 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=pJNLSiOt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730087AbfBAOVM (ORCPT + 99 others); Fri, 1 Feb 2019 09:21:12 -0500 Received: from mail.kernel.org ([198.145.29.99]:39198 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728698AbfBAOVM (ORCPT ); Fri, 1 Feb 2019 09:21:12 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2DE92218AC; Fri, 1 Feb 2019 14:21:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1549030871; bh=bpHsJjOOPNJ5T2WGoraMt9H+X7kXTxuZ4Ojr+Xj7P4I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pJNLSiOtRa/1o73BRjxxEI0gVfjMYat0H/VTH14BPSAnNceVGC7FS2XweOeb79epp U4tsKTmK/NTgHGbti6xmRV3oFkg+T94cU280QJW3ia1GNMAOHm+jpVAEpYt5kVaGJS Y1O/+NjWz3lwiuZS9Up6wtGmbOpbjWhSxN0pEGxQ= Date: Fri, 1 Feb 2019 15:21:09 +0100 From: "gregkh@linuxfoundation.org" To: Maninder Singh Cc: "peter@hurleysoftware.com" , "jslaby@suse.com" , "keun-o.park@darkmatter.ae" , "linux-kernel@vger.kernel.org" , AMIT SAHRAWAT , Vaneet Narang , Rohit Thapliyal , Ayush Mittal Subject: Re: race between flush_to_ldisc and pty_cleanup Message-ID: <20190201142109.GA3211@kroah.com> References: <20190201133326epcms5p506416bc4ae22f600ee705f146ca1a599@epcms5p5> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190201133326epcms5p506416bc4ae22f600ee705f146ca1a599@epcms5p5> User-Agent: Mutt/1.11.2 (2019-01-07) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 01, 2019 at 07:03:26PM +0530, Maninder Singh wrote: > Hi, > > > There is some race condition between tty_port_put and flush_to_ldisc > which lead to use after free case: > (Kernel 4.1) Wait, 4.1 is _REALLY_ old and obsolete and broken in numerous known places. Can you duplicate this on 4.20, or better yet, 5.0-rc4? Lots of tty and ldisc fixes has gone into the tree in the past 3 1/2 years since that kernel was released. thanks, greg k-h