Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp585651ima;
        Fri, 1 Feb 2019 07:49:41 -0800 (PST)
X-Google-Smtp-Source: ALg8bN6vRRVuNS5EulXROF9E1vqZDGFWKMLtONl9pNoPbkJskWlfuFC6oWmW/wJr0vqdJUdfWouW
X-Received: by 2002:a17:902:bc3:: with SMTP id 61mr40324664plr.15.1549036181288;
        Fri, 01 Feb 2019 07:49:41 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1549036181; cv=none;
        d=google.com; s=arc-20160816;
        b=damv1SXUUcR5Yb4tKrbDwMcARWzaYJeLt/kR7haI5UkY0+o/cdq3ReOwvUVf0AC9vr
         WPPaKcEq6VaF9+9zxpkOLGSrCbFn/zHv/gjCqsq0lAL8JnWRlPisv+8hSbBEk+E2iyYs
         15pu0ZE5FSAtu/7jgLdZKZjkL1jjNlNTzMvGNwjnFS6FfWeaWoy3kCjClElfsHmRcJ48
         +ulETSMrGnOKYjxW2PlzAdUxPx8mlTdbIWRqy+k4QIFL/BemHktqiwt7E6pFuf2VgpVJ
         Aowfd4v01TqG94dc8hfx+N/qsopwgkYGdRSYYbAX+N607/E5SlyM45gAaswWQ2f0/2mV
         /gGA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:dkim-signature:content-transfer-encoding
         :content-language:in-reply-to:mime-version:user-agent:date
         :message-id:from:references:cc:to:subject;
        bh=SjYRayLmjrLPYjKGkL341MDkDszyHBUg+VtNsNQYVVo=;
        b=tv+63KofQG6uSUiBPafjrluRAxWuQrw2w51eA/suc8XBw3g83n0FagHRQuefcb1pcG
         vbRkv+2Y8zL6HqnfWe9QCJwI75j+XaVKoY6i69ZJ0kKD/iHEvzy2chX+U0QTzlUNU2Xp
         5GLbScRkiOszh4qd1isxwsxblJKv9LyWNCkeeXnvH/QTrrZa2t1S+q376YHV7J+6DHfo
         9SNvtOtscov0eYZIq2OettR3ge29jOwNBFcVkQcvUZH2h7OLtP8ZRIqUa0BKU93B6JKg
         xJF5nVIX15PCsqzFBv5tTeYkonhe5ahUaCuyeTx/+rin1S3vw2jMEMXVUZrpFssU4jzs
         WhFA==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=JNyp1wxJ;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id a193si1878946pfa.214.2019.02.01.07.49.26;
        Fri, 01 Feb 2019 07:49:41 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@nvidia.com header.s=n1 header.b=JNyp1wxJ;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1730264AbfBAPtX (ORCPT <rfc822;jaysonjohndmello@gmail.com>
        + 99 others); Fri, 1 Feb 2019 10:49:23 -0500
Received: from hqemgate16.nvidia.com ([216.228.121.65]:18832 "EHLO
        hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1727042AbfBAPtX (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 1 Feb 2019 10:49:23 -0500
Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA)
        id <B5c546a570000>; Fri, 01 Feb 2019 07:48:40 -0800
Received: from hqmail.nvidia.com ([172.20.161.6])
  by hqpgpgate101.nvidia.com (PGP Universal service);
  Fri, 01 Feb 2019 07:49:22 -0800
X-PGP-Universal: processed;
        by hqpgpgate101.nvidia.com on Fri, 01 Feb 2019 07:49:22 -0800
Received: from [10.19.108.132] (172.20.13.39) by HQMAIL101.nvidia.com
 (172.20.187.10) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Fri, 1 Feb
 2019 15:49:19 +0000
Subject: Re: [PATCH V5 2/7] clocksource: tegra: add Tegra210 timer support
To:     Jon Hunter <jonathanh@nvidia.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Thomas Gleixner <tglx@linutronix.de>
CC:     <linux-tegra@vger.kernel.org>,
        <linux-arm-kernel@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, Thierry Reding <treding@nvidia.com>
References: <20190201033621.16814-1-josephl@nvidia.com>
 <20190201033621.16814-3-josephl@nvidia.com>
 <5490ad66-7d20-7093-7025-1d0ec8da6dec@nvidia.com>
 <3c9b86ba-32dd-76b2-9a51-6cd86782cadf@nvidia.com>
 <ab418999-a45c-bd9c-b9bd-5c382e86d26c@nvidia.com>
From:   Joseph Lo <josephl@nvidia.com>
Message-ID: <c33697d8-43a9-654b-503f-e60adbaf289f@nvidia.com>
Date:   Fri, 1 Feb 2019 23:49:17 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <ab418999-a45c-bd9c-b9bd-5c382e86d26c@nvidia.com>
X-Originating-IP: [172.20.13.39]
X-ClientProxiedBy: HQMAIL103.nvidia.com (172.20.187.11) To
 HQMAIL101.nvidia.com (172.20.187.10)
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1549036120; bh=SjYRayLmjrLPYjKGkL341MDkDszyHBUg+VtNsNQYVVo=;
        h=X-PGP-Universal:Subject:To:CC:References:From:Message-ID:Date:
         User-Agent:MIME-Version:In-Reply-To:X-Originating-IP:
         X-ClientProxiedBy:Content-Type:Content-Language:
         Content-Transfer-Encoding;
        b=JNyp1wxJjHcmyWe3emHSjH45gGMqadlrbAcut4/I+bls7QHSL8QCCHHKIuX+EcvIY
         EaFlofhk5zpiK0ycQFWDLErUqOCJkzBPPritwCyBjLcEmiri/weLMViHo68hWSoiaQ
         ZmIjcFkPkLgxbnKyygOcqDbiEHj3qwQM7gpESCNl5kcPKHeIjLkYXEc5+A7126B4P/
         +Xwg5k0K2vvZcPpFvnhC00z7ZhZ6KW1ZRzhJDyUXuddw0c6kaKKGa9nlVCCSxGKGmy
         YaBsWSyMX7OsXsxY+l+vEISR7G5c3eV8slVLsyV4P4jxNdDBPry8elYpGR2cJZOPO2
         KKOFJ3AivOKsg==
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 2/1/19 11:43 PM, Jon Hunter wrote:
> 
> 
> On 01/02/2019 14:39, Joseph Lo wrote:
>> On 2/1/19 8:44 PM, Jon Hunter wrote:
>>>
>>> On 01/02/2019 03:36, Joseph Lo wrote:
>>>> Add support for the Tegra210 timer that runs at oscillator clock
>>>> (TMR10-TMR13). We need these timers to work as clock event device and to
>>>> replace the ARMv8 architected timer due to it can't survive across the
>>>> power cycle of the CPU core or CPUPORESET signal. So it can't be a
>>>> wake-up
>>>> source when CPU suspends in power down state.
>>>>
>>>> Also convert the original driver to use timer-of API.
>>>
>>> It may have been nice to split this into 2 patches to make it easier to
>>> see what is going on but not a big deal.
>>>
>>>> Cc: Daniel Lezcano <daniel.lezcano@linaro.org>
>>>> Cc: Thomas Gleixner <tglx@linutronix.de>
>>>> Cc: linux-kernel@vger.kernel.org
>>>> Signed-off-by: Joseph Lo <josephl@nvidia.com>
>>>> Acked-by: Thierry Reding <treding@nvidia.com>
>>>> ---
snip.
>>>
>> This can't get the timer base address. I think you mean ...
>>
>> +#ifdef CONFIG_ARM
>> +#define TIMER_CPU0 0x50 /* TIMER3 */
>> +#else
>> +#define TIMER_CPU0 0x90 /* TIMER10 */
>> +#endif
>> +#define TIMER_BASE_FOR_CPU(cpu) (TIMER_CPU0 + (cpu) * 8)
> 
> Ah I see.
> 
>> This doesn't need.
>> +#define TIMER_FOR_CPU(cpu) (TIMER_CPU0 + cpu)
> How come? Don't you still need to know the timer index for a given CPU?
> 

Doesn't need. TIMER_BASE_FOR_CPU is enough. Other use cases are well 
handled by timer-of API. :)

Thanks,
Joseph