Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Loic PALLARDY <loic.pallardy@st.com>
To:     YueHaibing <yuehaibing@huawei.com>,
        "ohad@wizery.com" <ohad@wizery.com>,
        "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-remoteproc@vger.kernel.org" <linux-remoteproc@vger.kernel.org>
Subject: RE: [PATCH -next] remoteproc: make rproc_check_carveout_da static
Thread-Topic: [PATCH -next] remoteproc: make rproc_check_carveout_da static
Thread-Index: AQHUudxGKL1acz/0tEqjRTyTD6T3sKXLGQjw
Date:   Fri, 1 Feb 2019 15:56:13 +0000
Message-ID: <519ceef457d744e98659a2c7aa6fdd4d@SFHDAG7NODE2.st.com>
References: <20190201031317.18820-1-yuehaibing@huawei.com>
In-Reply-To: <20190201031317.18820-1-yuehaibing@huawei.com>
Accept-Language: fr-FR, en-US
Content-Language: en-US
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Yue,

> -----Original Message-----
> From: linux-remoteproc-owner@vger.kernel.org <linux-remoteproc-
> owner@vger.kernel.org> On Behalf Of YueHaibing
> Sent: vendredi 1 f?vrier 2019 04:13
> To: ohad@wizery.com; bjorn.andersson@linaro.org
> Cc: linux-kernel@vger.kernel.org; linux-remoteproc@vger.kernel.org;
> YueHaibing <yuehaibing@huawei.com>
> Subject: [PATCH -next] remoteproc: make rproc_check_carveout_da static
> 
> Fixes the following sparse warnings:
> 
> drivers/remoteproc/remoteproc_core.c:279:5: warning:
>  symbol 'rproc_check_carveout_da' was not declared. Should it be static?
Correction already sent on ML few weeks ago. See [1]

Regards,
Loic

[1] https://patchwork.kernel.org/patch/10755763/

> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/remoteproc/remoteproc_core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/remoteproc/remoteproc_core.c
> b/drivers/remoteproc/remoteproc_core.c
> index 54ec38f..5d4954d 100644
> --- a/drivers/remoteproc/remoteproc_core.c
> +++ b/drivers/remoteproc/remoteproc_core.c
> @@ -276,8 +276,9 @@ rproc_find_carveout_by_name(struct rproc *rproc,
> const char *name, ...)
>   *
>   * Return: 0 if carveout match request else -ENOMEM
>   */
> -int rproc_check_carveout_da(struct rproc *rproc, struct rproc_mem_entry
> *mem,
> -			    u32 da, u32 len)
> +static int rproc_check_carveout_da(struct rproc *rproc,
> +				   struct rproc_mem_entry *mem,
> +				   u32 da, u32 len)
>  {
>  	struct device *dev = &rproc->dev;
>  	int delta = 0;
> --
> 2.7.0
>