Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp611381ima; Fri, 1 Feb 2019 08:11:57 -0800 (PST) X-Google-Smtp-Source: AHgI3IYH0O0OMJx4WlziLwoWCytLQSSr/fJ+0jbMgMMdea681uFJsYq6dnstbTk/pW9NlWFkkq5c X-Received: by 2002:a63:82c6:: with SMTP id w189mr2871829pgd.344.1549037517168; Fri, 01 Feb 2019 08:11:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549037517; cv=none; d=google.com; s=arc-20160816; b=iGobZE+GNW6nR1nsTMLDtmuSHSjfI4uIKA0XK/uA+5KAG31X/f/k+ZsqEfjVrfKWBc vruIc4vtMHsiph6Yo+FOJfs2YY7g5KnOxvv0TTFbrh4cqqpZMxUncIpB6KGcduEXLI1N nDR2UFre08Htk3Et9pHT9+hoiHOLzRdBk61L2PPBkktPg8yS/7Bnhp7Dohsliz8KVcpl oy7zPgDRshjNn5cngF1/hvJq4/j4bJfxWEuMrTKypA5ovkc4tDKnxHsIIkioFZFKch+H K4hKyVq/8ADoWuCuZSIPBrH7JstzL3NFqeWXpfd5JItEaO6V+TMzzHT05oUzlhwX+x5N iYSA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=luNUmGeRoYayeZgItGVjIykLA8swZ+Y3DJI5F3Xrcvo=; b=Qhn81MJldGMkS71+oJEh/A9F1Ni4GJPgTOidOrPtp8taEOwmjPg4woyqcpjnsLdE9A +eEPpq5m2/qPtYPuVXNPRViASXzM9FmFPS/I2ajk3WId7IbLy0ixVjXLHsz4A+RWPMFz mWCnImcJRBT34GUEiKKcpl9hi+sKlbQbTaMz7gAipD2WUZr26rm3bRZTzuQzNv2hxMqZ 6rNFWjPeEUydHeGsDmkiDm4pz+csVPxEqoscj3xiwvKvncfKy+P6d/mBDnAOcFBPm2gs 3thBtImgJDTKOLaaA9af8sEe0uDRmgwxOI4cZ7oQpxgbRka5J+LF10M+1S7cOVX5pHH2 KS9Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s2si7603191pgr.285.2019.02.01.08.11.41; Fri, 01 Feb 2019 08:11:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730602AbfBAQKA (ORCPT + 99 others); Fri, 1 Feb 2019 11:10:00 -0500 Received: from verein.lst.de ([213.95.11.211]:35628 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726172AbfBAQJ7 (ORCPT ); Fri, 1 Feb 2019 11:09:59 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id 2C19A68D93; Fri, 1 Feb 2019 17:09:57 +0100 (CET) Date: Fri, 1 Feb 2019 17:09:57 +0100 From: Christoph Hellwig To: Takashi Iwai Cc: Christoph Hellwig , John Crispin , Vinod Koul , Dmitry Tarnyagin , Nicolas Ferre , Sudip Mukherjee , Felipe Balbi , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, iommu@lists.linux-foundation.org Subject: Re: [alsa-devel] don't pass a NULL struct device to DMA API functions Message-ID: <20190201160957.GD6532@lst.de> References: <20190201084801.10983-1-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 01, 2019 at 02:16:08PM +0100, Takashi Iwai wrote: > Actually there are a bunch of ISA sound drivers that still call > allocators with NULL device. > > The patch below should address it, although it's only compile-tested. Oh, I missed these "indirect" calls. This looks good to me: Reviewed-by: Christoph Hellwig