Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp613644ima; Fri, 1 Feb 2019 08:13:46 -0800 (PST) X-Google-Smtp-Source: ALg8bN5vVCtpJSBeccZHZczWPrkDi/8VkyaAdmITsAxP26ckkaw7vbM+9/ft0n1gXC1bc/eBZnGN X-Received: by 2002:a17:902:968d:: with SMTP id n13mr40880705plp.109.1549037626295; Fri, 01 Feb 2019 08:13:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549037626; cv=none; d=google.com; s=arc-20160816; b=jAol/oQqIhnbZCh0QMb3dOJK6mWCFHoOCkKrrj6lAXDlsfG51w+fPHu/BSN2f1AgAt sH4fqlYDRlYFaoxC0fd5rqcbr5gddtH2cgtZJstKrvEwT6SPFk+8kQf1z6MYPgvW2GNX 0ZEUdN+tJ/jiKhAPr23nGhdreospimIIvat2AFe2Y0BCcHJnKm+mOiK5Z3wIa36vyVdH GQ62g/EXCWfOGTs5nfDpaxmPq8seDnKapzj0TJitq5cndjuCAxsArfEuNLk6VfQQ7DWY Re3+kMQwW+JjtZkuhLxRwajlNdwHlDIJtsS2JxopXpXryd0497x71nz+vFmWIuIx1ysh OzmA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=lsMRQa3s6Id+XtvpJr+3rytxgvyhA6MZvPpFaHQkMxU=; b=pv3K8DUs67yNGmjm/rZ2yfsHQGOd4vI4OEjxlEcVx5/KTU/9GZ7g9FuRuvyCW1lksx BJKLdHd++93hPnnjbQLTMlL7yddgQ3JvUeiHW1D/fwmhiXpzVhS8mcVhxYKGAnVh6aVC QwDyCs7G7t8XmV9Ofyo8uAvQ22S3X6hsFKAY9pKIKZ6EDbSIcadlVP+qzFJeNsS+cbLc jBWSOBX/SBxQqMWSQlF9YhEPZjZcTUQj19zR+ckbFn5wFfPuQhTIoHmJkKAq/XLJkQ5v k5cIKvdrdwM+KZD8jJ+8L0fD5Sg2P99bAdDX4b7Ovc8T37VA+IeHanBVXD9/4opbiTDi k6NQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m4si7510772pgk.399.2019.02.01.08.13.30; Fri, 01 Feb 2019 08:13:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730730AbfBAQLT (ORCPT + 99 others); Fri, 1 Feb 2019 11:11:19 -0500 Received: from verein.lst.de ([213.95.11.211]:35660 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726172AbfBAQLT (ORCPT ); Fri, 1 Feb 2019 11:11:19 -0500 Received: by newverein.lst.de (Postfix, from userid 2407) id CBC2E68D93; Fri, 1 Feb 2019 17:11:16 +0100 (CET) Date: Fri, 1 Feb 2019 17:11:16 +0100 From: Christoph Hellwig To: Robin Murphy Cc: Christoph Hellwig , John Crispin , Vinod Koul , Dmitry Tarnyagin , Nicolas Ferre , Sudip Mukherjee , Felipe Balbi , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, dmaengine@vger.kernel.org, netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, alsa-devel@alsa-project.org, iommu@lists.linux-foundation.org Subject: Re: [PATCH 10/18] smc911x: pass struct device to DMA API functions Message-ID: <20190201161116.GG6532@lst.de> References: <20190201084801.10983-1-hch@lst.de> <20190201084801.10983-11-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 01, 2019 at 02:14:34PM +0000, Robin Murphy wrote: > And equivalently for rxdma here. However, given that this all seems only > relevant to antique ARCH_PXA platforms which are presumably managing to > work as-is, it's probably not worth tinkering too much. I'd just stick a > note in the commit message that we're still only making these > self-consistent with the existing dma_map_single() calls rather than > necessarily correct. Sounds good.