Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp637071ima; Fri, 1 Feb 2019 08:34:51 -0800 (PST) X-Google-Smtp-Source: AHgI3IavtuYlLtNSYt0+sAzdAAG/vGW5pvur+GYclau3l1MuekYHgiTMS3PkGnP+dYzc2ka87HSB X-Received: by 2002:a63:8441:: with SMTP id k62mr2900595pgd.392.1549038891392; Fri, 01 Feb 2019 08:34:51 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549038891; cv=none; d=google.com; s=arc-20160816; b=QgpicywuFVHXMvt6EfTNp6FnR+ybS7jtFhL1FN/V6HmHdeZ/KHi5nx4alHygD78CEA FYKkq/yLS7E3+vDpiMXRKm/u5uJoQEUbYdA+UrVy6wIEBP1b84+FCNWFy3w8HtEerYOS 8l6GEY6KcxPmuSpR7sVac4Y3somVccW884955jxKdwH6PiX1vlTmzdNCHbCHrn5TFIhQ LOIJIsajOpXw8MBYXw1oXlbqQunYGxCtxdFl+kNjtj/jmCmSD/LMeQhLybFLLOQGhEGI P3D8U2vqlFk0oPagq+Oa4SLNnKa2hpdU8RZFy1sogi2YZ/9qiEr8R86PXMNOfufYwBXY klZw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=G/sYti/hkE2aFx0xhI7FOoqbw4yUsK5YVlcCNjpJaXk=; b=xu6srNPT2WuqWzG0U/0U51X0x1BpzLNUSwsC/5Zf5D/6KMDlXfB5DeYbhZio+z7ztr JIy49CIdVSBdXj6NPm/aQhWhWz8emZXwT64naAZhGs35TUmu174vlny/Yemk0/Hf1qZB LB1RDSYxDqZkrgfz4gXlvYKu6Lx9jzBEpFK+PNIJTIMdZ21fmH07NXtei/JdGet5EURP /l8cg1h4S4UhqBL6bUe/B8ErcHh50JIBUX52gLNyYsu+moTfORHlpwgzksKSdkK7IvE5 hERLUhrEdlG6kwKASEeKah3KT5XtsXLCgqv+YIhcjCQIUkFohCfcsSVMjsafYj/q2e/7 BOIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id p186si3380893pgp.37.2019.02.01.08.34.34; Fri, 01 Feb 2019 08:34:51 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730240AbfBAQeM (ORCPT + 99 others); Fri, 1 Feb 2019 11:34:12 -0500 Received: from lhrrgout.huawei.com ([185.176.76.210]:32856 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727057AbfBAQeL (ORCPT ); Fri, 1 Feb 2019 11:34:11 -0500 Received: from lhreml709-cah.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id 24E9E7295E4DD4C1BD35; Fri, 1 Feb 2019 16:34:10 +0000 (GMT) Received: from [127.0.0.1] (10.202.226.46) by lhreml709-cah.china.huawei.com (10.201.108.32) with Microsoft SMTP Server id 14.3.408.0; Fri, 1 Feb 2019 16:34:07 +0000 Subject: Re: [PATCH v2] arm64: dts: hikey: Give wifi some time after power-on To: Jan Kiszka , Linux Kernel Mailing List , linux-arm-kernel CC: Ryan Grachek , John Stultz , , "Reizer, Eyal" , "Valentin Schneider" , Ulf Hansson , Kalle Valo , Tony Lindgren References: From: Wei Xu Message-ID: <14a011aa-862f-7132-8741-df5173875f34@hisilicon.com> Date: Fri, 1 Feb 2019 16:34:07 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.46] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jan, On 1/24/2019 7:52 AM, Jan Kiszka wrote: > From: Jan Kiszka > > Somewhere along recent changes to power control of the wl1835, power-on > became very unreliable on the hikey, failing like this: > > wl1271_sdio: probe of mmc2:0001:1 failed with error -16 > wl1271_sdio: probe of mmc2:0001:2 failed with error -16 > > After playing with some dt parameters and comparing to other users of > this chip, it turned out we need some power-on delay to make things > stable again. In contrast to those other users which define 200 ms, the > hikey would already be happy with 1 ms. Still, we use the safer 10 ms, > like on the Ultra96. > > Fixes: ea452678734e ("arm64: dts: hikey: Fix WiFi support") > Signed-off-by: Jan Kiszka > Acked-by: Ulf Hansson Applied to the hisilicon soc dt tree. Thanks! Best Regards, Wei > --- > > Changes in v2: > - set delay to 10 ms > - updated changelog > > Who will take care of updating also the Hikey firmware dts with this > change? > > arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > index 610235028cc7..ba946543dd0a 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > +++ b/arch/arm64/boot/dts/hisilicon/hi6220-hikey.dts > @@ -118,6 +118,7 @@ > reset-gpios = <&gpio0 5 GPIO_ACTIVE_LOW>; > clocks = <&pmic>; > clock-names = "ext_clock"; > + post-power-on-delay-ms = <10>; > power-off-delay-us = <10>; > }; > > -- > 2.16.4 > > . >