Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp719763ima; Fri, 1 Feb 2019 09:55:43 -0800 (PST) X-Google-Smtp-Source: ALg8bN7v0bnIW099Awzpni7xwp1P4JrfqPPVe3HKWgknMWS1WDpLBuItfa5198b3D00MhtmQZAeQ X-Received: by 2002:a17:902:a411:: with SMTP id p17mr40018529plq.292.1549043743454; Fri, 01 Feb 2019 09:55:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549043743; cv=none; d=google.com; s=arc-20160816; b=jm6Kr4XwZPNA6Dvn5yLDty2kxjgtdpsNZXt3/Cf5zVvYozizTmfRFc1j411D/RuIaS nKf/qCOH+aIqzgPIJhZqsmz+8LwUf+LBmK0zC0+YMRzyw3eaHOQwOlsmE4JtB+V/meMB s0U8vUTCuyazJDXP9H/dh0IXns2Ot8kPLgpIFj5hRDIhPbgtCGyg6iUKpac5H7z7UTHY sOCu/a2SKOdbOQvjF/ofohpDWkhSNNcNXRI5YIgKf2e6Ev8zUzd6W2uSfwk8M2mLmGgz /LKPAPtEPXjWGIRuMw2/5jKE6ezB66OSCUXg4xzAS3Nyv4O6/udtDl5QJV98UgcFOfSX qS8g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:to:subject; bh=dln2Ney3jh9u2pFXvDSS1Hrxu9lXSi1+P0+LDxhCtGs=; b=ZHGCUH8wtbiiIJHA6pWOmSCzc/rqjZSxiLb0fr3svVyOO6euYfdt0rvF5vYxyr7amZ eCNmbEOCcRJwxkjPWeee/n2Xapy9bmiVsuN7nuaLqsNUelfPAvjS3Uckr9WEOB8crldO j507bO1LIDTesN6X5lo7XxRYw/mYRoiXSNszPkXZWwLfTJ4+88eiTRHMsz/7qJNqKqHl dvZMIpZ0e4EQkObpxT724pMBXO3TZX4FZYSI3Rhqiqv+H6XEWNuKdNjjIn9Z7azVI4Pn Am+Uf10NxpzGjGyPoEzm+W+5Q3LEhgJnzFut8G8Wsp4P6k2ZCOa8DXLWzmwVMZ34wkWJ 6rKg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t10si5016521pfi.75.2019.02.01.09.55.28; Fri, 01 Feb 2019 09:55:43 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730539AbfBARAY (ORCPT + 99 others); Fri, 1 Feb 2019 12:00:24 -0500 Received: from lhrrgout.huawei.com ([185.176.76.210]:32860 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1728892AbfBARAY (ORCPT ); Fri, 1 Feb 2019 12:00:24 -0500 Received: from lhreml709-cah.china.huawei.com (unknown [172.18.7.108]) by Forcepoint Email with ESMTP id C64D34F342B631B14FBD; Fri, 1 Feb 2019 17:00:22 +0000 (GMT) Received: from [127.0.0.1] (10.202.226.46) by lhreml709-cah.china.huawei.com (10.201.108.32) with Microsoft SMTP Server id 14.3.408.0; Fri, 1 Feb 2019 17:00:20 +0000 Subject: Re: [PATCH v2] arm64/hisilicon: fix SDcard detection To: Vincent Guittot , , , , , , References: <1547454274-1674-1-git-send-email-vincent.guittot@linaro.org> From: Wei Xu Message-ID: <3722223a-4f06-3e1c-86ca-542289c7c918@hisilicon.com> Date: Fri, 1 Feb 2019 17:00:18 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <1547454274-1674-1-git-send-email-vincent.guittot@linaro.org> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.226.46] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Vincent, On 1/14/2019 8:24 AM, Vincent Guittot wrote: > The SDcard detection of hikey960 is active low so cd-inverted is wrong. > Instead of adding cd-inverted, we should better set correctly cd-gpios > to use GPIO_ACTIVE_LOW. > > Signed-off-by: Vincent Guittot Updated the subject as Leo suggested and applied to the hisilicon tree. Thanks! Best Regards, Wei > --- > > SD card detection was not working on v5.0-rc1 but patch > https://marc.info/?l=linux-mmc&m=154637189021211&w=2 makes it work. > Nevertheles, latest changes in of_mmc_detection makes possible to have > a correct DT config. > > arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts > index 71bfe41..dc314e7 100644 > --- a/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts > +++ b/arch/arm64/boot/dts/hisilicon/hi3660-hikey960.dts > @@ -665,8 +665,7 @@ > sd-uhs-sdr50; > sd-uhs-sdr104; > disable-wp; > - cd-inverted; > - cd-gpios = <&gpio25 3 0>; > + cd-gpios = <&gpio25 3 GPIO_ACTIVE_LOW>; > pinctrl-names = "default"; > pinctrl-0 = <&sd_pmx_func > &sd_clk_cfg_func >