Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp720094ima; Fri, 1 Feb 2019 09:56:05 -0800 (PST) X-Google-Smtp-Source: ALg8bN42z9u6aa1O3I+agKFa0ZGuYumuOpVvvBG1EHwtYBECWELFKzVSwoKUqT/aXkmTIxfe3BbE X-Received: by 2002:a62:d005:: with SMTP id p5mr40429573pfg.175.1549043765604; Fri, 01 Feb 2019 09:56:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549043765; cv=none; d=google.com; s=arc-20160816; b=J2NjlwLlJJFjrRN9hbzbDGKhBzQogO4EScWLwB+Co8AIPIAb6A0Sop3PVtMbsj2DcH MIEOaonZ3Q98Q8v2ocUqsX2GQf8wWpyWSRUgunprEJgFW/Ak/hZPncrgVMN5HbRHOfYj BYyQ05FD/xZ/6dwMYnCEcDaUS7RzEMGPC/r844tCghZni1PTHQgD3lGiWI6AtzowDB+I WacSoyEhU6hfG7KUuBfQuW5x4ZS9hMA/ar0Dvx1whLowa4jKEGvNo24Rm2iUDMjs75I9 gv/g3gCBXhMewponDeIFCn+BmjH7hcJUoGvd8mxLqAemC88Hiol9ZLydczEIWMJdTCSH kPTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=MYRYTmO2UKtncXFMnEATIgRImHRBJ+EzhMAFeOQJz9Y=; b=FVVIPd+Ku5Uvt2am0TJEY2TLQj2XR4JgKAJgwKZkI0qgAK6lTPueaFe2t3uXcXgTSo gH55kdK2H5wMZoMpsvxdve4z5xs9XU+ntw2Pxor8B/V+TcxYmNhmdDy7cgBYs4BGZ3pQ Ds3w0mBIVX9kFAxhZRxNSvqP53ui1z1avtBX0RsRmjq3O/wsthV4dc2IcAxc1GRVkGTS YMqUROvZQtrQRLcY8iI/kBG9TVVcpm9AfuYhHZNxlpeP3SrfhgMJYBPYQ+gd2n7j/8gm LN3039bH3wbOKjxZC3ldd3ORiQa8F+1BHnlAGVaKfBBgNaooIq5cS/oB3s83tfCcBA8H XROA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="oYnCYR/I"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d127si716459pfg.255.2019.02.01.09.55.50; Fri, 01 Feb 2019 09:56:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b="oYnCYR/I"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730635AbfBARBD (ORCPT + 99 others); Fri, 1 Feb 2019 12:01:03 -0500 Received: from mail-it1-f174.google.com ([209.85.166.174]:38752 "EHLO mail-it1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728770AbfBARBD (ORCPT ); Fri, 1 Feb 2019 12:01:03 -0500 Received: by mail-it1-f174.google.com with SMTP id z20so10755693itc.3 for ; Fri, 01 Feb 2019 09:01:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=MYRYTmO2UKtncXFMnEATIgRImHRBJ+EzhMAFeOQJz9Y=; b=oYnCYR/ItAR0ZqLzgMaSZ1x9ZDRu5sii9v7bSfxsUtNxQ+2TPV545rwr+8xA9UMpdi FcX7gVY4V2u7zXHNyROv8AMsY79gbkaSEtx+D4lKC/l6bW5k64rv7o16rBIF4vgzIzK5 b5oabX//1hGpY8CoaxHkUTeSN8ptQqYbXUeIQ9eYjjnIzCcLep3ulITSxx+hzvC6avQD +Au8BYEE49v92zhP4ASPKlLLpdbKdnp4EerLyPtRGV+lv07qw9eLkC16s07OedoM0TTz RtTSEv5e+pZiFFQbNz2Aw9s/NDG87EqWcXW7H04jp25vNWO59Hd9WN7dRC8QDONtwFA/ zdSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=MYRYTmO2UKtncXFMnEATIgRImHRBJ+EzhMAFeOQJz9Y=; b=n+WoJghlXuZQLYcmcmVVs0DeK+rILDqT3U6XY5SV/Im8Dgd5XfM3YTsd83iZiPWbH+ 7WreOPxrJoRbo12ta0OlRgVk0XXYNdkFSXhaGVDbHEiBj0chDGMl27JMMiWn4xe+GRin DQeqCKb4neXwiKF2fPWE3TfwLQ5Pcf1rSiamIBzR46zzqjo991YXEG8pzmlz4jWkJcfp YU3H88HEGiqnKs6w1/k0wVsr1pc809DJzTWQxZ6+8WLqHMIaQJ+OVAAtjlKHdqVCRitL 0ADQaVzhA+WD9QzhqVIHFTCA/e6ozi4SvWVwu4z2paW664GTz9E1RHPwcdc2EfYOIOUU Cz6w== X-Gm-Message-State: AJcUukesIe/kh3juh3YohBxIXHhyAeDLbR0NEyiv+K0YP6pAbS2XiuOM Agblut6KfzyKjumcaWnE0X/A5qYy08jzZ23ibrzqZQ== X-Received: by 2002:a02:8ca8:: with SMTP id f37mr26504109jak.80.1549040461749; Fri, 01 Feb 2019 09:01:01 -0800 (PST) MIME-Version: 1.0 References: <20190131192533.34130-1-thgarnie@chromium.org> <20190131192533.34130-16-thgarnie@chromium.org> <20190201071259.GB14343@kadam> In-Reply-To: <20190201071259.GB14343@kadam> From: Thomas Garnier Date: Fri, 1 Feb 2019 09:00:50 -0800 Message-ID: Subject: Re: [PATCH v6 15/27] compiler: Option to default to hidden symbols To: Dan Carpenter Cc: Thomas Garnier , Kernel Hardening , kristen@linux.intel.com, Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "the arch/x86 maintainers" , Luis Chamberlain , Greg Kroah-Hartman , "Rafael J. Wysocki" , Arnd Bergmann , Luc Van Oostenryck , Steven Rostedt , Jason Baron , Jordan Borgner , Masami Hiramatsu , Masahiro Yamada , "Peter Zijlstra (Intel)" , Andrew Morton , Kees Cook , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Andi Kleen , Jan Beulich , Song Liu , Adrian Hunter , Alexander Shishkin , LKML , linux-arch , Sparse Mailing-list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 31, 2019 at 11:13 PM Dan Carpenter wrote: > > On Thu, Jan 31, 2019 at 11:24:22AM -0800, Thomas Garnier wrote: > > Provide an option to default visibility to hidden except for key > > symbols. > > It took me a while to figure out the verb in this sentence... :P I agree, I should rewrite this description. > > It's weird that we're annotating things to be default. What visibility > are they we leave off the annotation? The word "default" is confusing but that's how it is called by gcc. Symbols not marked default are hidden. > > regards, > dan carpenter > -- Thomas