Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp732015ima; Fri, 1 Feb 2019 10:06:25 -0800 (PST) X-Google-Smtp-Source: ALg8bN7tQZhJJjNT2z7AEQrZqZS51baw0lzvyj40HyDGChfO4ipOalZro5oIn4VtOjTO9Bx8be7n X-Received: by 2002:a17:902:9887:: with SMTP id s7mr39524349plp.199.1549044385505; Fri, 01 Feb 2019 10:06:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549044385; cv=none; d=google.com; s=arc-20160816; b=gRNFtM+ZJN1Tc5yTJHH9gwBnAPAsw4PLE4Zyw3a5SE46qSY6+zYAXX39aC4WzBnxT5 lOJ6g6DUv57cmSmZP2jteGXMOAZ4GTuEW/BfjtPqqTCjhY5QWbqf6xHkqDieRR0+QxS9 1JkIdv7Y9APPe1fhkn1CJhEh3dpWgdU5Nb/Vyq9EutfmJZWy35FjbNeXif/Y5ntOMEUh GC/xPRW1zDEV41oXC3vRRt2axGF5x/l9L0OXBTn3jg8TyhIZerPZzxKVh/yHVhuiGnqX Np/S3vM7d0KoJD2bk2bcM2S0k3SuOO/b+z29pdo/qe8j+jmGuN0JYrqgkmtW4TgClLNy 3/sw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=KPxhkKSFTrQVDEuNWhSmOlsJkAEMhBwsefiC8VaoHiM=; b=SLym4Ixf8fbVPOP55B5doc+wMVLZgbC84NYaLdQgIlBjtqGietyg7AUrSFMTGEkvZg eRooubuJPIYadU2PjGylkZrRGFX+90h7EQfaJhKcXy798qYHhbstp33LG60w/lcEiBfE 8YDs5GAo0B58GBoa4zFY6avlO3+g2haObvSMgqYC2s0LAjcLvLprNCRvrZ9yctuCsWMx HZUe8ZK9d7TvBodgiUZeYLNhOREwN503/QYGJcC2bvgJHhwLo029OLe/I07wztWxPFaz HNEdNRGXuNrKQ4ZmqtfP1MyByOZJkvfGD+R0hSiaDiykHwDC7UKfvUFBdnuTKnA1zdFE KFsg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s19si7989986plp.151.2019.02.01.10.06.09; Fri, 01 Feb 2019 10:06:25 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731283AbfBARdi (ORCPT + 99 others); Fri, 1 Feb 2019 12:33:38 -0500 Received: from mga18.intel.com ([134.134.136.126]:40504 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729417AbfBARdh (ORCPT ); Fri, 1 Feb 2019 12:33:37 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2019 09:33:36 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,549,1539673200"; d="scan'208";a="112973185" Received: from gandrejc-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.254.151]) by orsmga006.jf.intel.com with ESMTP; 01 Feb 2019 09:33:31 -0800 Date: Fri, 1 Feb 2019 19:33:30 +0200 From: Jarkko Sakkinen To: Mimi Zohar , christophe.ricard@gmail.com Cc: Roberto Sassu , david.safford@ge.com, monty.wiseman@ge.com, matthewgarrett@google.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com Subject: Re: [PATCH v9 6/6] tpm: pass an array of tpm_extend_digest structures to tpm_pcr_extend() Message-ID: <20190201173330.GA5522@linux.intel.com> References: <20190201100641.26936-1-roberto.sassu@huawei.com> <20190201100641.26936-7-roberto.sassu@huawei.com> <20190201133949.GE17861@linux.intel.com> <20190201134151.GF17861@linux.intel.com> <1549031589.6993.7.camel@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1549031589.6993.7.camel@linux.ibm.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 01, 2019 at 09:33:09AM -0500, Mimi Zohar wrote: > Thanks! I just finished compiling, rebooting, and verifying the IMA > boot-aggregate matches. > > While compiling, I saw some messages that "TPM_BUFSIZE is redefined" > for tpm_i2c_infineon, tpm_i2c_nuvoton, and st33zp24. ?Didn't look to > see if this is a result of this patch set or not. > > The IMA boot-aggregate matches the PCRs. > > Tested-by: Mimi Zohar (on x86 for TPM 1.2 & PTT > TPM 2.0) Thank you. I found the reason for that warning. It is redefined, for reason unknown to me in drivers/char/tpm/st33zp24/st33zp24.h (commit bf38b8710892). I'll post a fix to that commit ASAP. After that commit has been applied I can apply Roberto's patches. /Jarkko