Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp739667ima; Fri, 1 Feb 2019 10:12:57 -0800 (PST) X-Google-Smtp-Source: AHgI3IamXgdleym3CqAQReCYp1v+EYMqxz2jwI9tQaauklbcQlj0LXNg6zH99pjO3XoYvo8tbUas X-Received: by 2002:a17:902:403:: with SMTP id 3mr254722ple.3.1549044777602; Fri, 01 Feb 2019 10:12:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549044777; cv=none; d=google.com; s=arc-20160816; b=F05rHpaTcvMYzTsdXeOq9eMfZPttZAQbwgNWfgrZXDBg0QBw4QQR9BHwBqzB0I11WE JPpwo/qEj53r9GOHpCXwAlcny4QuFXdXpiDT/PHS31JIMQgzpPvZwky5T+atIImbHPtR LU82HPUGTwp/KaM5cG5iV8ZKhGHjHINCMN4/kR0Tyw52Jwgy42sEX5R4Vyz3NTa2omnT o3Pyj/v8Xap+aX63lR2SwI6M3YziIWeBLN84CT+vvDK1/TIsoukCDBjbmUB1VNdFSpOA eFTAOwaInuw1Jm7UOKT9feQbiIBv0jwpetLVP9MFNvPUR+ul2H8DDpFsLZBKB1+wEoKJ 50Zg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=OaHc6rXbOnox28oB5iiXsFbvj9k3O9Y22TEAeY064RA=; b=u6Wqbqnyzp2Kc7oOS5uy8MCnnMp94ukQB/HYjCTpCjQJugQ1FezaeJQiL6Y3Rpdnk6 j9DYh/Fn+aKju+eNKfX4d0czkcoKSG9JqM6ffCmVMxTTEv4HwzDS14HPw+fU0i3hNomM UsnrAEbwIJDZMZj1RHE89xikMx7aN+LlXvhmnOimzazNgq6AadNDcCcPzgaZBzVMiFMU cXdqJwYsxo6g6ci4eQ3ESO+SARW1lE90DwK0p0zog7PxZzXLdOSH83iNWHijAiuvx/Lp +NiAzq7R1POiwR/Yh+dpyY8vdc1wPO3JYUrnISNBSWkbCvLP0um0Pa/lT9qPbwcCMH/2 +WSA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v32si1046264plb.369.2019.02.01.10.12.42; Fri, 01 Feb 2019 10:12:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731445AbfBARl2 (ORCPT + 99 others); Fri, 1 Feb 2019 12:41:28 -0500 Received: from mga18.intel.com ([134.134.136.126]:41232 "EHLO mga18.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726588AbfBARl2 (ORCPT ); Fri, 1 Feb 2019 12:41:28 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2019 09:41:27 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,549,1539673200"; d="scan'208";a="315573012" Received: from gandrejc-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.254.151]) by fmsmga006.fm.intel.com with ESMTP; 01 Feb 2019 09:41:23 -0800 From: Jarkko Sakkinen To: linux-integrity@vger.kernel.org Cc: linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org, roberto.sassu@huawei.com, zohar@linux.ibm.com, Jarkko Sakkinen , stable@vger.kernel.org Subject: [PATCH] tpm/st33zp24: Fix name collision with TPM_BUFSIZE Date: Fri, 1 Feb 2019 19:41:17 +0200 Message-Id: <20190201174117.23440-1-jarkko.sakkinen@linux.intel.com> X-Mailer: git-send-email 2.19.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Rename TPM_BUFSIZE defined in drivers/char/tpm/st33zp24/st33zp24.h to ST33ZP24_BUFSIZE as it collides with TPM_BUFSIZE defined in drivers/char/tpm/tpm.h. Cc: stable@vger.kernel.org Fixes: bf38b8710892 ("tpm/tpm_i2c_stm_st33: Split tpm_i2c_tpm_st33 in 2 layers (core + phy)") Signed-off-by: Jarkko Sakkinen --- drivers/char/tpm/st33zp24/i2c.c | 2 +- drivers/char/tpm/st33zp24/spi.c | 2 +- drivers/char/tpm/st33zp24/st33zp24.h | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/char/tpm/st33zp24/i2c.c b/drivers/char/tpm/st33zp24/i2c.c index be5d1abd3e8e..8390c5b54c3b 100644 --- a/drivers/char/tpm/st33zp24/i2c.c +++ b/drivers/char/tpm/st33zp24/i2c.c @@ -33,7 +33,7 @@ struct st33zp24_i2c_phy { struct i2c_client *client; - u8 buf[TPM_BUFSIZE + 1]; + u8 buf[ST33ZP24_BUFSIZE + 1]; int io_lpcpd; }; diff --git a/drivers/char/tpm/st33zp24/spi.c b/drivers/char/tpm/st33zp24/spi.c index d7909ab287a8..ff019a1e3c68 100644 --- a/drivers/char/tpm/st33zp24/spi.c +++ b/drivers/char/tpm/st33zp24/spi.c @@ -63,7 +63,7 @@ * some latency byte before the answer is available (max 15). * We have 2048 + 1024 + 15. */ -#define ST33ZP24_SPI_BUFFER_SIZE (TPM_BUFSIZE + (TPM_BUFSIZE / 2) +\ +#define ST33ZP24_SPI_BUFFER_SIZE (ST33ZP24_BUFSIZE + (ST33ZP24_BUFSIZE / 2) +\ MAX_SPI_LATENCY) diff --git a/drivers/char/tpm/st33zp24/st33zp24.h b/drivers/char/tpm/st33zp24/st33zp24.h index 6f4a4198af6a..20da0a84988d 100644 --- a/drivers/char/tpm/st33zp24/st33zp24.h +++ b/drivers/char/tpm/st33zp24/st33zp24.h @@ -18,8 +18,8 @@ #ifndef __LOCAL_ST33ZP24_H__ #define __LOCAL_ST33ZP24_H__ -#define TPM_WRITE_DIRECTION 0x80 -#define TPM_BUFSIZE 2048 +#define TPM_WRITE_DIRECTION 0x80 +#define ST33ZP24_BUFSIZE 2048 struct st33zp24_dev { struct tpm_chip *chip; -- 2.19.1