Received: by 2002:ac0:8c9a:0:0:0:0:0 with SMTP id r26csp741824ima; Fri, 1 Feb 2019 10:14:50 -0800 (PST) X-Google-Smtp-Source: ALg8bN4dPEL20RWNmEZreVJAdd1PdvuLrPjpceajDvwdLmnuplvrbN6PEzROttyR4ocS4q7oFxQw X-Received: by 2002:a17:902:f64:: with SMTP id 91mr40448464ply.132.1549044890858; Fri, 01 Feb 2019 10:14:50 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1549044890; cv=none; d=google.com; s=arc-20160816; b=evKZGKoFQQjLZFUlVa0wNNAbYUQrJBKStjrKsm8fCLHcZfkHA8ypMtN5oiBbL+hV8H 8IIUAhtWuBgGCN5mOEOghEbg0fL7k0gB68TT2uHe07dTYSfG7G4CxDVzv/0WpzOjG1sb 4e12WAwOn0G5n57KyhW82rwu9YSN5xPH4d7ctyVx7WrEivmTsEU8Njfw/w4i5m8+EigW AptQixfovG4F9G4enfCsHAtO/jISOfLisiEde1f9KXmW2p7x4TwHKJKffN3KeILgOpeJ cRsdRa0va3bhSu9Xofdq7yKGI2APzzbBX+WeBP3Zcp1kgCNznrClmGjwA4DuCEBnqkIL 8DHA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=efaNZ1wRKAhi43tDuiCBaUa9H2jPg9MrMpzxWRty9I4=; b=L1Gz1qHk2lzi0FkAGo8LCr2gjc9cic019anpgDcKnNAedU47Jos5CIz9kSo24hBcbr QGjqMNFLnQDusKxydrZ/XWLZF0i9F8IxxCXKCmb6z+3HYDARqUDwuXRZCmFsJmdJiXYC QY4qANzODIYhpEIJAw+PeBbajaTF8Be7Gh7UE+VMDRBa41hf0Gt5rWKVU4Qu/Ahxibli o7xJ5a8wd7BIpqNR3MfuzWJrzQjBXB2ZuWsXNKVLw7y2dB7+2aKX+6X55aEw4TNLnnRb ltuFDHuPAoVllyNlDnjNIKHjFvq9Ijw8TprEudCmSJGE3qgNJZcs0rtZkVx3hx0Vhnn3 ZW3w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o6si7957431plh.23.2019.02.01.10.14.35; Fri, 01 Feb 2019 10:14:50 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730684AbfBARnE (ORCPT + 99 others); Fri, 1 Feb 2019 12:43:04 -0500 Received: from mga04.intel.com ([192.55.52.120]:29499 "EHLO mga04.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726486AbfBARnD (ORCPT ); Fri, 1 Feb 2019 12:43:03 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga104.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 01 Feb 2019 09:43:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,549,1539673200"; d="scan'208";a="271800974" Received: from gandrejc-mobl1.ger.corp.intel.com (HELO localhost) ([10.249.254.151]) by orsmga004.jf.intel.com with ESMTP; 01 Feb 2019 09:42:57 -0800 Date: Fri, 1 Feb 2019 19:42:56 +0200 From: Jarkko Sakkinen To: Mimi Zohar , christophe.ricard@gmail.com Cc: Roberto Sassu , david.safford@ge.com, monty.wiseman@ge.com, matthewgarrett@google.com, linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org, keyrings@vger.kernel.org, linux-kernel@vger.kernel.org, silviu.vlasceanu@huawei.com Subject: Re: [PATCH v9 6/6] tpm: pass an array of tpm_extend_digest structures to tpm_pcr_extend() Message-ID: <20190201174256.GA23559@linux.intel.com> References: <20190201100641.26936-1-roberto.sassu@huawei.com> <20190201100641.26936-7-roberto.sassu@huawei.com> <20190201133949.GE17861@linux.intel.com> <20190201134151.GF17861@linux.intel.com> <1549031589.6993.7.camel@linux.ibm.com> <20190201173330.GA5522@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190201173330.GA5522@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Feb 01, 2019 at 07:33:30PM +0200, Jarkko Sakkinen wrote: > On Fri, Feb 01, 2019 at 09:33:09AM -0500, Mimi Zohar wrote: > > Thanks! I just finished compiling, rebooting, and verifying the IMA > > boot-aggregate matches. > > > > While compiling, I saw some messages that "TPM_BUFSIZE is redefined" > > for tpm_i2c_infineon, tpm_i2c_nuvoton, and st33zp24. ?Didn't look to > > see if this is a result of this patch set or not. > > > > The IMA boot-aggregate matches the PCRs. > > > > Tested-by: Mimi Zohar (on x86 for TPM 1.2 & PTT > > TPM 2.0) > > Thank you. > > I found the reason for that warning. It is redefined, for reason unknown > to me in drivers/char/tpm/st33zp24/st33zp24.h (commit bf38b8710892). > > I'll post a fix to that commit ASAP. After that commit has been applied > I can apply Roberto's patches. Just sent. No need to any testing for that one. Just need one reviewed-by or even acked-by, and after that I will apply all Roberto's patches. /Jarkko