Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Renato Lui Geh <renatogeh@gmail.com>
Date:   Fri, 1 Feb 2019 15:55:16 -0200
To:     "Popa, Stefan Serban" <StefanSerban.Popa@analog.com>
Cc:     "renatogeh@gmail.com" <renatogeh@gmail.com>,
        "kernel-usp@googlegroups.com" <kernel-usp@googlegroups.com>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "Ardelean, Alexandru" <alexandru.Ardelean@analog.com>,
        "knaack.h@gmx.de" <knaack.h@gmx.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "jic23@kernel.org" <jic23@kernel.org>,
        "Hennerich, Michael" <Michael.Hennerich@analog.com>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "giuliano.belinassi@usp.br" <giuliano.belinassi@usp.br>,
        "pmeerw@pmeerw.net" <pmeerw@pmeerw.net>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v2 1/2] staging: iio: ad7780: add gain & filter gpio
 support
Message-ID: <20190201175514.7kerqvuln4mrhinp@renatolg>
References: <20190127203044.yytctplecwey4an4@renatolg>
 <1548850985.9460.23.camel@analog.com>
 <20190201145459.ukfzo6s4rvg4c5ri@renatolg>
 <1549036667.9460.41.camel@analog.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1549036667.9460.41.camel@analog.com>
User-Agent: NeoMutt/20180716
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 02/01, Popa, Stefan Serban wrote:
>
>Adding support for gpios, normally doesn't have anything to do with
>the information stored in the iio_chan_spec struct.
>Also, we need to try to work with the already defined attributes. In your
>case, setting the gain GPIO is equivalent to modifying the scale, while
>setting the filter GPIO results in a change in sampling frequency.
>Therefore, we need use a macro which has the IIO_CHAN_INFO_SCALE and
>IIO_CHAN_INFO_FREQUENCY flags set. I think AD_SD_CHANNEL should do just
>fine.
>I hope this answers your question.
>-Stefan

It does. Thank you. :)