Message-ID: <404B7D8D.1060801@keyaccess.nl>
Date: Sun, 07 Mar 2004 20:52:45 +0100
From: Rene Herman <rene.herman@keyaccess.nl>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4.1) Gecko/20031029
MIME-Version: 1.0
To: David Weinehall <tao@acc.umu.se>
CC: Horst von Brand <vonbrand@inf.utfsm.cl>,
       Eyal Lebedinsky <eyal@eyal.emu.id.au>, linux-kernel@vger.kernel.org
Subject: Re: Linux 2.4.26-pre2
References: <404AB6C7.7010803@eyal.emu.id.au> <200403071619.i27GJkOZ003480@eeyore.valparaiso.cl> <20040307192504.GS19111@khan.acc.umu.se>
In-Reply-To: <20040307192504.GS19111@khan.acc.umu.se>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 775
Lines: 21

David Weinehall wrote:

>>>In standard C we declare all variables at the top of a function. While
>>>some compilers allow extension, it is not a good idea to get used to
>>>them if we want portable code.
>>
>>Oh, come on. This is _kernel_ code, it won't ever be compiled with anything
>>not GCC-compatible.
> 
> Ugly warts don't become any less ugly just because gcc accepts them...

Mixing code and declarations is also c99. For (a sane) gcc specifically, 
you have to tell it -std=c89 -pedantic to have it even complain.

Rene.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/